Skip to content

Add files via upload+r eadme edit#1386

Open
Jah-yee wants to merge 1 commit into
hackclub:mainfrom
Jah-yee:Jah_yee_dino
Open

Add files via upload+r eadme edit#1386
Jah-yee wants to merge 1 commit into
hackclub:mainfrom
Jah-yee:Jah_yee_dino

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Mar 11, 2026

Copy link
Copy Markdown
Member

No description provided.

@mattsoh mattsoh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a readme commit!

@mattsoh mattsoh added the needs readme commit Needs the dinosaur added to the readme so everyone can see it :) label Apr 30, 2026
@Jah-yee

Jah-yee commented May 9, 2026

Copy link
Copy Markdown
Member Author

👋 Hi! This PR has been open for 59 days without a review. Just checking in - is this something you're still interested in merging? Happy to make any changes if needed!

@Jah-yee

Jah-yee commented May 9, 2026

Copy link
Copy Markdown
Member Author

👋 Hi! This PR has been open for 59 days without a review. Just checking in - is this something you're still interested in merging?

@Jah-yee

Jah-yee commented May 10, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review @mattsoh! The README.md modification IS already included in this PR (added 4 lines to the existing readme with usage instructions). The commit message "Add Jah_yee_dino" was just the branch name. The actual changes are:

  • Added Jah_yee_dino.png (dinosaur image)
  • Modified README.md (added 4 lines)

Would you like me to rename the commit message or add any additional readme content?

@Jah-yee

Jah-yee commented May 10, 2026

Copy link
Copy Markdown
Member Author

Hi @mattsoh, just checking in — the PR does include the README.md update (adding the Jah_yee entry and image). The commit message was amended to 'docs: add Jah_yee entry and image to README' in the previous force-push.

Could you take another look? Happy to make any changes if the README content needs adjustments 🙏

@Jah-yee

Jah-yee commented May 11, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review! Could you clarify what you'd like changed? Do you mean:

  1. A more descriptive commit message for the README change, or
  2. A separate commit just for the README edit (as opposed to the image file)?

Happy to adjust - just want to make sure I address your feedback correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs readme commit Needs the dinosaur added to the readme so everyone can see it :)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants