From e202be5fb6174e0bf10010bfbbaf6c2cf5cd1ea1 Mon Sep 17 00:00:00 2001 From: Chris M Date: Sat, 18 Jan 2020 15:30:30 -0800 Subject: [PATCH] Feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Election Time | Requirement | Comments |---|--- | Well formatted code | You are using variable names like `g`, `m`, and `d`, these are not terribly meaningful. You also have some extraneous spacing like on line 36. You are also using 4-space indentation instead of 2-space indents. | Reads in votes | 👍 | Outputs the total for each candidate | 👍 | Determines the winner | 👍 | `Optional` Handle ties for a winner appropriately | NA | `Optional` Handle grammar of vote summary saying vote or votes appropriately | NA | `Optional` Handle write in votes | NA | `Optional` Consider how to handle more than 10 votes | NA | `Optional` Consider how to handle more than 3 candidates | NA ## Summary Nice work, you hit all the basic learning goals here. Consider if you used a hash with the candidate names as keys and the values being the vote count. Would that simplify things? --- ET00.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/ET00.rb b/ET00.rb index a4f80c0..1a108b8 100644 --- a/ET00.rb +++ b/ET00.rb @@ -1,3 +1,4 @@ +# Feedback #Student Hala Haddad #this file includes the solution to the Election Time assignment, assignment asks student to prompt voter