Exporting definition bug

[noughtmare]

Your environment

Which OS do you use?
MacOS
Which version of GHC do you use and how did you install it?
9.10.3 from ghcup
How is your project built (alternative: link to the project)?
hadrian (it is GHC)

Which LSP client (editor/plugin) do you use?
VS Codium+vscode-haskell
Which version of HLS do you use and how did you install it?
2.12.0.0 from ghcup
Have you configured HLS in any way (especially: a hie.yaml file)?
Yes the GHC hie.yaml file

Steps to reproduce

1. Clone the GHC repo
2. Check out 443d8e86464d42c52090447db2416033f3dd0901
3. Run ./boot and configure (using configure_ghc using ghc.nix)
4. Open compiler/GHC/Builtin/Types/Prim.hs in VSCodium
5. Remove the byteArrayLiftedPrimTy, export
6. Try to use HLS to export byteArrayLiftedPrimTy

Expected behaviour

It should add back byteArrayLiftedPrimTy, so that that line of the export looks like:

        levity1TyVarInf, levity2TyVarInf,byteArrayLiftedPrimTyConName, byteArrayLiftedPrimTy,

Actual behaviour

It changes that line to:

        levity1TyVarInf, levity2TyVarInf,byteArrayLiftedPrimTybyteArrayLiftedPrimTyConName,

Which is an error.

[crtschin]

I've had this happen a few times as well. This is caused by the text manipulation the refactor plugin uses to splice in exports. I believe this should be fixed by #4952.

If you have some time, could you try out the above PR and see if it solves your issue?

[noughtmare]

I don't think I can easily compile that PR, can I? ghcup compile hls --git-ref crtschin/export-1-export --ghc 9.10.3 does not work.

[crtschin]

Ah right, you mentioned using ghcup. It's going to be a bit trickier then I think, I can only assume ghcup does the sane thing and only allows branches from this repo. The linked PR is using a fork.

If your really keen, I believe you'd have to clone the fork manually, build, and then point vscode to the built binary. Though that'd take a while, I understand if that's a bit much. I'll put this on my list to verify the PR fixes.

[fendor]

ghcup compile hls --git-ref crtschin/export-1-export --ghc 9.10.3 -r https://github.com/crtschin/haskell-language-server should work

[noughtmare]

Oh, I now realize that of course I use ghc.nix to develop GHC which provisions its own HLS. I'll see if I can point VSCode to the HLS that GHCup compiled.

[crtschin]

I'll go ahead and close this. The fresh-off-the-press hls-export-plugin solves this, including most CPP-related cases now.