Skip to content

Inconsistent argument order between backward.h and backward.cu #28

@19reborn

Description

@19reborn

Thanks for your excellent work. I noticed a potential inconsistency in the render function between backward.h and backward.cu.

Specifically:

  • In lines 700 and 701 of backward.cu, the order of parameters has colors first, followed by transMats.
  • However, in the backward.h definition, their order is reversed.

While this discrepancy likely doesn't cause any bugs during execution, it might lead to confusion or misunderstandings for those reading or attempting to re-implement your code.

Thank you for your attention.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions