From 3acde8fe09825bfe153ca6b39a5cac74a3f11124 Mon Sep 17 00:00:00 2001 From: spapi Date: Mon, 16 Mar 2026 16:26:42 +0100 Subject: [PATCH 1/8] Add "vad" to readthedocs extra_requirements --- .readthedocs.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.readthedocs.yaml b/.readthedocs.yaml index 3c7cd15..17bb915 100644 --- a/.readthedocs.yaml +++ b/.readthedocs.yaml @@ -24,3 +24,4 @@ python: extra_requirements: - dev - eval + - vad From 752ff66cdf1a172174f7f9c0f89f2a11142c3221 Mon Sep 17 00:00:00 2001 From: spapi Date: Mon, 16 Mar 2026 18:05:39 +0100 Subject: [PATCH 2/8] Remove comments from rst file --- docs/source/_templates/custom-module-template.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/source/_templates/custom-module-template.rst b/docs/source/_templates/custom-module-template.rst index d70a849..4635585 100644 --- a/docs/source/_templates/custom-module-template.rst +++ b/docs/source/_templates/custom-module-template.rst @@ -8,7 +8,7 @@ .. rubric:: Module Attributes .. autosummary:: - :toctree: <-- add this line + :toctree: {% for item in attributes %} {{ item }} {%- endfor %} @@ -20,7 +20,7 @@ .. rubric:: {{ _('Functions') }} .. autosummary:: - :toctree: <-- add this line + :toctree: {% for item in functions %} {{ item }} {%- endfor %} @@ -32,8 +32,8 @@ .. rubric:: {{ _('Classes') }} .. autosummary:: - :toctree: <-- add this line - :template: custom-class-template.rst <-- add this line + :toctree: + :template: custom-class-template.rst {% for item in classes %} {{ item }} {%- endfor %} @@ -45,7 +45,7 @@ .. rubric:: {{ _('Exceptions') }} .. autosummary:: - :toctree: <-- add this line + :toctree: {% for item in exceptions %} {{ item }} {%- endfor %} @@ -58,7 +58,7 @@ .. autosummary:: :toctree: - :template: custom-module-template.rst <-- add this line + :template: custom-module-template.rst :recursive: {% for item in modules %} {{ item }} From 3c076fc2ec7bd06ac277b9959879d065fc5dca20 Mon Sep 17 00:00:00 2001 From: spapi Date: Mon, 16 Mar 2026 18:11:42 +0100 Subject: [PATCH 3/8] Enable autosummary generation from scratch to simulate Read The Docs environment --- docs/source/conf.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/source/conf.py b/docs/source/conf.py index a4bb800..348f813 100644 --- a/docs/source/conf.py +++ b/docs/source/conf.py @@ -28,6 +28,8 @@ "sphinx.ext.napoleon", ] +autosummary_generate = True + intersphinx_mapping = { 'python': ('https://docs.python.org/3/', None), 'sphinx': ('https://www.sphinx-doc.org/en/master/', None), From 852ad4fd52e7455eae176d35f966b010b8509e8e Mon Sep 17 00:00:00 2001 From: spapi Date: Mon, 16 Mar 2026 18:12:28 +0100 Subject: [PATCH 4/8] Add torchvision<0.18 constraint in case of "eval" dependency (connected to unbabel-comet dependency). --- pyproject.toml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 45a6581..a229e09 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -62,7 +62,8 @@ vad = [ eval = [ "unbabel-comet==2.2.6", "mweralign", - "sacrebleu" + "sacrebleu", + "torchvision<0.18" ] [tool.setuptools.dynamic] From 4ab1d5ddf62b111c391ca0d8046cf593bd9e799d Mon Sep 17 00:00:00 2001 From: spapi Date: Mon, 16 Mar 2026 18:29:51 +0100 Subject: [PATCH 5/8] Debug problematic comet import --- simulstream/metrics/scorers/quality/comet.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/simulstream/metrics/scorers/quality/comet.py b/simulstream/metrics/scorers/quality/comet.py index e1db3f4..f75d547 100644 --- a/simulstream/metrics/scorers/quality/comet.py +++ b/simulstream/metrics/scorers/quality/comet.py @@ -20,10 +20,11 @@ from simulstream.metrics.scorers.quality.mwersegmenter import MWERSegmenterBasedQualityScorer, \ ResegmentedQualityScoringSample -try: - from comet import download_model, load_from_checkpoint -except ImportError: - sys.exit("Please install comet first with `pip install unbabel-comet`.") +# try: +# from comet import download_model, load_from_checkpoint +# except ImportError: +# sys.exit("Please install comet first with `pip install unbabel-comet`.") +from comet import download_model, load_from_checkpoint @register_quality_scorer("comet") From a28bea93b5557c3efcc1ac578cd84abcb9dcdc1e Mon Sep 17 00:00:00 2001 From: spapi Date: Mon, 16 Mar 2026 18:35:51 +0100 Subject: [PATCH 6/8] Solve problematic comet import --- simulstream/metrics/scorers/quality/comet.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/simulstream/metrics/scorers/quality/comet.py b/simulstream/metrics/scorers/quality/comet.py index f75d547..6db4b25 100644 --- a/simulstream/metrics/scorers/quality/comet.py +++ b/simulstream/metrics/scorers/quality/comet.py @@ -13,17 +13,12 @@ # limitations under the License import argparse -import sys from typing import List from simulstream.metrics.scorers.quality import register_quality_scorer from simulstream.metrics.scorers.quality.mwersegmenter import MWERSegmenterBasedQualityScorer, \ ResegmentedQualityScoringSample -# try: -# from comet import download_model, load_from_checkpoint -# except ImportError: -# sys.exit("Please install comet first with `pip install unbabel-comet`.") from comet import download_model, load_from_checkpoint From 093e121ccdc22b6639ce480831545e7ef534fd20 Mon Sep 17 00:00:00 2001 From: spapi Date: Mon, 16 Mar 2026 18:39:24 +0100 Subject: [PATCH 7/8] Revert torchvision specification in eval --- pyproject.toml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index a229e09..45a6581 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -62,8 +62,7 @@ vad = [ eval = [ "unbabel-comet==2.2.6", "mweralign", - "sacrebleu", - "torchvision<0.18" + "sacrebleu" ] [tool.setuptools.dynamic] From 8a373ee3d1e1f8891ea0588e8a95cf884ded780e Mon Sep 17 00:00:00 2001 From: spapi Date: Mon, 16 Mar 2026 18:42:53 +0100 Subject: [PATCH 8/8] Revert autosummary generate --- docs/source/conf.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/source/conf.py b/docs/source/conf.py index 348f813..a4bb800 100644 --- a/docs/source/conf.py +++ b/docs/source/conf.py @@ -28,8 +28,6 @@ "sphinx.ext.napoleon", ] -autosummary_generate = True - intersphinx_mapping = { 'python': ('https://docs.python.org/3/', None), 'sphinx': ('https://www.sphinx-doc.org/en/master/', None),