From 36288ded0b7456d766e1106681b951317137356d Mon Sep 17 00:00:00 2001 From: Marat Faizov <77624397+Marat-Faizov@users.noreply.github.com> Date: Wed, 29 Sep 2021 16:50:22 +0100 Subject: [PATCH 1/9] added clipped text and button polyfill issues --- docs/common-issues/button-polyfill.md | 40 ++++++++++++++++++++++ docs/common-issues/clipped-text.md | 49 +++++++++++++++++++++++++++ 2 files changed, 89 insertions(+) create mode 100644 docs/common-issues/button-polyfill.md create mode 100644 docs/common-issues/clipped-text.md diff --git a/docs/common-issues/button-polyfill.md b/docs/common-issues/button-polyfill.md new file mode 100644 index 0000000..b2cc8c3 --- /dev/null +++ b/docs/common-issues/button-polyfill.md @@ -0,0 +1,40 @@ +# Issue: Link missing JavaScript polyfill to act as button [Draft] + +For link styled as a button add role="button" and initialise the JavaScript polyfill to ensure it acts as a button. +This makes sure that the link responds to spacebar keypress. +Assistive technology will interprite anchor as `button` with the ARIA role "button" and makes it clear that this is a button control and not a link. User would expect to activate element using `Enter` or `Space` key. + +## To resolve + +Add required data attribute (data-module="govuk-button") to enable button functionality. This makes sure that the link responds to the spacebar keypress. +Follow guidance [Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons) and initialise the JavaScript polyfill so that the link acts as a button. + +## Labels + +- wcag +- wcag 4.1.2 (A) + +## Report + +| Status | Level | Issue | Success Criterion | +| ------ | ----- | ----- | ----------------- | +| 🔴 (H) | A | [#issue]():Link missing JavaScript polyfill to act as button | 4.1.2 Name, Role, Value | + +## Statement + +### Accessibility problems +``` + tbc +``` + +### Milestones + +``` + tbc +``` + +## References + +[Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons) + +[Understanding Success Criterion 4.1.2 Name, Role, Value ](https://www.w3.org/WAI/WCAG21/Understanding/name-role-value) diff --git a/docs/common-issues/clipped-text.md b/docs/common-issues/clipped-text.md new file mode 100644 index 0000000..2f87814 --- /dev/null +++ b/docs/common-issues/clipped-text.md @@ -0,0 +1,49 @@ +# Issue: Text is clipped [Draft] + +Long string of text not breaking to accommodate the width of the parent container. The text gets clipped. + +## To resolve + +Most recent govuk-frontend should containe fix for this issue panel heading +https://github.com/alphagov/govuk-frontend/pull/2347. +Or apply `.text-overflow` class on element +This is create difficulties for people who rely on text to be resized without loss of the content. + +``` +.text-overflow { + word-wrap: break-word; /* old version of overflow-wrap for IE and Edge and FF < 49*/ + overflow-wrap: anywhere; /* modern, tries to fit word on a new line rather than fitting on remnants of the current line */ +} +``` +## Labels + +- wcag +- wcag 1.4.4 (AA) +- large text + +## Report + +| Status | Level | Issue | Success Criterion | +| ------ | ----- | ----- | ----------------- | +| 🟠 (M) | AA | [#issue]():Text is clipped | 1.4.4 Resize text | + +## Statement + +### Accessibility problems +``` + - description: When entering a long string of text it does not break to fit the container it is being added to, so it will overflow. Users will have to scroll horizontally to read it. This will also be a problem if the text size is increased. Additionally, seeing it will be difficult as it imight blend in with background colour. +``` + +### Milestones + +``` + - description: Copy missing text wrapping CSS properties, what causes issues when the text font size increased. This fails WCAG 2.1 success criterion 1.4.4 Resize text + date: TBC + +``` + +## References + +[govuk-font mixin - GOV.UK Frontend](https://frontend.design-system.service.gov.uk/sass-api-reference/#govuk-typography-responsive-usage) + +[Understanding Success Criterion 1.4.4 Resize text ](https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-scale.html) From 7c0869e0c80394ea33017970270671d6c6c26656 Mon Sep 17 00:00:00 2001 From: Marat Faizov <77624397+Marat-Faizov@users.noreply.github.com> Date: Thu, 30 Sep 2021 14:19:04 +0100 Subject: [PATCH 2/9] updated link as button issue --- docs/common-issues/button-polyfill.md | 40 --------------------------- docs/common-issues/link-as-button.md | 39 ++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 40 deletions(-) delete mode 100644 docs/common-issues/button-polyfill.md create mode 100644 docs/common-issues/link-as-button.md diff --git a/docs/common-issues/button-polyfill.md b/docs/common-issues/button-polyfill.md deleted file mode 100644 index b2cc8c3..0000000 --- a/docs/common-issues/button-polyfill.md +++ /dev/null @@ -1,40 +0,0 @@ -# Issue: Link missing JavaScript polyfill to act as button [Draft] - -For link styled as a button add role="button" and initialise the JavaScript polyfill to ensure it acts as a button. -This makes sure that the link responds to spacebar keypress. -Assistive technology will interprite anchor as `button` with the ARIA role "button" and makes it clear that this is a button control and not a link. User would expect to activate element using `Enter` or `Space` key. - -## To resolve - -Add required data attribute (data-module="govuk-button") to enable button functionality. This makes sure that the link responds to the spacebar keypress. -Follow guidance [Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons) and initialise the JavaScript polyfill so that the link acts as a button. - -## Labels - -- wcag -- wcag 4.1.2 (A) - -## Report - -| Status | Level | Issue | Success Criterion | -| ------ | ----- | ----- | ----------------- | -| 🔴 (H) | A | [#issue]():Link missing JavaScript polyfill to act as button | 4.1.2 Name, Role, Value | - -## Statement - -### Accessibility problems -``` - tbc -``` - -### Milestones - -``` - tbc -``` - -## References - -[Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons) - -[Understanding Success Criterion 4.1.2 Name, Role, Value ](https://www.w3.org/WAI/WCAG21/Understanding/name-role-value) diff --git a/docs/common-issues/link-as-button.md b/docs/common-issues/link-as-button.md new file mode 100644 index 0000000..94bef22 --- /dev/null +++ b/docs/common-issues/link-as-button.md @@ -0,0 +1,39 @@ +# Issue: Link styled as a button [Draft] + +For link styled as a button add role="button" and initialise the JavaScript polyfill to ensure it acts as a button. +This makes sure that the link responds to spacebar keypress. +Assistive technology will interpret anchor as `button` with the ARIA role "button" and makes it clear that this is a button control and not a link. User would expect to activate element using `Enter` or `Space` key. + +## To resolve +Make sure element uitilising [button.js](https://github.com/alphagov/govuk-frontend/blob/28ca6d5f61df309c00490f22d809bb6d7aaec7ab/src/components/button/button.js) allowing users to activate it using `space` key. +Follow guidance [Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons). +## Labels + +- wcag +- wcag 4.1.2 (A) + +## Report + +| Status | Level | Issue | Success Criterion | +| ------ | ----- | ----- | ----------------- | +| 🔴 (H) | A | [#issue]():Link styled as a button | 4.1.2 Name, Role, Value | + +## Statement + +### Accessibility problems +``` + - description: On the xxx page, the xxx link has been styled as a button but does not work with the spacebar key press +``` + +### Milestones + +``` + - description: For a link styled as a button, the role="button" and the JavaScript polyfill is missing to ensure it acts like a button. This fails WCAG 2.1 success criterion 4.1.2: Name, Role, Value + date: tbc +``` + +## References + +[Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons) + +[Understanding Success Criterion 4.1.2 Name, Role, Value ](https://www.w3.org/WAI/WCAG21/Understanding/name-role-value) From e24a5b283eae7e4697ee1845be36ee3a2651c884 Mon Sep 17 00:00:00 2001 From: Marat Faizov <77624397+Marat-Faizov@users.noreply.github.com> Date: Fri, 1 Oct 2021 11:20:26 +0100 Subject: [PATCH 3/9] added missing statement snippets --- .../conditionally-revealing-content.md | 6 ++++-- docs/common-issues/error-message.md | 7 +++---- docs/common-issues/error-summary-links.md | 6 ++++-- docs/common-issues/link-as-button.md | 5 +++-- docs/common-issues/welsh-translations.md | 15 +++++++++++++++ 5 files changed, 29 insertions(+), 10 deletions(-) diff --git a/docs/common-issues/conditionally-revealing-content.md b/docs/common-issues/conditionally-revealing-content.md index a82c359..7267932 100644 --- a/docs/common-issues/conditionally-revealing-content.md +++ b/docs/common-issues/conditionally-revealing-content.md @@ -28,13 +28,15 @@ If the content contains a link then it shouldn't be added as hint text as not al ### Accessibility problems ``` -tbc + - description: When user selects one of the options, hidden content is revealed below the selected option. This content may not be announced by assistive technology ``` ### Milestones ``` -tbc + - description: Conditionally revealing content is not always announced due to the implementation not meeting our service standard. This fails WCAG 2.1 success criterion 4.1.2 Name, Role, Value + date: TBC + ``` ## References diff --git a/docs/common-issues/error-message.md b/docs/common-issues/error-message.md index bc6dd95..de6f6d3 100644 --- a/docs/common-issues/error-message.md +++ b/docs/common-issues/error-message.md @@ -13,7 +13,7 @@ Ensure for each error scenario you write [clear and concise error messages](http ## Labels - wcag -- wcag 1.3.1 (A) +- wcag 3.3.3 (AA) - usability - error message @@ -21,7 +21,7 @@ Ensure for each error scenario you write [clear and concise error messages](http | Status | Level | Issue | Success Criterion | | ------ | ----- | ----- | ----------------- | -| 🔴 (H) | A | [#issue](): Error message text | 1.3.1 Info and Relationships | +| 🟠 (M) | AA | [#issue](): Error message text | 3.3.3 Error Suggestion (AA) | ## Statement @@ -41,5 +41,4 @@ tbc [Error message - GOV.UK Design System](https://design-system.service.gov.uk/components/error-message/) -[Understanding Success Criterion 1.3.1: Info and Relationships](https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships) - +[Understanding Success Criterion 3.3.3: Error Suggestion](https://www.w3.org/WAI/WCAG21/Understanding/error-suggestion.html) diff --git a/docs/common-issues/error-summary-links.md b/docs/common-issues/error-summary-links.md index 6f7dbe1..a9375ba 100644 --- a/docs/common-issues/error-summary-links.md +++ b/docs/common-issues/error-summary-links.md @@ -31,13 +31,15 @@ Ensure you are linking to the correct answer by following the [GOV.UK Design Sys ### Accessibility problems ``` -tbc + - description: The error message link in the error summary does not link to the form element in the error. ``` ### Milestones ``` -tbc + - description: The error message link in the error summary does not contain the valid link destination to the form element in error. This fails WCAG 2.1 success criterion 1.3.1 Info and relationships + date: TBC + ``` ## References diff --git a/docs/common-issues/link-as-button.md b/docs/common-issues/link-as-button.md index 94bef22..3c0312e 100644 --- a/docs/common-issues/link-as-button.md +++ b/docs/common-issues/link-as-button.md @@ -22,13 +22,14 @@ Follow guidance [Using links as buttons](https://github.com/hmrc/accessibility/b ### Accessibility problems ``` - - description: On the xxx page, the xxx link has been styled as a button but does not work with the spacebar key press + - description: On the xxx page, the xxx link has been styled as a button but does not work with the spacebar key press. A keyboard only user will need to use the enter key to activate this. + ``` ### Milestones ``` - - description: For a link styled as a button, the role="button" and the JavaScript polyfill is missing to ensure it acts like a button. This fails WCAG 2.1 success criterion 4.1.2: Name, Role, Value + - description: The link styled as button does not respond to the spacebar for keyboard only users. This fails WCAG 2.1 success criterion 4.1.2 Name, Role, Value date: tbc ``` diff --git a/docs/common-issues/welsh-translations.md b/docs/common-issues/welsh-translations.md index 46ee039..03c2e8b 100644 --- a/docs/common-issues/welsh-translations.md +++ b/docs/common-issues/welsh-translations.md @@ -28,6 +28,21 @@ However it is possible to send an override skip link to the @skipLinkBlock code | ------ | ----- | ----- | ----------------- | | 🟠 (M) | AA | [#issue](): Content not translated to Welsh | 3.1.2 Language of parts | +## Statement + +### Accessibility problems +``` + - description: When switching to the Welsh language version, the translation is not available. Additionally, the not translated text may not be pronounced correctly by screen readers. + +``` + +### Milestones + +``` + - description: Missing Welsh translations and appropriate language attributes on the copy can cause screen readers to mispronounce the copy. This fails WCAG 2.1 success criterion 3.1.2 Language of parts + date: tbc +``` + ## References [Language toggle - HMRC Design System](https://design.tax.service.gov.uk/hmrc-design-patterns/welsh-language-toggle/) From 65075089c16984f54b32bd521f72a0a19a66886e Mon Sep 17 00:00:00 2001 From: Marat Faizov <77624397+Marat-Faizov@users.noreply.github.com> Date: Fri, 1 Oct 2021 14:26:54 +0100 Subject: [PATCH 4/9] work on feedback --- docs/common-issues/clipped-text.md | 9 +++++---- docs/common-issues/link-as-button.md | 16 ++++++++++++---- docs/common-issues/welsh-translations.md | 2 +- 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/docs/common-issues/clipped-text.md b/docs/common-issues/clipped-text.md index 2f87814..0fc4ed9 100644 --- a/docs/common-issues/clipped-text.md +++ b/docs/common-issues/clipped-text.md @@ -1,13 +1,14 @@ # Issue: Text is clipped [Draft] -Long string of text not breaking to accommodate the width of the parent container. The text gets clipped. +Text is present which does not wrap to stay within the bounds of its parent container when user rely on text resizing. Increasing font size causing the text to either extend beyond the container, causing the layout to break or scrollbars to appear, or the text is clipped by the parent container and content is lost. +This create difficulties for people who rely on text to be resized without loss of the content. + ## To resolve Most recent govuk-frontend should containe fix for this issue panel heading https://github.com/alphagov/govuk-frontend/pull/2347. Or apply `.text-overflow` class on element -This is create difficulties for people who rely on text to be resized without loss of the content. ``` .text-overflow { @@ -31,13 +32,13 @@ This is create difficulties for people who rely on text to be resized without lo ### Accessibility problems ``` - - description: When entering a long string of text it does not break to fit the container it is being added to, so it will overflow. Users will have to scroll horizontally to read it. This will also be a problem if the text size is increased. Additionally, seeing it will be difficult as it imight blend in with background colour. + - description: When text is resized [named] text is cut off and so may not display the entire information intended. ``` ### Milestones ``` - - description: Copy missing text wrapping CSS properties, what causes issues when the text font size increased. This fails WCAG 2.1 success criterion 1.4.4 Resize text + - description: When text is resized, content is lost. This fails WCAG 2.1 success criterion 1.4.4 Resize text date: TBC ``` diff --git a/docs/common-issues/link-as-button.md b/docs/common-issues/link-as-button.md index 3c0312e..d453fa2 100644 --- a/docs/common-issues/link-as-button.md +++ b/docs/common-issues/link-as-button.md @@ -1,14 +1,22 @@ # Issue: Link styled as a button [Draft] -For link styled as a button add role="button" and initialise the JavaScript polyfill to ensure it acts as a button. -This makes sure that the link responds to spacebar keypress. -Assistive technology will interpret anchor as `button` with the ARIA role "button" and makes it clear that this is a button control and not a link. User would expect to activate element using `Enter` or `Space` key. +What about revising it to... + +For a link styled as a button, add role="button" and initialise the JavaScript polyfill to ensure it acts as a button. + +- Adding ARIA role="button" will identify the link as a button to assistive technologies. +- The JavaScript polyfill makes sure that the link responds to the enter and spacebar keypress. ## To resolve Make sure element uitilising [button.js](https://github.com/alphagov/govuk-frontend/blob/28ca6d5f61df309c00490f22d809bb6d7aaec7ab/src/components/button/button.js) allowing users to activate it using `space` key. -Follow guidance [Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons). + +Follow Using links as buttons guidance . + ## Labels +- code quality +- usability +- keyboard-only - wcag - wcag 4.1.2 (A) diff --git a/docs/common-issues/welsh-translations.md b/docs/common-issues/welsh-translations.md index 03c2e8b..5639e50 100644 --- a/docs/common-issues/welsh-translations.md +++ b/docs/common-issues/welsh-translations.md @@ -32,7 +32,7 @@ However it is possible to send an override skip link to the @skipLinkBlock code ### Accessibility problems ``` - - description: When switching to the Welsh language version, the translation is not available. Additionally, the not translated text may not be pronounced correctly by screen readers. + - description: When switching to the Welsh language version, the parts of the text is not translated. Additionally, the not translated text may not be pronounced correctly by screen readers. ``` From 319a442aa376efd1b2cb0ad2377033cfce0604d5 Mon Sep 17 00:00:00 2001 From: Marat Faizov <77624397+Marat-Faizov@users.noreply.github.com> Date: Fri, 1 Oct 2021 14:31:07 +0100 Subject: [PATCH 5/9] work on feedback(missed label) --- docs/common-issues/link-as-button.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/common-issues/link-as-button.md b/docs/common-issues/link-as-button.md index d453fa2..c666591 100644 --- a/docs/common-issues/link-as-button.md +++ b/docs/common-issues/link-as-button.md @@ -14,6 +14,7 @@ Follow Using links as buttons guidance . ## Labels +- button - code quality - usability - keyboard-only From 3f2d1a5d1e02392cb8a1780b8fbaf785fb7afb4d Mon Sep 17 00:00:00 2001 From: shabana-ali <59563139+shabana-ali@users.noreply.github.com> Date: Fri, 1 Oct 2021 15:00:50 +0100 Subject: [PATCH 6/9] Update link-as-button.md Tidied up code --- docs/common-issues/link-as-button.md | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/docs/common-issues/link-as-button.md b/docs/common-issues/link-as-button.md index c666591..ee7312f 100644 --- a/docs/common-issues/link-as-button.md +++ b/docs/common-issues/link-as-button.md @@ -1,49 +1,41 @@ # Issue: Link styled as a button [Draft] -What about revising it to... +For a link styled as a button, add `role="button"` and initialise the JavaScript polyfill to ensure it acts as a button. -For a link styled as a button, add role="button" and initialise the JavaScript polyfill to ensure it acts as a button. - -- Adding ARIA role="button" will identify the link as a button to assistive technologies. -- The JavaScript polyfill makes sure that the link responds to the enter and spacebar keypress. +- Adding ARIA `role="button"` will identify the link as a button to assistive technologies. +- The JavaScript polyfill makes sure that the link responds to the enter and spacebar keypress. ## To resolve -Make sure element uitilising [button.js](https://github.com/alphagov/govuk-frontend/blob/28ca6d5f61df309c00490f22d809bb6d7aaec7ab/src/components/button/button.js) allowing users to activate it using `space` key. -Follow Using links as buttons guidance . +Follow guidance [Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons). ## Labels - +- wcag +- wcag 4.1.2 (A) - button - code quality -- usability - keyboard-only -- wcag -- wcag 4.1.2 (A) ## Report | Status | Level | Issue | Success Criterion | | ------ | ----- | ----- | ----------------- | -| 🔴 (H) | A | [#issue]():Link styled as a button | 4.1.2 Name, Role, Value | +| 🔴 (H) | A | [#issue](): Link styled as a button | 4.1.2 Name, Role, Value | ## Statement ### Accessibility problems ``` - - description: On the xxx page, the xxx link has been styled as a button but does not work with the spacebar key press. A keyboard only user will need to use the enter key to activate this. - +on the [page title] page, the [link text] link has been styled as a button, but is not seen as one with assistive technologies and does not work with the spacebar keypress ``` ### Milestones - ``` - - description: The link styled as button does not respond to the spacebar for keyboard only users. This fails WCAG 2.1 success criterion 4.1.2 Name, Role, Value - date: tbc +for a link styled as a button, the role="button" and the JavaScript polyfill is missing to ensure it acts like a button. This fails WCAG 2.1 success criterion 4.1.2: Name, Role, Value ``` ## References [Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons) -[Understanding Success Criterion 4.1.2 Name, Role, Value ](https://www.w3.org/WAI/WCAG21/Understanding/name-role-value) +[Understanding Success Criterion 4.1.2 Name, Role, Value](https://www.w3.org/WAI/WCAG21/Understanding/name-role-value) From 7bdb7b34b7bc80be773fc5fe9761d9e12fd9edc2 Mon Sep 17 00:00:00 2001 From: Marat Faizov <77624397+Marat-Faizov@users.noreply.github.com> Date: Fri, 1 Oct 2021 16:16:18 +0100 Subject: [PATCH 7/9] removed -description and updated statement for one of the issues --- docs/common-issues/clipped-text.md | 4 ++-- docs/common-issues/conditionally-revealing-content.md | 4 ++-- docs/common-issues/error-summary-links.md | 4 ++-- docs/common-issues/welsh-translations.md | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/common-issues/clipped-text.md b/docs/common-issues/clipped-text.md index 0fc4ed9..2401a08 100644 --- a/docs/common-issues/clipped-text.md +++ b/docs/common-issues/clipped-text.md @@ -32,13 +32,13 @@ Or apply `.text-overflow` class on element ### Accessibility problems ``` - - description: When text is resized [named] text is cut off and so may not display the entire information intended. + when text is resized [named] text is cut off and so may not display the entire information intended. ``` ### Milestones ``` - - description: When text is resized, content is lost. This fails WCAG 2.1 success criterion 1.4.4 Resize text + when text is resized, content is lost. This fails WCAG 2.1 success criterion 1.4.4 Resize text date: TBC ``` diff --git a/docs/common-issues/conditionally-revealing-content.md b/docs/common-issues/conditionally-revealing-content.md index 7267932..e4d1220 100644 --- a/docs/common-issues/conditionally-revealing-content.md +++ b/docs/common-issues/conditionally-revealing-content.md @@ -28,13 +28,13 @@ If the content contains a link then it shouldn't be added as hint text as not al ### Accessibility problems ``` - - description: When user selects one of the options, hidden content is revealed below the selected option. This content may not be announced by assistive technology + when user selects one of the options, hidden content is revealed below the selected option. This content may not be announced by assistive technology ``` ### Milestones ``` - - description: Conditionally revealing content is not always announced due to the implementation not meeting our service standard. This fails WCAG 2.1 success criterion 4.1.2 Name, Role, Value + when text is conditionally revealed, it is unlikely to be discovered by a screen reader user in 'forms mode' as the text is not focusable. This fails WCAG 2.1 success criterion 4.1.2 Name, Role, Value date: TBC ``` diff --git a/docs/common-issues/error-summary-links.md b/docs/common-issues/error-summary-links.md index a9375ba..3b94bb6 100644 --- a/docs/common-issues/error-summary-links.md +++ b/docs/common-issues/error-summary-links.md @@ -31,13 +31,13 @@ Ensure you are linking to the correct answer by following the [GOV.UK Design Sys ### Accessibility problems ``` - - description: The error message link in the error summary does not link to the form element in the error. + the error message link in the error summary does not link to the form element in the error. ``` ### Milestones ``` - - description: The error message link in the error summary does not contain the valid link destination to the form element in error. This fails WCAG 2.1 success criterion 1.3.1 Info and relationships + the error message link in the error summary does not contain the valid link destination to the form element in error. This fails WCAG 2.1 success criterion 1.3.1 Info and relationships date: TBC ``` diff --git a/docs/common-issues/welsh-translations.md b/docs/common-issues/welsh-translations.md index 5639e50..0eb6309 100644 --- a/docs/common-issues/welsh-translations.md +++ b/docs/common-issues/welsh-translations.md @@ -32,14 +32,14 @@ However it is possible to send an override skip link to the @skipLinkBlock code ### Accessibility problems ``` - - description: When switching to the Welsh language version, the parts of the text is not translated. Additionally, the not translated text may not be pronounced correctly by screen readers. + when switching to the Welsh language version, the parts of the text is not translated. Additionally, the not translated text may not be pronounced correctly by screen readers. ``` ### Milestones ``` - - description: Missing Welsh translations and appropriate language attributes on the copy can cause screen readers to mispronounce the copy. This fails WCAG 2.1 success criterion 3.1.2 Language of parts + missing Welsh translations and appropriate language attributes on the copy can cause screen readers to mispronounce the copy. This fails WCAG 2.1 success criterion 3.1.2 Language of parts date: tbc ``` From 8af1e2aabb2a366a467d1af4f8226d0a16fa84f5 Mon Sep 17 00:00:00 2001 From: Marat Faizov <77624397+Marat-Faizov@users.noreply.github.com> Date: Fri, 1 Oct 2021 16:29:54 +0100 Subject: [PATCH 8/9] added two isues to read me --- docs/common-issues/readme.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/common-issues/readme.md b/docs/common-issues/readme.md index 41afdf8..283439d 100644 --- a/docs/common-issues/readme.md +++ b/docs/common-issues/readme.md @@ -30,3 +30,5 @@ - [Timeout dialog missing](https://github.com/hmrc/accessibility/blob/master/docs/common-issues/timeout-dialog.md) Draft - [Timeout dialog doesn't extend session](https://github.com/hmrc/accessibility/blob/master/docs/common-issues/timeout-dialog-cannot-extend-session.md) Draft - [Page title incomplete](https://github.com/hmrc/accessibility/blob/master/docs/common-issues/page-title-incomplete.md) Draft +- [Text is clipped](https://github.com/hmrc/accessibility/blob/master/docs/common-issues/clipped-text.md) Draft +- [Link styled as a button](https://github.com/hmrc/accessibility/blob/master/docs/common-issues/link-as-button.md) Draft \ No newline at end of file From 5dafb13f16554401ee84917cb44653287af376ed Mon Sep 17 00:00:00 2001 From: Marat Faizov <77624397+Marat-Faizov@users.noreply.github.com> Date: Fri, 15 Oct 2021 10:11:21 +0100 Subject: [PATCH 9/9] updated link as button issue to include data-module attr --- docs/common-issues/link-as-button.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/common-issues/link-as-button.md b/docs/common-issues/link-as-button.md index ee7312f..9ce1517 100644 --- a/docs/common-issues/link-as-button.md +++ b/docs/common-issues/link-as-button.md @@ -1,9 +1,9 @@ # Issue: Link styled as a button [Draft] -For a link styled as a button, add `role="button"` and initialise the JavaScript polyfill to ensure it acts as a button. +For a link styled as a button, add `role="button"` and `data-module="govuk-button"` to initialise the JavaScript polyfill to ensure it acts as a button. - Adding ARIA `role="button"` will identify the link as a button to assistive technologies. -- The JavaScript polyfill makes sure that the link responds to the enter and spacebar keypress. +- Adding `data-module="govuk-button"` makes sure that the link responds to the enter and spacebar keypress. ## To resolve @@ -31,7 +31,7 @@ on the [page title] page, the [link text] link has been styled as a button, but ### Milestones ``` -for a link styled as a button, the role="button" and the JavaScript polyfill is missing to ensure it acts like a button. This fails WCAG 2.1 success criterion 4.1.2: Name, Role, Value +for a link styled as a button, the role="button" and the data-module="govuk-button" is missing to ensure it acts like a button. This fails WCAG 2.1 success criterion 4.1.2: Name, Role, Value ``` ## References