Skip to content

Fix: change settings category from homepage to system#129

Open
Amirhesp wants to merge 2 commits into
holochain:mainfrom
Amirhesp:conf/ai-setting
Open

Fix: change settings category from homepage to system#129
Amirhesp wants to merge 2 commits into
holochain:mainfrom
Amirhesp:conf/ai-setting

Conversation

@Amirhesp

@Amirhesp Amirhesp commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator

Summary

TODO:

  • CHANGELOG(s) updated with appropriate info
  • docs updated (pnpm run build:doc)

Summary by CodeRabbit

  • Bug Fixes
    • Corrected Android Settings categorization for the system settings integration on Android. When enabled, it now appears under the “System” section instead of the homepage, improving placement and discoverability within device settings.

@cocogitto-bot

cocogitto-bot Bot commented Aug 27, 2025

Copy link
Copy Markdown

❌ Found 0 compliant commit and 1 non-compliant commits in f1b03af.

Commit f1b03af by @Amirhesp is not conform to the conventional commit specification :

  • message: Adding ia.system meta data to the manifest.xml
  • cause:
    Missing commit type separator `:`
    
    Caused by:
         --> 1:7
          |
        1 | Adding ia.system meta data to the manifest.xml
          |       ^---
          |
          = expected scope or type_separator
    

@coderabbitai

coderabbitai Bot commented Aug 27, 2025

Copy link
Copy Markdown

Walkthrough

Updated the AndroidManifest fragment generated by build.rs for the system_settings feature: the meta-data value for com.android.settings.category was changed from com.android.settings.category.ia.homepage to com.android.settings.category.ia.system. No other changes.

Changes

Cohort / File(s) Summary
Android manifest metadata tweak
apps/android-service-runtime/src-tauri/build.rs
Adjust meta-data value in manifest fragment for system_settings feature: com.android.settings.category.ia.homepagecom.android.settings.category.ia.system; no other logic or API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Amirhesp Amirhesp closed this Aug 27, 2025
@Amirhesp Amirhesp reopened this Aug 27, 2025
@Amirhesp Amirhesp changed the title Adding ia.system meta-data to the manifest.xml feat(manifest): add ia.system meta data to AndroidManifest.xml Aug 27, 2025
@ThetaSinner ThetaSinner requested a review from a team August 27, 2025 10:28
@Amirhesp Amirhesp had a problem deploying to Android Service Runtime Release August 27, 2025 10:28 — with GitHub Actions Failure
@Amirhesp Amirhesp had a problem deploying to Android Service Runtime Release August 27, 2025 10:28 — with GitHub Actions Failure
@Amirhesp Amirhesp temporarily deployed to Android Service Runtime Release August 27, 2025 10:28 — with GitHub Actions Inactive
@matthme

matthme commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

@Amirhesp can you provide some more context about this PR?

@Amirhesp

Amirhesp commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator Author

@Amirhesp can you provide some more context about this PR?

Hi @matthme, thanks for reviewing.
This PR only adds the com.android.settings.category.ia.system meta-data entry to AndroidManifest.xml.
The purpose is to make sure the service shows up under the correct System category in Android Settings. This improves discoverability and keeps the app aligned with Android’s guidelines.
It doesn’t touch any runtime logic — just a manifest update — so it’s a safe, isolated change.

@matthme

matthme commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

@Amirhesp how does it relate to the already existing metadata field that gets added with the system_settings feature enabled:

<meta-data android:name="com.android.settings.category"
android:value="com.android.settings.category.ia.homepage" />

Wouldn't that cover what you need? It also says that this yaml file is auto-generated so are you sure it should be modified in that generated file?

@Amirhesp

Copy link
Copy Markdown
Collaborator Author

@Amirhesp how does it relate to the already existing metadata field that gets added with the system_settings feature enabled:

<meta-data android:name="com.android.settings.category"
android:value="com.android.settings.category.ia.homepage" />

Wouldn't that cover what you need? It also says that this yaml file is auto-generated so are you sure it should be modified in that generated file?

@matthme Both entries refer to the same metadata key com.android.settings.category, but with different category values:

com.android.settings.category.ia.homepage: adds the entry to the Settings homepage/dashboard.

com.android.settings.category.ia.system: categorizes it under the System section in Settings (used by AOSP Settings for System pages).

@matthme

matthme commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Okay. I'm not very familiar with tauri 2 and android so apologize if I'm asking stupid questions. I may have wrong implicit assumptions.

Both entries refer to the same metadata key com.android.settings.category, but with different category values

I can see that but that doesn't fully answer my question. It seems like the values are contradicting each other then? Is your problem that the setting is currently showing up under "homepage" but it should show up under "system"? In that case it seems to me that it should get modified at the source in the Rust file, rather than downstream in the auto-generated yaml file (which I'm assuming is generated based on the Rust file).

@Amirhesp

Amirhesp commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator Author

Okay. I'm not very familiar with tauri 2 and android so apologize if I'm asking stupid questions. I may have wrong implicit assumptions.

Both entries refer to the same metadata key com.android.settings.category, but with different category values

I can see that but that doesn't fully answer my question. It seems like the values are contradicting each other then? Is your problem that the setting is currently showing up under "homepage" but it should show up under "system"? In that case it seems to me that it should get modified at the source in the Rust file, rather than downstream in the auto-generated yaml file (which I'm assuming is generated based on the Rust file).

ٔNot stupid at all, you're right.
Yes, I want it to show up under "system", so it's better to modify the android-service-runtime/apps/android-service-runtime/src-tauri/build.rs.
I'll do the modification and push it.
Thank you!

@Amirhesp Amirhesp changed the title feat(manifest): add ia.system meta data to AndroidManifest.xml Fix: change settings category from homepage to system Aug 27, 2025

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/android-service-runtime/src-tauri/build.rs (2)

19-20: Use a proper summary string, not the title, for Settings’ summary line

Consider pointing com.android.settings.summary to a dedicated summary string for better UX.

If you already have a summary resource, update this line:

-    <meta-data android:name="com.android.settings.summary"
-            android:resource="@string/main_activity_title" />
+    <meta-data android:name="com.android.settings.summary"
+            android:resource="@string/settings_summary" />

1-3: Don’t forget the PR housekeeping (CHANGELOG + docs)

Per the PR TODOs, update CHANGELOG(s) and regenerate docs. I can help draft the entry if you want.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 48ea2a2 and 2de9a77.

📒 Files selected for processing (1)
  • apps/android-service-runtime/src-tauri/build.rs (1 hunks)
🔇 Additional comments (2)
apps/android-service-runtime/src-tauri/build.rs (2)

17-18: Category switched to ia.system — aligns with desired placement under Settings > System

Using com.android.settings.category.ia.system with the IA_SETTINGS action is the right combo for surfacing the activity under the System section. No runtime impact; manifest-only.


4-23: No duplicate metadata detected

I’ve scanned every AndroidManifest.xml and the repository for com.android.settings.category and com.android.settings.action.IA_SETTINGS, and the only occurrences are in the build.rs fragment under the system_settings feature. There are no legacy ia.homepage injections or other manifest entries that could collide, and the system_settings = [] feature is correctly declared in apps/android-service-runtime/src-tauri/Cargo.toml. The final merged manifest will therefore contain exactly one com.android.settings.category (with value ia.system).

@matthme

matthme commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

@Amirhesp great, thank you 👍 . One more question, does the actual AndroidManifest.yml need to get rebuilt and commited now?

@Amirhesp

Copy link
Copy Markdown
Collaborator Author

@Amirhesp great, thank you 👍 . One more question, does the actual AndroidManifest.yml need to get rebuilt and commited now?

Yes, it does.
Thanks!

@Amirhesp Amirhesp temporarily deployed to Android Service Runtime Release August 29, 2025 13:22 — with GitHub Actions Inactive
@Amirhesp Amirhesp had a problem deploying to Android Service Runtime Release August 29, 2025 13:22 — with GitHub Actions Failure
@Amirhesp Amirhesp had a problem deploying to Android Service Runtime Release August 29, 2025 13:22 — with GitHub Actions Failure
@Amirhesp

Copy link
Copy Markdown
Collaborator Author

@Amirhesp great, thank you 👍 . One more question, does the actual AndroidManifest.yml need to get rebuilt and commited now?

Yes, it does. Thanks!

@matthme I compiled the app, and the manifest.xml file didn’t change, so we can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants