Trigger
Spotted by Copilot review on #925. Both spec-sdk-tests/package.json and spec-sdk-tests/tsconfig.json reference the local TS SDK at ../../../sdks/outpost-typescript (three levels up from spec-sdk-tests/), which resolves outside the repo. The correct path is one level up.
Why it's vestigial today
Every test file imports the SDK via direct relative path instead of the package name:
import { Outpost } from '../../sdks/outpost-typescript/dist/commonjs';
So the @hookdeck/outpost-sdk package alias is never used, and npm install doesn't fail on the bad file: reference (modern npm accepts it without verifying the target exists at install time).
Why fix anyway
- It's confusing for anyone reading the config and trying to figure out the intended setup.
- Future test code that imports via the package name (the more idiomatic pattern) would silently break.
- The misconfiguration sets a wrong expectation about how spec-sdk-tests should be wired.
Fix options
- Correct the paths in both files to
../sdks/outpost-typescript (one level up). Imports via @hookdeck/outpost-sdk would then actually work, and the package alias becomes the recommended import style.
- Remove the alias entirely (drop the
file: dep and the tsconfig paths). Tests already use direct relative imports; this matches what's actually done.
Option 1 is forward-looking; option 2 is honest about today's pattern. Either is fine.
Related
🤖 Generated with Claude Code
Trigger
Spotted by Copilot review on #925. Both
spec-sdk-tests/package.jsonandspec-sdk-tests/tsconfig.jsonreference the local TS SDK at../../../sdks/outpost-typescript(three levels up fromspec-sdk-tests/), which resolves outside the repo. The correct path is one level up.Why it's vestigial today
Every test file imports the SDK via direct relative path instead of the package name:
So the
@hookdeck/outpost-sdkpackage alias is never used, andnpm installdoesn't fail on the badfile:reference (modern npm accepts it without verifying the target exists at install time).Why fix anyway
Fix options
../sdks/outpost-typescript(one level up). Imports via@hookdeck/outpost-sdkwould then actually work, and the package alias becomes the recommended import style.file:dep and thetsconfigpaths). Tests already use direct relative imports; this matches what's actually done.Option 1 is forward-looking; option 2 is honest about today's pattern. Either is fine.
Related
🤖 Generated with Claude Code