Optimize operation-name builder for oversized inputs

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -92,10 +92,11 @@ def build_operation_name(prefix: object, identifier: object) -> str:
         for character in normalized_identifier
     )
 
-    operation_name = f"{normalized_prefix}{normalized_identifier}".strip()
-    if not operation_name:
-        operation_name = "operation"
-    if len(operation_name) <= _MAX_OPERATION_NAME_LENGTH:
+    combined_length = len(normalized_prefix) + len(normalized_identifier)
+    if combined_length <= _MAX_OPERATION_NAME_LENGTH:
+        operation_name = f"{normalized_prefix}{normalized_identifier}".strip()
+        if not operation_name:
+            return "operation"
         return operation_name
     available_identifier_length = (
         _MAX_OPERATION_NAME_LENGTH

tests/test_polling.py

@@ -60,6 +60,13 @@ def test_build_fetch_operation_name_sanitizes_non_string_and_control_input():
     assert numeric_operation_name == "Fetching 123"
 
 
+def test_build_fetch_operation_name_bounds_very_large_operation_names():
+    operation_name = build_fetch_operation_name("x" * 10000)
+
+    assert operation_name.endswith("...")
+    assert len(operation_name) == 200
+
+
 def test_build_fetch_operation_name_handles_unstringifiable_input():
     class _BadOperationName:
         def __str__(self) -> str:
@@ -81,6 +88,14 @@ def test_build_operation_name_truncates_long_identifiers():
     assert len(operation_name) == 200
 
 
+def test_build_operation_name_handles_very_large_identifier_inputs():
+    operation_name = build_operation_name("crawl job ", "x" * 10000)
+
+    assert operation_name.startswith("crawl job ")
+    assert operation_name.endswith("...")
+    assert len(operation_name) == 200
+
+
 def test_build_operation_name_truncates_overlong_prefixes():
     long_prefix = "p" * 250
     operation_name = build_operation_name(long_prefix, "identifier")