Centralize shared job route builder helpers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -116,6 +116,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_job_poll_helper_usage.py` (shared terminal-status polling helper usage enforcement),
   - `tests/test_job_query_params_helper_usage.py` (shared scrape/crawl query-param helper usage enforcement),
   - `tests/test_job_request_helper_usage.py` (shared scrape/crawl/extract request-helper usage enforcement),
+  - `tests/test_job_route_builder_usage.py` (shared job/web request-helper route-builder usage enforcement),
   - `tests/test_job_route_constants_usage.py` (shared scrape/crawl/extract route-constant usage enforcement),
   - `tests/test_job_start_payload_helper_usage.py` (shared scrape/crawl start-payload helper usage enforcement),
   - `tests/test_job_wait_helper_boundary.py` (centralization boundary enforcement for wait-for-job helper primitives),

hyperbrowser/client/managers/job_request_utils.py

@@ -1,5 +1,6 @@
 from typing import Any, Dict, Optional, Type, TypeVar
 
+from .job_route_builders import build_job_route, build_job_status_route
 from .response_utils import parse_response_model
 
 T = TypeVar("T")
@@ -33,7 +34,7 @@ def get_job_status(
     operation_name: str,
 ) -> T:
     response = client.transport.get(
-        client._build_url(f"{route_prefix}/{job_id}/status"),
+        client._build_url(build_job_status_route(route_prefix, job_id)),
     )
     return parse_response_model(
         response.data,
@@ -52,7 +53,7 @@ def get_job(
     operation_name: str,
 ) -> T:
     response = client.transport.get(
-        client._build_url(f"{route_prefix}/{job_id}"),
+        client._build_url(build_job_route(route_prefix, job_id)),
         params=params,
     )
     return parse_response_model(
@@ -90,7 +91,7 @@ async def get_job_status_async(
     operation_name: str,
 ) -> T:
     response = await client.transport.get(
-        client._build_url(f"{route_prefix}/{job_id}/status"),
+        client._build_url(build_job_status_route(route_prefix, job_id)),
     )
     return parse_response_model(
         response.data,
@@ -109,7 +110,7 @@ async def get_job_async(
     operation_name: str,
 ) -> T:
     response = await client.transport.get(
-        client._build_url(f"{route_prefix}/{job_id}"),
+        client._build_url(build_job_route(route_prefix, job_id)),
         params=params,
     )
     return parse_response_model(

hyperbrowser/client/managers/job_route_builders.py

@@ -0,0 +1,12 @@
+def build_job_route(
+    route_prefix: str,
+    job_id: str,
+) -> str:
+    return f"{route_prefix}/{job_id}"
+
+
+def build_job_status_route(
+    route_prefix: str,
+    job_id: str,
+) -> str:
+    return f"{route_prefix}/{job_id}/status"

hyperbrowser/client/managers/web_request_utils.py

@@ -1,5 +1,6 @@
 from typing import Any, Dict, Optional, Type, TypeVar
 
+from .job_route_builders import build_job_route, build_job_status_route
 from .response_utils import parse_response_model
 
 T = TypeVar("T")
@@ -33,7 +34,7 @@ def get_web_job_status(
     operation_name: str,
 ) -> T:
     response = client.transport.get(
-        client._build_url(f"{route_prefix}/{job_id}/status"),
+        client._build_url(build_job_status_route(route_prefix, job_id)),
     )
     return parse_response_model(
         response.data,
@@ -52,7 +53,7 @@ def get_web_job(
     operation_name: str,
 ) -> T:
     response = client.transport.get(
-        client._build_url(f"{route_prefix}/{job_id}"),
+        client._build_url(build_job_route(route_prefix, job_id)),
         params=params,
     )
     return parse_response_model(
@@ -90,7 +91,7 @@ async def get_web_job_status_async(
     operation_name: str,
 ) -> T:
     response = await client.transport.get(
-        client._build_url(f"{route_prefix}/{job_id}/status"),
+        client._build_url(build_job_status_route(route_prefix, job_id)),
     )
     return parse_response_model(
         response.data,
@@ -109,7 +110,7 @@ async def get_web_job_async(
     operation_name: str,
 ) -> T:
     response = await client.transport.get(
-        client._build_url(f"{route_prefix}/{job_id}"),
+        client._build_url(build_job_route(route_prefix, job_id)),
         params=params,
     )
     return parse_response_model(

tests/test_architecture_marker_usage.py

@@ -60,6 +60,7 @@
     "tests/test_job_operation_metadata_usage.py",
     "tests/test_job_poll_helper_boundary.py",
     "tests/test_job_poll_helper_usage.py",
+    "tests/test_job_route_builder_usage.py",
     "tests/test_job_route_constants_usage.py",
     "tests/test_job_request_helper_usage.py",
     "tests/test_job_start_payload_helper_usage.py",

tests/test_core_type_helper_usage.py

@@ -49,6 +49,7 @@
     "hyperbrowser/client/managers/job_pagination_utils.py",
     "hyperbrowser/client/managers/job_query_params_utils.py",
     "hyperbrowser/client/managers/job_request_utils.py",
+    "hyperbrowser/client/managers/job_route_builders.py",
     "hyperbrowser/client/managers/job_route_constants.py",
     "hyperbrowser/client/managers/job_start_payload_utils.py",
     "hyperbrowser/client/managers/page_params_utils.py",

tests/test_job_route_builder_usage.py

@@ -0,0 +1,21 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+MODULES = (
+    "hyperbrowser/client/managers/job_request_utils.py",
+    "hyperbrowser/client/managers/web_request_utils.py",
+)
+
+
+def test_job_and_web_request_helpers_use_route_builders():
+    for module_path in MODULES:
+        module_text = Path(module_path).read_text(encoding="utf-8")
+        assert "job_route_builders import build_job_route, build_job_status_route" in module_text
+        assert "build_job_route(route_prefix, job_id)" in module_text
+        assert "build_job_status_route(route_prefix, job_id)" in module_text
+        assert 'f"{route_prefix}/{job_id}"' not in module_text
+        assert 'f"{route_prefix}/{job_id}/status"' not in module_text

tests/test_job_route_builders.py

@@ -0,0 +1,17 @@
+from hyperbrowser.client.managers.job_route_builders import (
+    build_job_route,
+    build_job_status_route,
+)
+
+
+def test_build_job_route_composes_job_route_path():
+    assert build_job_route("/scrape", "job_123") == "/scrape/job_123"
+    assert build_job_route("/web/crawl", "job_456") == "/web/crawl/job_456"
+
+
+def test_build_job_status_route_composes_job_status_route_path():
+    assert build_job_status_route("/scrape", "job_123") == "/scrape/job_123/status"
+    assert (
+        build_job_status_route("/web/crawl", "job_456")
+        == "/web/crawl/job_456/status"
+    )