Use Optional param annotations for manager create methods

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/profile.py

@@ -14,7 +14,9 @@ class ProfileManager:
     def __init__(self, client):
         self._client = client
 
-    async def create(self, params: CreateProfileParams = None) -> CreateProfileResponse:
+    async def create(
+        self, params: Optional[CreateProfileParams] = None
+    ) -> CreateProfileResponse:
         response = await self._client.transport.post(
             self._client._build_url("/profile"),
             data=(

hyperbrowser/client/managers/async_manager/session.py

@@ -44,7 +44,9 @@ def __init__(self, client):
         self._client = client
         self.event_logs = SessionEventLogsManager(client)
 
-    async def create(self, params: CreateSessionParams = None) -> SessionDetail:
+    async def create(
+        self, params: Optional[CreateSessionParams] = None
+    ) -> SessionDetail:
         response = await self._client.transport.post(
             self._client._build_url("/session"),
             data=(

hyperbrowser/client/managers/sync_manager/profile.py

@@ -14,7 +14,9 @@ class ProfileManager:
     def __init__(self, client):
         self._client = client
 
-    def create(self, params: CreateProfileParams = None) -> CreateProfileResponse:
+    def create(
+        self, params: Optional[CreateProfileParams] = None
+    ) -> CreateProfileResponse:
         response = self._client.transport.post(
             self._client._build_url("/profile"),
             data=(

hyperbrowser/client/managers/sync_manager/session.py

@@ -44,7 +44,7 @@ def __init__(self, client):
         self._client = client
         self.event_logs = SessionEventLogsManager(client)
 
-    def create(self, params: CreateSessionParams = None) -> SessionDetail:
+    def create(self, params: Optional[CreateSessionParams] = None) -> SessionDetail:
         response = self._client.transport.post(
             self._client._build_url("/session"),
             data=(

tests/test_manager_param_annotations.py

@@ -0,0 +1,36 @@
+from typing import Any, Type, Union, get_args, get_origin, get_type_hints
+
+from hyperbrowser.client.managers.async_manager.profile import (
+    ProfileManager as AsyncProfileManager,
+)
+from hyperbrowser.client.managers.async_manager.session import (
+    SessionManager as AsyncSessionManager,
+)
+from hyperbrowser.client.managers.sync_manager.profile import (
+    ProfileManager as SyncProfileManager,
+)
+from hyperbrowser.client.managers.sync_manager.session import (
+    SessionManager as SyncSessionManager,
+)
+from hyperbrowser.models.profile import CreateProfileParams
+from hyperbrowser.models.session import CreateSessionParams
+
+
+def _is_optional_annotation(annotation: Any, expected_type: Type[Any]) -> bool:
+    if get_origin(annotation) is not Union:
+        return False
+    args = set(get_args(annotation))
+    return expected_type in args and type(None) in args
+
+
+def test_create_manager_param_annotations_are_optional():
+    cases = [
+        (SyncSessionManager.create, "params", CreateSessionParams),
+        (AsyncSessionManager.create, "params", CreateSessionParams),
+        (SyncProfileManager.create, "params", CreateProfileParams),
+        (AsyncProfileManager.create, "params", CreateProfileParams),
+    ]
+
+    for method, param_name, expected_type in cases:
+        type_hints = get_type_hints(method)
+        assert _is_optional_annotation(type_hints[param_name], expected_type)