Centralize metadata default prefix constants

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/extension.py

@@ -2,7 +2,10 @@
 
 from ...file_utils import build_open_file_error_message, open_binary_file
 from ..extension_create_utils import normalize_extension_create_input
-from ..extension_operation_metadata import EXTENSION_OPERATION_METADATA
+from ..extension_operation_metadata import (
+    EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX,
+    EXTENSION_OPERATION_METADATA,
+)
 from ..extension_request_utils import (
     create_extension_resource_async,
     list_extension_resources_async,
@@ -30,7 +33,7 @@ async def create(self, params: CreateExtensionParams) -> ExtensionResponse:
             open_error_message=build_open_file_error_message(
                 file_path,
                 prefix=self._OPERATION_METADATA.open_file_error_prefix,
-                default_prefix="Failed to open extension file at path",
+                default_prefix=EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX,
             ),
         ) as extension_file:
             return await create_extension_resource_async(

hyperbrowser/client/managers/extension_create_utils.py

@@ -4,7 +4,11 @@
 from hyperbrowser.models.extension import CreateExtensionParams
 
 from ..file_utils import build_file_path_error_message, ensure_existing_file_path
-from .extension_operation_metadata import EXTENSION_OPERATION_METADATA
+from .extension_operation_metadata import (
+    EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX,
+    EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX,
+    EXTENSION_OPERATION_METADATA,
+)
 from .serialization_utils import serialize_model_dump_to_dict
 
 
@@ -32,12 +36,12 @@ def normalize_extension_create_input(params: Any) -> Tuple[str, Dict[str, Any]]:
         missing_file_message=build_file_path_error_message(
             raw_file_path,
             prefix=EXTENSION_OPERATION_METADATA.missing_file_message_prefix,
-            default_prefix="Extension file not found at path",
+            default_prefix=EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX,
         ),
         not_file_message=build_file_path_error_message(
             raw_file_path,
             prefix=EXTENSION_OPERATION_METADATA.not_file_message_prefix,
-            default_prefix="Extension file path must point to a file",
+            default_prefix=EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX,
         ),
     )
     return file_path, payload

hyperbrowser/client/managers/extension_operation_metadata.py

@@ -1,5 +1,9 @@
 from dataclasses import dataclass
 
+EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX = "Extension file not found at path"
+EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX = "Extension file path must point to a file"
+EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX = "Failed to open extension file at path"
+
 
 @dataclass(frozen=True)
 class ExtensionOperationMetadata:
@@ -11,7 +15,7 @@ class ExtensionOperationMetadata:
 
 EXTENSION_OPERATION_METADATA = ExtensionOperationMetadata(
     create_operation_name="create extension",
-    missing_file_message_prefix="Extension file not found at path",
-    not_file_message_prefix="Extension file path must point to a file",
-    open_file_error_prefix="Failed to open extension file at path",
+    missing_file_message_prefix=EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX,
+    not_file_message_prefix=EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX,
+    open_file_error_prefix=EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX,
 )

hyperbrowser/client/managers/session_operation_metadata.py

@@ -1,5 +1,9 @@
 from dataclasses import dataclass
 
+SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX = "Upload file not found at path"
+SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX = "Upload file path must point to a file"
+SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX = "Failed to open upload file at path"
+
 
 @dataclass(frozen=True)
 class SessionOperationMetadata:
@@ -27,9 +31,9 @@ class SessionOperationMetadata:
     video_recording_url_operation_name="session video recording url",
     downloads_url_operation_name="session downloads url",
     upload_file_operation_name="session upload file",
-    upload_missing_file_message_prefix="Upload file not found at path",
-    upload_not_file_message_prefix="Upload file path must point to a file",
-    upload_open_file_error_prefix="Failed to open upload file at path",
+    upload_missing_file_message_prefix=SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX,
+    upload_not_file_message_prefix=SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX,
+    upload_open_file_error_prefix=SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX,
     extend_operation_name="session extend",
     update_profile_operation_name="session update profile",
 )

hyperbrowser/client/managers/session_upload_utils.py

@@ -12,7 +12,12 @@
     ensure_existing_file_path,
     open_binary_file,
 )
-from .session_operation_metadata import SESSION_OPERATION_METADATA
+from .session_operation_metadata import (
+    SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX,
+    SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX,
+    SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX,
+    SESSION_OPERATION_METADATA,
+)
 
 
 def normalize_upload_file_input(
@@ -33,12 +38,12 @@ def normalize_upload_file_input(
             missing_file_message=build_file_path_error_message(
                 raw_file_path,
                 prefix=SESSION_OPERATION_METADATA.upload_missing_file_message_prefix,
-                default_prefix="Upload file not found at path",
+                default_prefix=SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX,
             ),
             not_file_message=build_file_path_error_message(
                 raw_file_path,
                 prefix=SESSION_OPERATION_METADATA.upload_not_file_message_prefix,
-                default_prefix="Upload file path must point to a file",
+                default_prefix=SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX,
             ),
         )
         return file_path, None
@@ -84,7 +89,7 @@ def open_upload_files_from_input(
             open_error_message=build_open_file_error_message(
                 file_path,
                 prefix=SESSION_OPERATION_METADATA.upload_open_file_error_prefix,
-                default_prefix="Failed to open upload file at path",
+                default_prefix=SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX,
             ),
         ) as opened_file:
             yield {"file": opened_file}

hyperbrowser/client/managers/sync_manager/extension.py

@@ -2,7 +2,10 @@
 
 from ...file_utils import build_open_file_error_message, open_binary_file
 from ..extension_create_utils import normalize_extension_create_input
-from ..extension_operation_metadata import EXTENSION_OPERATION_METADATA
+from ..extension_operation_metadata import (
+    EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX,
+    EXTENSION_OPERATION_METADATA,
+)
 from ..extension_request_utils import (
     create_extension_resource,
     list_extension_resources,
@@ -30,7 +33,7 @@ def create(self, params: CreateExtensionParams) -> ExtensionResponse:
             open_error_message=build_open_file_error_message(
                 file_path,
                 prefix=self._OPERATION_METADATA.open_file_error_prefix,
-                default_prefix="Failed to open extension file at path",
+                default_prefix=EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX,
             ),
         ) as extension_file:
             return create_extension_resource(

tests/test_extension_create_metadata_usage.py

@@ -15,6 +15,8 @@ def test_extension_create_helper_uses_shared_operation_metadata_prefixes():
     assert "extension_operation_metadata import" in module_text
     assert "EXTENSION_OPERATION_METADATA.missing_file_message_prefix" in module_text
     assert "EXTENSION_OPERATION_METADATA.not_file_message_prefix" in module_text
+    assert "EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX" in module_text
+    assert "EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX" in module_text
     assert (
         re.search(
             r'(?<!default_)prefix="Extension file not found at path"',

tests/test_extension_operation_metadata.py

@@ -1,7 +1,22 @@
 from hyperbrowser.client.managers.extension_operation_metadata import (
+    EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX,
+    EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX,
+    EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX,
     EXTENSION_OPERATION_METADATA,
 )
 
 
 def test_extension_operation_metadata_values():
     assert EXTENSION_OPERATION_METADATA.create_operation_name == "create extension"
+    assert (
+        EXTENSION_OPERATION_METADATA.missing_file_message_prefix
+        == EXTENSION_DEFAULT_MISSING_FILE_MESSAGE_PREFIX
+    )
+    assert (
+        EXTENSION_OPERATION_METADATA.not_file_message_prefix
+        == EXTENSION_DEFAULT_NOT_FILE_MESSAGE_PREFIX
+    )
+    assert (
+        EXTENSION_OPERATION_METADATA.open_file_error_prefix
+        == EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX
+    )

tests/test_extension_operation_metadata_usage.py

@@ -19,6 +19,7 @@ def test_extension_managers_use_shared_operation_metadata():
         assert "_OPERATION_METADATA = " in module_text
         assert "operation_name=self._OPERATION_METADATA." in module_text
         assert "prefix=self._OPERATION_METADATA.open_file_error_prefix" in module_text
+        assert "default_prefix=EXTENSION_DEFAULT_OPEN_FILE_ERROR_PREFIX" in module_text
         assert 'operation_name="' not in module_text
         assert (
             re.search(

tests/test_session_operation_metadata.py

@@ -1,4 +1,7 @@
 from hyperbrowser.client.managers.session_operation_metadata import (
+    SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX,
+    SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX,
+    SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX,
     SESSION_OPERATION_METADATA,
 )
 
@@ -18,6 +21,18 @@ def test_session_operation_metadata_values():
         == "session downloads url"
     )
     assert SESSION_OPERATION_METADATA.upload_file_operation_name == "session upload file"
+    assert (
+        SESSION_OPERATION_METADATA.upload_missing_file_message_prefix
+        == SESSION_DEFAULT_UPLOAD_MISSING_FILE_MESSAGE_PREFIX
+    )
+    assert (
+        SESSION_OPERATION_METADATA.upload_not_file_message_prefix
+        == SESSION_DEFAULT_UPLOAD_NOT_FILE_MESSAGE_PREFIX
+    )
+    assert (
+        SESSION_OPERATION_METADATA.upload_open_file_error_prefix
+        == SESSION_DEFAULT_UPLOAD_OPEN_FILE_ERROR_PREFIX
+    )
     assert SESSION_OPERATION_METADATA.extend_operation_name == "session extend"
     assert (
         SESSION_OPERATION_METADATA.update_profile_operation_name