Support stringifiable request methods in transport diagnostics

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/error_utils.py

@@ -1,4 +1,5 @@
 import json
+from numbers import Real
 import re
 from typing import Any
 
@@ -29,11 +30,20 @@
 
 def _normalize_request_method(method: Any) -> str:
     raw_method = method
+    if isinstance(raw_method, bool):
+        return "UNKNOWN"
+    if isinstance(raw_method, Real):
+        return "UNKNOWN"
     if isinstance(raw_method, (bytes, bytearray, memoryview)):
         try:
             raw_method = memoryview(raw_method).tobytes().decode("ascii")
         except (TypeError, ValueError, UnicodeDecodeError):
             return "UNKNOWN"
+    elif not isinstance(raw_method, str):
+        try:
+            raw_method = str(raw_method)
+        except Exception:
+            return "UNKNOWN"
     if not isinstance(raw_method, str) or not raw_method.strip():
         return "UNKNOWN"
     normalized_method = raw_method.strip().upper()

tests/test_transport_error_utils.py

@@ -44,6 +44,15 @@ class _InvalidMethodTokenRequest:
     url = "https://example.com/invalid-method"
 
 
+class _MethodLikeRequest:
+    class _MethodLike:
+        def __str__(self) -> str:
+            return "patch"
+
+    method = _MethodLike()
+    url = "https://example.com/method-like"
+
+
 class _WhitespaceInsideUrlRequest:
     method = "GET"
     url = "https://example.com/with space"
@@ -101,6 +110,12 @@ def request(self):  # type: ignore[override]
         return _InvalidMethodTokenRequest()
 
 
+class _RequestErrorWithMethodLikeContext(httpx.RequestError):
+    @property
+    def request(self):  # type: ignore[override]
+        return _MethodLikeRequest()
+
+
 class _RequestErrorWithWhitespaceInsideUrl(httpx.RequestError):
     @property
     def request(self):  # type: ignore[override]
@@ -198,6 +213,15 @@ def test_extract_request_error_context_rejects_invalid_method_tokens():
     assert url == "https://example.com/invalid-method"
 
 
+def test_extract_request_error_context_accepts_stringifiable_method_values():
+    method, url = extract_request_error_context(
+        _RequestErrorWithMethodLikeContext("network down")
+    )
+
+    assert method == "PATCH"
+    assert url == "https://example.com/method-like"
+
+
 def test_extract_request_error_context_rejects_urls_with_whitespace():
     method, url = extract_request_error_context(
         _RequestErrorWithWhitespaceInsideUrl("network down")
@@ -501,6 +525,19 @@ def test_format_generic_request_failure_message_normalizes_non_string_method_val
     assert message == "Request UNKNOWN https://example.com/path failed"
 
 
+def test_format_generic_request_failure_message_supports_stringifiable_method_values():
+    class _MethodLike:
+        def __str__(self) -> str:
+            return "delete"
+
+    message = format_generic_request_failure_message(
+        method=_MethodLike(),
+        url="https://example.com/path",
+    )
+
+    assert message == "Request DELETE https://example.com/path failed"
+
+
 def test_format_generic_request_failure_message_supports_memoryview_method_values():
     message = format_generic_request_failure_message(
         method=memoryview(b"patch"),