Require concrete response parser normalization outputs

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/response_utils.py

@@ -16,7 +16,7 @@ def _normalize_operation_name_for_error(operation_name: str) -> str:
             "?" if ord(character) < 32 or ord(character) == 127 else character
             for character in operation_name
         ).strip()
-        if not isinstance(normalized_name, str):
+        if type(normalized_name) is not str:
             raise TypeError("normalized operation name must be a string")
     except Exception:
         return "operation"
@@ -38,7 +38,7 @@ def _normalize_response_key_for_error(key: str) -> str:
             "?" if ord(character) < 32 or ord(character) == 127 else character
             for character in key
         ).strip()
-        if not isinstance(normalized_key, str):
+        if type(normalized_key) is not str:
             raise TypeError("normalized response key must be a string")
     except Exception:
         return "<unreadable key>"
@@ -62,7 +62,7 @@ def parse_response_model(
         raise HyperbrowserError("operation_name must be a non-empty string")
     try:
         normalized_operation_name_input = operation_name.strip()
-        if not isinstance(normalized_operation_name_input, str):
+        if type(normalized_operation_name_input) is not str:
             raise TypeError("normalized operation_name must be a string")
         is_empty_operation_name = len(normalized_operation_name_input) == 0
     except HyperbrowserError:

tests/test_response_utils.py

@@ -256,11 +256,10 @@ def strip(self, chars=None):  # type: ignore[override]
     assert isinstance(exc_info.value.original_error, TypeError)
 
 
-def test_parse_response_model_wraps_operation_name_empty_check_length_failures():
+def test_parse_response_model_wraps_operation_name_string_subclass_strip_results():
     class _BrokenOperationName(str):
         class _NormalizedName(str):
-            def __len__(self):
-                raise RuntimeError("operation name length exploded")
+            pass
 
         def strip(self, chars=None):  # type: ignore[override]
             _ = chars
@@ -273,30 +272,19 @@ def strip(self, chars=None):  # type: ignore[override]
             operation_name=_BrokenOperationName("basic operation"),
         )
 
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-def test_parse_response_model_preserves_hyperbrowser_operation_name_empty_check_length_failures():
-    class _BrokenOperationName(str):
-        class _NormalizedName(str):
-            def __len__(self):
-                raise HyperbrowserError("custom operation name length failure")
+    assert isinstance(exc_info.value.original_error, TypeError)
 
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return self._NormalizedName("basic operation")
 
+def test_parse_response_model_rejects_blank_operation_names():
     with pytest.raises(
-        HyperbrowserError, match="custom operation name length failure"
-    ) as exc_info:
+        HyperbrowserError, match="operation_name must be a non-empty string"
+    ):
         parse_response_model(
             {"success": True},
             model=BasicResponse,
-            operation_name=_BrokenOperationName("basic operation"),
+            operation_name="   ",
         )
 
-    assert exc_info.value.original_error is None
-
 
 def test_parse_response_model_truncates_operation_name_in_errors():
     long_operation_name = "basic operation " + ("x" * 200)