Require concrete env string inputs for config and headers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/config.py

@@ -350,7 +350,7 @@ def parse_headers_from_env(raw_headers: Optional[str]) -> Optional[Dict[str, str
     def resolve_base_url_from_env(raw_base_url: Optional[str]) -> str:
         if raw_base_url is None:
             return "https://api.hyperbrowser.ai"
-        if not isinstance(raw_base_url, str):
+        if type(raw_base_url) is not str:
             raise HyperbrowserError("HYPERBROWSER_BASE_URL must be a string")
         try:
             normalized_env_base_url = raw_base_url.strip()

hyperbrowser/header_utils.py

@@ -157,7 +157,7 @@ def merge_headers(
 def parse_headers_env_json(raw_headers: Optional[str]) -> Optional[Dict[str, str]]:
     if raw_headers is None:
         return None
-    if not isinstance(raw_headers, str):
+    if type(raw_headers) is not str:
         raise HyperbrowserError("HYPERBROWSER_HEADERS must be a string")
     try:
         normalized_raw_headers = raw_headers.strip()

tests/test_config.py

@@ -333,21 +333,7 @@ def strip(self, chars=None):  # type: ignore[override]
     assert isinstance(exc_info.value.original_error, TypeError)
 
 
-def test_client_config_resolve_base_url_from_env_wraps_strip_runtime_errors():
-    class _BrokenBaseUrl(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise RuntimeError("environment base_url strip exploded")
-
-    with pytest.raises(
-        HyperbrowserError, match="Failed to normalize HYPERBROWSER_BASE_URL"
-    ) as exc_info:
-        ClientConfig.resolve_base_url_from_env(_BrokenBaseUrl("https://example.local"))
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-def test_client_config_resolve_base_url_from_env_wraps_string_subclass_strip_results():
+def test_client_config_resolve_base_url_from_env_rejects_string_subclass_inputs():
     class _BrokenBaseUrl(str):
         class _NormalizedBaseUrl(str):
             pass
@@ -357,12 +343,10 @@ def strip(self, chars=None):  # type: ignore[override]
             return self._NormalizedBaseUrl("https://example.local")
 
     with pytest.raises(
-        HyperbrowserError, match="Failed to normalize HYPERBROWSER_BASE_URL"
-    ) as exc_info:
+        HyperbrowserError, match="HYPERBROWSER_BASE_URL must be a string"
+    ):
         ClientConfig.resolve_base_url_from_env(_BrokenBaseUrl("https://example.local"))
 
-    assert isinstance(exc_info.value.original_error, TypeError)
-
 
 def test_client_config_wraps_api_key_strip_runtime_errors():
     class _BrokenApiKey(str):

tests/test_header_utils.py

@@ -45,12 +45,6 @@ def strip(self, chars=None):  # type: ignore[override]
         return self._NormalizedKey("X-Trace-Id")
 
 
-class _BrokenHeadersEnvString(str):
-    def strip(self, chars=None):  # type: ignore[override]
-        _ = chars
-        raise RuntimeError("headers env strip exploded")
-
-
 class _NonStringHeadersEnvStripResult(str):
     def strip(self, chars=None):  # type: ignore[override]
         _ = chars
@@ -168,46 +162,17 @@ def test_parse_headers_env_json_rejects_non_string_input():
         parse_headers_env_json(123)  # type: ignore[arg-type]
 
 
-def test_parse_headers_env_json_wraps_strip_runtime_errors():
-    with pytest.raises(
-        HyperbrowserError, match="Failed to normalize HYPERBROWSER_HEADERS"
-    ) as exc_info:
-        parse_headers_env_json(_BrokenHeadersEnvString('{"X-Trace-Id":"abc123"}'))
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-def test_parse_headers_env_json_preserves_hyperbrowser_strip_errors():
-    class _BrokenHeadersEnvString(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise HyperbrowserError("custom headers strip failure")
-
-    with pytest.raises(
-        HyperbrowserError, match="custom headers strip failure"
-    ) as exc_info:
-        parse_headers_env_json(_BrokenHeadersEnvString('{"X-Trace-Id":"abc123"}'))
-
-    assert exc_info.value.original_error is None
-
-
-def test_parse_headers_env_json_wraps_non_string_strip_results():
+def test_parse_headers_env_json_rejects_string_subclass_input_values():
     with pytest.raises(
-        HyperbrowserError, match="Failed to normalize HYPERBROWSER_HEADERS"
-    ) as exc_info:
+        HyperbrowserError, match="HYPERBROWSER_HEADERS must be a string"
+    ):
         parse_headers_env_json(_NonStringHeadersEnvStripResult('{"X-Trace-Id":"abc123"}'))
 
-    assert isinstance(exc_info.value.original_error, TypeError)
-
-
-def test_parse_headers_env_json_wraps_string_subclass_strip_results():
     with pytest.raises(
-        HyperbrowserError, match="Failed to normalize HYPERBROWSER_HEADERS"
-    ) as exc_info:
+        HyperbrowserError, match="HYPERBROWSER_HEADERS must be a string"
+    ):
         parse_headers_env_json(_StringSubclassHeadersEnvStripResult('{"X-Trace-Id":"abc123"}'))
 
-    assert isinstance(exc_info.value.original_error, TypeError)
-
 
 def test_parse_headers_env_json_rejects_invalid_json():
     with pytest.raises(