Validate client timeout input types

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/async_client.py

@@ -1,3 +1,4 @@
+from numbers import Real
 from typing import Mapping, Optional
 
 from ..exceptions import HyperbrowserError
@@ -27,8 +28,11 @@ def __init__(
         headers: Optional[Mapping[str, str]] = None,
         timeout: Optional[float] = 30,
     ):
-        if timeout is not None and timeout < 0:
-            raise HyperbrowserError("timeout must be non-negative")
+        if timeout is not None:
+            if isinstance(timeout, bool) or not isinstance(timeout, Real):
+                raise HyperbrowserError("timeout must be a number")
+            if timeout < 0:
+                raise HyperbrowserError("timeout must be non-negative")
         super().__init__(AsyncTransport, config, api_key, base_url, headers)
         self.transport.client.timeout = timeout
         self.sessions = SessionManager(self)

hyperbrowser/client/sync.py

@@ -1,3 +1,4 @@
+from numbers import Real
 from typing import Mapping, Optional
 
 from ..exceptions import HyperbrowserError
@@ -27,8 +28,11 @@ def __init__(
         headers: Optional[Mapping[str, str]] = None,
         timeout: Optional[float] = 30,
     ):
-        if timeout is not None and timeout < 0:
-            raise HyperbrowserError("timeout must be non-negative")
+        if timeout is not None:
+            if isinstance(timeout, bool) or not isinstance(timeout, Real):
+                raise HyperbrowserError("timeout must be a number")
+            if timeout < 0:
+                raise HyperbrowserError("timeout must be non-negative")
         super().__init__(SyncTransport, config, api_key, base_url, headers)
         self.transport.client.timeout = timeout
         self.sessions = SessionManager(self)

tests/test_client_timeout.py

@@ -27,3 +27,23 @@ async def run() -> None:
         await client.close()
 
     asyncio.run(run())
+
+
+def test_sync_client_rejects_non_numeric_timeout():
+    with pytest.raises(HyperbrowserError, match="timeout must be a number"):
+        Hyperbrowser(api_key="test-key", timeout="30")  # type: ignore[arg-type]
+
+
+def test_async_client_rejects_non_numeric_timeout():
+    with pytest.raises(HyperbrowserError, match="timeout must be a number"):
+        AsyncHyperbrowser(api_key="test-key", timeout="30")  # type: ignore[arg-type]
+
+
+def test_sync_client_rejects_boolean_timeout():
+    with pytest.raises(HyperbrowserError, match="timeout must be a number"):
+        Hyperbrowser(api_key="test-key", timeout=True)
+
+
+def test_async_client_rejects_boolean_timeout():
+    with pytest.raises(HyperbrowserError, match="timeout must be a number"):
+        AsyncHyperbrowser(api_key="test-key", timeout=False)