Truncate oversized polling exception messages

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/polling.py

@@ -20,10 +20,12 @@
 _FETCH_OPERATION_NAME_PREFIX = "Fetching "
 _FETCH_PREFIX_KEYWORD = "fetching"
 _TRUNCATED_OPERATION_NAME_SUFFIX = "..."
+_TRUNCATED_EXCEPTION_TEXT_SUFFIX = "... (truncated)"
 _CLIENT_ERROR_STATUS_MIN = 400
 _CLIENT_ERROR_STATUS_MAX = 500
 _RETRYABLE_CLIENT_ERROR_STATUS_CODES = {408, 429}
 _MAX_STATUS_CODE_TEXT_LENGTH = 6
+_MAX_EXCEPTION_TEXT_LENGTH = 500
 
 
 class _NonRetryablePollingError(HyperbrowserError):
@@ -36,7 +38,17 @@ def _safe_exception_text(exc: Exception) -> str:
     except Exception:
         return f"<unstringifiable {type(exc).__name__}>"
     if exception_message.strip():
-        return exception_message
+        if len(exception_message) <= _MAX_EXCEPTION_TEXT_LENGTH:
+            return exception_message
+        available_message_length = (
+            _MAX_EXCEPTION_TEXT_LENGTH - len(_TRUNCATED_EXCEPTION_TEXT_SUFFIX)
+        )
+        if available_message_length <= 0:
+            return _TRUNCATED_EXCEPTION_TEXT_SUFFIX
+        return (
+            f"{exception_message[:available_message_length]}"
+            f"{_TRUNCATED_EXCEPTION_TEXT_SUFFIX}"
+        )
     return f"<{type(exc).__name__}>"
 
 

tests/test_polling.py

@@ -6750,3 +6750,39 @@ def test_retry_operation_uses_placeholder_for_blank_error_messages():
             max_attempts=1,
             retry_delay_seconds=0.0,
         )
+
+
+def test_poll_until_terminal_status_truncates_oversized_error_messages():
+    very_long_message = "x" * 2000
+
+    with pytest.raises(
+        HyperbrowserPollingError,
+        match=r"Failed to poll long-error poll after 1 attempts: .+\.\.\. \(truncated\)",
+    ) as exc_info:
+        poll_until_terminal_status(
+            operation_name="long-error poll",
+            get_status=lambda: (_ for _ in ()).throw(RuntimeError(very_long_message)),
+            is_terminal_status=lambda value: value == "completed",
+            poll_interval_seconds=0.0,
+            max_wait_seconds=1.0,
+            max_status_failures=1,
+        )
+
+    assert "... (truncated)" in str(exc_info.value)
+
+
+def test_retry_operation_truncates_oversized_error_messages():
+    very_long_message = "y" * 2000
+
+    with pytest.raises(
+        HyperbrowserError,
+        match=r"long-error retry failed after 1 attempts: .+\.\.\. \(truncated\)",
+    ) as exc_info:
+        retry_operation(
+            operation_name="long-error retry",
+            operation=lambda: (_ for _ in ()).throw(ValueError(very_long_message)),
+            max_attempts=1,
+            retry_delay_seconds=0.0,
+        )
+
+    assert "... (truncated)" in str(exc_info.value)