Require concrete path inputs in URL builder

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/base.py

@@ -146,7 +146,7 @@ def _parse_url_components(
         )
 
     def _build_url(self, path: str) -> str:
-        if not isinstance(path, str):
+        if type(path) is not str:
             raise HyperbrowserError("path must be a string")
         try:
             stripped_path = path.strip()

tests/test_url_building.py

@@ -353,69 +353,14 @@ def test_client_build_url_rejects_empty_or_non_string_paths():
         client.close()
 
 
-def test_client_build_url_wraps_path_strip_runtime_errors():
+def test_client_build_url_rejects_string_subclass_path_inputs():
     client = Hyperbrowser(config=ClientConfig(api_key="test-key"))
     try:
         class _BrokenPath(str):
-            def strip(self, chars=None):  # type: ignore[override]
-                _ = chars
-                raise RuntimeError("path strip exploded")
+            pass
 
-        with pytest.raises(HyperbrowserError, match="Failed to normalize path") as exc_info:
-            client._build_url(_BrokenPath("/session"))
-
-        assert isinstance(exc_info.value.original_error, RuntimeError)
-    finally:
-        client.close()
-
-
-def test_client_build_url_preserves_hyperbrowser_path_strip_errors():
-    client = Hyperbrowser(config=ClientConfig(api_key="test-key"))
-    try:
-        class _BrokenPath(str):
-            def strip(self, chars=None):  # type: ignore[override]
-                _ = chars
-                raise HyperbrowserError("custom path strip failure")
-
-        with pytest.raises(HyperbrowserError, match="custom path strip failure") as exc_info:
-            client._build_url(_BrokenPath("/session"))
-
-        assert exc_info.value.original_error is None
-    finally:
-        client.close()
-
-
-def test_client_build_url_wraps_non_string_path_strip_results():
-    client = Hyperbrowser(config=ClientConfig(api_key="test-key"))
-    try:
-        class _BrokenPath(str):
-            def strip(self, chars=None):  # type: ignore[override]
-                _ = chars
-                return object()
-
-        with pytest.raises(HyperbrowserError, match="Failed to normalize path") as exc_info:
-            client._build_url(_BrokenPath("/session"))
-
-        assert isinstance(exc_info.value.original_error, TypeError)
-    finally:
-        client.close()
-
-
-def test_client_build_url_wraps_string_subclass_path_strip_results():
-    client = Hyperbrowser(config=ClientConfig(api_key="test-key"))
-    try:
-        class _BrokenPath(str):
-            class _NormalizedPath(str):
-                pass
-
-            def strip(self, chars=None):  # type: ignore[override]
-                _ = chars
-                return self._NormalizedPath("/session")
-
-        with pytest.raises(HyperbrowserError, match="Failed to normalize path") as exc_info:
+        with pytest.raises(HyperbrowserError, match="path must be a string"):
             client._build_url(_BrokenPath("/session"))
-
-        assert isinstance(exc_info.value.original_error, TypeError)
     finally:
         client.close()