Harden transport URL fallback normalization for booleans

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

README.md

@@ -187,7 +187,7 @@ Polling timeouts and repeated polling failures are surfaced as:
 
 `HyperbrowserPollingError` also covers stalled pagination (no page-batch progress during result collection).
 Transport-level request failures include HTTP method + URL context in error messages.
-URL-like fallback objects are stringified for transport diagnostics; missing/malformed/sentinel URL inputs (for example `None`, `null`/`undefined`/`nan`, or numeric-like values such as `123`/`1.5`/`1e6`) are normalized to `unknown URL`.
+URL-like fallback objects are stringified for transport diagnostics; missing/malformed/sentinel URL inputs (for example `None`, booleans, `null`/`undefined`/`nan`, or numeric-like values such as `123`/`1.5`/`1e6`) are normalized to `unknown URL`.
 
 ```python
 from hyperbrowser import Hyperbrowser

hyperbrowser/transport/error_utils.py

@@ -39,6 +39,8 @@ def _normalize_request_method(method: Any) -> str:
 def _normalize_request_url(url: Any) -> str:
     if url is None:
         return "unknown URL"
+    if isinstance(url, bool):
+        return "unknown URL"
     raw_url = url
     if not isinstance(raw_url, str):
         try:

tests/test_transport_error_utils.py

@@ -256,6 +256,16 @@ def test_format_request_failure_message_normalizes_numeric_fallback_url_values()
     assert message == "Request GET unknown URL failed"
 
 
+def test_format_request_failure_message_normalizes_boolean_fallback_url_values():
+    message = format_request_failure_message(
+        httpx.RequestError("network down"),
+        fallback_method="GET",
+        fallback_url=True,
+    )
+
+    assert message == "Request GET unknown URL failed"
+
+
 @pytest.mark.parametrize(
     "sentinel_url",
     [
@@ -324,6 +334,15 @@ def test_format_generic_request_failure_message_normalizes_numeric_url_values():
     assert message == "Request GET unknown URL failed"
 
 
+def test_format_generic_request_failure_message_normalizes_boolean_url_values():
+    message = format_generic_request_failure_message(
+        method="GET",
+        url=False,
+    )
+
+    assert message == "Request GET unknown URL failed"
+
+
 @pytest.mark.parametrize(
     "sentinel_url",
     [

tests/test_transport_response_handling.py

@@ -394,6 +394,22 @@ def failing_get(*args, **kwargs):
         transport.close()
 
 
+def test_sync_transport_wraps_unexpected_errors_with_boolean_url_fallback():
+    transport = SyncTransport(api_key="test-key")
+    original_get = transport.client.get
+
+    def failing_get(*args, **kwargs):
+        raise RuntimeError("boom")
+
+    transport.client.get = failing_get  # type: ignore[assignment]
+    try:
+        with pytest.raises(HyperbrowserError, match="Request GET unknown URL failed"):
+            transport.get(True)  # type: ignore[arg-type]
+    finally:
+        transport.client.get = original_get  # type: ignore[assignment]
+        transport.close()
+
+
 def test_sync_transport_wraps_unexpected_errors_with_sentinel_url_fallback():
     transport = SyncTransport(api_key="test-key")
     original_get = transport.client.get
@@ -490,6 +506,27 @@ async def failing_put(*args, **kwargs):
     asyncio.run(run())
 
 
+def test_async_transport_wraps_unexpected_errors_with_boolean_url_fallback():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        original_put = transport.client.put
+
+        async def failing_put(*args, **kwargs):
+            raise RuntimeError("boom")
+
+        transport.client.put = failing_put  # type: ignore[assignment]
+        try:
+            with pytest.raises(
+                HyperbrowserError, match="Request PUT unknown URL failed"
+            ):
+                await transport.put(False)  # type: ignore[arg-type]
+        finally:
+            transport.client.put = original_put  # type: ignore[assignment]
+            await transport.close()
+
+    asyncio.run(run())
+
+
 def test_async_transport_wraps_unexpected_errors_with_sentinel_url_fallback():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")
@@ -600,6 +637,22 @@ def failing_get(*args, **kwargs):
         transport.close()
 
 
+def test_sync_transport_request_error_without_request_uses_unknown_url_for_boolean_input():
+    transport = SyncTransport(api_key="test-key")
+    original_get = transport.client.get
+
+    def failing_get(*args, **kwargs):
+        raise httpx.RequestError("network down")
+
+    transport.client.get = failing_get  # type: ignore[assignment]
+    try:
+        with pytest.raises(HyperbrowserError, match="Request GET unknown URL failed"):
+            transport.get(False)  # type: ignore[arg-type]
+    finally:
+        transport.client.get = original_get  # type: ignore[assignment]
+        transport.close()
+
+
 def test_sync_transport_request_error_without_request_uses_unknown_url_for_sentinel_input():
     transport = SyncTransport(api_key="test-key")
     original_get = transport.client.get
@@ -718,6 +771,27 @@ async def failing_delete(*args, **kwargs):
     asyncio.run(run())
 
 
+def test_async_transport_request_error_without_request_uses_unknown_url_for_boolean_input():
+    async def run() -> None:
+        transport = AsyncTransport(api_key="test-key")
+        original_delete = transport.client.delete
+
+        async def failing_delete(*args, **kwargs):
+            raise httpx.RequestError("network down")
+
+        transport.client.delete = failing_delete  # type: ignore[assignment]
+        try:
+            with pytest.raises(
+                HyperbrowserError, match="Request DELETE unknown URL failed"
+            ):
+                await transport.delete(True)  # type: ignore[arg-type]
+        finally:
+            transport.client.delete = original_delete  # type: ignore[assignment]
+            await transport.close()
+
+    asyncio.run(run())
+
+
 def test_async_transport_request_error_without_request_uses_unknown_url_for_sentinel_input():
     async def run() -> None:
         transport = AsyncTransport(api_key="test-key")