Wrap session recording iteration failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/session_utils.py

@@ -10,8 +10,17 @@ def parse_session_recordings_response_data(response_data: Any) -> List[SessionRe
         raise HyperbrowserError(
             "Expected session recording response to be a list of objects"
         )
+    try:
+        recording_items = list(response_data)
+    except HyperbrowserError:
+        raise
+    except Exception as exc:
+        raise HyperbrowserError(
+            "Failed to iterate session recording response list",
+            original_error=exc,
+        ) from exc
     parsed_recordings: List[SessionRecording] = []
-    for index, recording in enumerate(response_data):
+    for index, recording in enumerate(recording_items):
         if not isinstance(recording, Mapping):
             raise HyperbrowserError(
                 "Expected session recording object at index "

tests/test_session_recording_utils.py

@@ -115,6 +115,32 @@ def test_parse_session_recordings_response_data_wraps_invalid_items():
     assert exc_info.value.original_error is not None
 
 
+def test_parse_session_recordings_response_data_wraps_unreadable_list_iteration():
+    class _BrokenRecordingList(list):
+        def __iter__(self):
+            raise RuntimeError("cannot iterate recordings")
+
+    with pytest.raises(
+        HyperbrowserError, match="Failed to iterate session recording response list"
+    ) as exc_info:
+        parse_session_recordings_response_data(_BrokenRecordingList([{}]))
+
+    assert exc_info.value.original_error is not None
+
+
+def test_parse_session_recordings_response_data_preserves_hyperbrowser_iteration_errors():
+    class _BrokenRecordingList(list):
+        def __iter__(self):
+            raise HyperbrowserError("custom recording iteration failure")
+
+    with pytest.raises(
+        HyperbrowserError, match="custom recording iteration failure"
+    ) as exc_info:
+        parse_session_recordings_response_data(_BrokenRecordingList([{}]))
+
+    assert exc_info.value.original_error is None
+
+
 def test_sync_session_manager_get_recording_uses_recording_parser():
     manager = SyncSessionManager(
         _FakeClient(