Safeguard APIResponse model name resolution

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/transport/base.py

@@ -7,6 +7,19 @@
 T = TypeVar("T")
 
 
+def _safe_model_name(model: object) -> str:
+    try:
+        model_name = getattr(model, "__name__", "response model")
+    except Exception:
+        return "response model"
+    if not isinstance(model_name, str):
+        return "response model"
+    normalized_model_name = model_name.strip()
+    if not normalized_model_name:
+        return "response model"
+    return normalized_model_name
+
+
 class APIResponse(Generic[T]):
     """
     Wrapper for API responses to standardize sync/async handling.
@@ -21,7 +34,7 @@ def from_json(
         cls, json_data: Mapping[str, object], model: Type[T]
     ) -> "APIResponse[T]":
         """Create an APIResponse from JSON data with a specific model."""
-        model_name = getattr(model, "__name__", "response model")
+        model_name = _safe_model_name(model)
         if not isinstance(json_data, MappingABC):
             actual_type_name = type(json_data).__name__
             raise HyperbrowserError(

tests/test_transport_base.py

@@ -44,6 +44,27 @@ def __getitem__(self, key: str) -> object:
         raise KeyError(key)
 
 
+class _BrokenNameMeta(type):
+    def __getattribute__(cls, name: str):
+        if name == "__name__":
+            raise RuntimeError("cannot read model name")
+        return super().__getattribute__(name)
+
+
+class _BrokenNameModel(metaclass=_BrokenNameMeta):
+    def __init__(self, **kwargs):
+        self.name = kwargs["name"]
+        self.retries = kwargs.get("retries", 0)
+
+
+class _BlankNameCallableModel:
+    __name__ = "   "
+
+    def __call__(self, **kwargs):
+        _ = kwargs
+        raise RuntimeError("call failed")
+
+
 def test_api_response_from_json_parses_model_data() -> None:
     response = APIResponse.from_json(
         {"name": "job-1", "retries": 2}, _SampleResponseModel
@@ -93,6 +114,14 @@ def test_api_response_from_json_wraps_non_hyperbrowser_errors() -> None:
     assert exc_info.value.original_error is not None
 
 
+def test_api_response_from_json_parses_model_when_name_lookup_fails() -> None:
+    response = APIResponse.from_json({"name": "job-1"}, _BrokenNameModel)
+
+    assert isinstance(response.data, _BrokenNameModel)
+    assert response.data.name == "job-1"
+    assert response.status_code == 200
+
+
 def test_api_response_from_json_wraps_unreadable_mapping_keys() -> None:
     with pytest.raises(
         HyperbrowserError,
@@ -119,6 +148,17 @@ def test_api_response_from_json_wraps_unreadable_mapping_values() -> None:
     assert exc_info.value.original_error is not None
 
 
+def test_api_response_from_json_uses_default_name_for_blank_model_name() -> None:
+    with pytest.raises(
+        HyperbrowserError,
+        match="Failed to parse response data for response model",
+    ):
+        APIResponse.from_json(
+            {"name": "job-1"},
+            cast("type[_SampleResponseModel]", _BlankNameCallableModel()),
+        )
+
+
 def test_api_response_from_json_preserves_hyperbrowser_errors() -> None:
     with pytest.raises(HyperbrowserError, match="model validation failed") as exc_info:
         APIResponse.from_json({}, _RaisesHyperbrowserModel)