Wrap extension membership inspection failures

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/extension_utils.py

@@ -32,6 +32,8 @@ def _format_key_display(value: object) -> str:
 def _summarize_mapping_keys(mapping: Mapping[object, object]) -> str:
     try:
         mapping_keys = list(mapping.keys())
+    except HyperbrowserError:
+        raise
     except Exception:
         return "[<unavailable keys>]"
     key_names = sorted(_format_key_display(key) for key in mapping_keys)
@@ -50,7 +52,16 @@ def parse_extension_list_response_data(response_data: Any) -> List[ExtensionResp
         raise HyperbrowserError(
             f"Expected mapping response but got {_get_type_name(response_data)}"
         )
-    if "extensions" not in response_data:
+    try:
+        has_extensions_key = "extensions" in response_data
+    except HyperbrowserError:
+        raise
+    except Exception as exc:
+        raise HyperbrowserError(
+            "Failed to inspect response for 'extensions' key",
+            original_error=exc,
+        ) from exc
+    if not has_extensions_key:
         raise HyperbrowserError(
             "Expected 'extensions' key in response but got "
             f"{_summarize_mapping_keys(response_data)} keys"

tests/test_extension_utils.py

@@ -171,6 +171,32 @@ def keys(self):
         parse_extension_list_response_data(_BrokenKeysMapping({"id": "ext_1"}))
 
 
+def test_parse_extension_list_response_data_wraps_unreadable_extensions_membership():
+    class _BrokenContainsMapping(dict):
+        def __contains__(self, key: object) -> bool:
+            _ = key
+            raise RuntimeError("cannot inspect contains")
+
+    with pytest.raises(
+        HyperbrowserError, match="Failed to inspect response for 'extensions' key"
+    ) as exc_info:
+        parse_extension_list_response_data(_BrokenContainsMapping({"id": "ext_1"}))
+
+    assert exc_info.value.original_error is not None
+
+
+def test_parse_extension_list_response_data_preserves_hyperbrowser_contains_errors():
+    class _BrokenContainsMapping(dict):
+        def __contains__(self, key: object) -> bool:
+            _ = key
+            raise HyperbrowserError("custom contains failure")
+
+    with pytest.raises(HyperbrowserError, match="custom contains failure") as exc_info:
+        parse_extension_list_response_data(_BrokenContainsMapping({"id": "ext_1"}))
+
+    assert exc_info.value.original_error is None
+
+
 def test_parse_extension_list_response_data_wraps_unreadable_extensions_value():
     class _BrokenExtensionsLookupMapping(dict):
         def __contains__(self, key: object) -> bool: