Guard file checks against invalid truthy return values

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/file_utils.py

@@ -37,7 +37,7 @@ def ensure_existing_file_path(
     ):
         raise HyperbrowserError("file_path must not contain control characters")
     try:
-        path_exists = os.path.exists(normalized_path)
+        path_exists = bool(os.path.exists(normalized_path))
     except HyperbrowserError:
         raise
     except (OSError, ValueError, TypeError) as exc:
@@ -47,7 +47,7 @@ def ensure_existing_file_path(
     if not path_exists:
         raise HyperbrowserError(missing_file_message)
     try:
-        is_file = os.path.isfile(normalized_path)
+        is_file = bool(os.path.isfile(normalized_path))
     except HyperbrowserError:
         raise
     except (OSError, ValueError, TypeError) as exc:

tests/test_file_utils.py

@@ -175,6 +175,53 @@ def raising_isfile(path: str) -> bool:
     assert exc_info.value.original_error is not None
 
 
+def test_ensure_existing_file_path_wraps_non_boolean_exists_results(monkeypatch):
+    class _BrokenTruthValue:
+        def __bool__(self) -> bool:
+            raise RuntimeError("cannot coerce exists result")
+
+    def invalid_exists(path: str):
+        _ = path
+        return _BrokenTruthValue()
+
+    monkeypatch.setattr(file_utils.os.path, "exists", invalid_exists)
+
+    with pytest.raises(HyperbrowserError, match="file_path is invalid") as exc_info:
+        ensure_existing_file_path(
+            "/tmp/maybe-invalid",
+            missing_file_message="missing",
+            not_file_message="not-file",
+        )
+
+    assert exc_info.value.original_error is not None
+
+
+def test_ensure_existing_file_path_wraps_non_boolean_isfile_results(
+    monkeypatch, tmp_path: Path
+):
+    class _BrokenTruthValue:
+        def __bool__(self) -> bool:
+            raise RuntimeError("cannot coerce isfile result")
+
+    file_path = tmp_path / "target.txt"
+    file_path.write_text("content")
+
+    def invalid_isfile(path: str):
+        _ = path
+        return _BrokenTruthValue()
+
+    monkeypatch.setattr(file_utils.os.path, "isfile", invalid_isfile)
+
+    with pytest.raises(HyperbrowserError, match="file_path is invalid") as exc_info:
+        ensure_existing_file_path(
+            str(file_path),
+            missing_file_message="missing",
+            not_file_message="not-file",
+        )
+
+    assert exc_info.value.original_error is not None
+
+
 def test_ensure_existing_file_path_wraps_fspath_runtime_errors():
     class _BrokenPathLike:
         def __fspath__(self) -> str: