Guard base URL host and credential parsing errors

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/config.py

@@ -108,9 +108,17 @@ def normalize_base_url(base_url: str) -> str:
             or not isinstance(parsed_base_url.fragment, str)
         ):
             raise HyperbrowserError("base_url parser returned invalid URL components")
-        if (
-            parsed_base_url.hostname is not None
-            and not isinstance(parsed_base_url.hostname, str)
+        try:
+            parsed_base_url_hostname = parsed_base_url.hostname
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to parse base_url host",
+                original_error=exc,
+            ) from exc
+        if parsed_base_url_hostname is not None and not isinstance(
+            parsed_base_url_hostname, str
         ):
             raise HyperbrowserError("base_url parser returned invalid URL components")
         if (
@@ -120,15 +128,25 @@ def normalize_base_url(base_url: str) -> str:
             raise HyperbrowserError(
                 "base_url must start with 'https://' or 'http://' and include a host"
             )
-        if parsed_base_url.hostname is None:
+        if parsed_base_url_hostname is None:
             raise HyperbrowserError(
                 "base_url must start with 'https://' or 'http://' and include a host"
             )
         if parsed_base_url.query or parsed_base_url.fragment:
             raise HyperbrowserError(
                 "base_url must not include query parameters or fragments"
             )
-        if parsed_base_url.username is not None or parsed_base_url.password is not None:
+        try:
+            parsed_base_url_username = parsed_base_url.username
+            parsed_base_url_password = parsed_base_url.password
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                "Failed to parse base_url credentials",
+                original_error=exc,
+            ) from exc
+        if parsed_base_url_username is not None or parsed_base_url_password is not None:
             raise HyperbrowserError("base_url must not include user credentials")
         try:
             parsed_base_url.port

tests/test_config.py

@@ -509,6 +509,97 @@ def port(self) -> int:
         ClientConfig.normalize_base_url("https://example.local")
 
 
+def test_client_config_normalize_base_url_wraps_hostname_access_errors(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    class _ParsedURL:
+        scheme = "https"
+        netloc = "example.local"
+        query = ""
+        fragment = ""
+        username = None
+        password = None
+        path = "/api"
+
+        @property
+        def hostname(self):
+            raise RuntimeError("hostname parser exploded")
+
+        @property
+        def port(self) -> int:
+            return 443
+
+    monkeypatch.setattr(config_module, "urlparse", lambda _value: _ParsedURL())
+
+    with pytest.raises(HyperbrowserError, match="Failed to parse base_url host") as exc_info:
+        ClientConfig.normalize_base_url("https://example.local")
+
+    assert exc_info.value.original_error is not None
+
+
+def test_client_config_normalize_base_url_wraps_credential_access_errors(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    class _ParsedURL:
+        scheme = "https"
+        netloc = "example.local"
+        hostname = "example.local"
+        query = ""
+        fragment = ""
+        path = "/api"
+
+        @property
+        def username(self):
+            raise RuntimeError("credential parser exploded")
+
+        @property
+        def password(self):
+            return None
+
+        @property
+        def port(self) -> int:
+            return 443
+
+    monkeypatch.setattr(config_module, "urlparse", lambda _value: _ParsedURL())
+
+    with pytest.raises(
+        HyperbrowserError, match="Failed to parse base_url credentials"
+    ) as exc_info:
+        ClientConfig.normalize_base_url("https://example.local")
+
+    assert exc_info.value.original_error is not None
+
+
+def test_client_config_normalize_base_url_preserves_hyperbrowser_hostname_errors(
+    monkeypatch: pytest.MonkeyPatch,
+):
+    class _ParsedURL:
+        scheme = "https"
+        netloc = "example.local"
+        query = ""
+        fragment = ""
+        username = None
+        password = None
+        path = "/api"
+
+        @property
+        def hostname(self):
+            raise HyperbrowserError("custom hostname parser failure")
+
+        @property
+        def port(self) -> int:
+            return 443
+
+    monkeypatch.setattr(config_module, "urlparse", lambda _value: _ParsedURL())
+
+    with pytest.raises(
+        HyperbrowserError, match="custom hostname parser failure"
+    ) as exc_info:
+        ClientConfig.normalize_base_url("https://example.local")
+
+    assert exc_info.value.original_error is None
+
+
 def test_client_config_normalize_base_url_wraps_path_decode_runtime_errors(
     monkeypatch: pytest.MonkeyPatch,
 ):