Normalize runtime base URL values in URL builder

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/base.py

@@ -87,7 +87,13 @@ def _build_url(self, path: str) -> str:
         normalized_query_suffix = (
             f"?{normalized_parts.query}" if normalized_parts.query else ""
         )
-        parsed_base_url = urlparse(self.config.base_url)
+        if not isinstance(self.config.base_url, str):
+            raise HyperbrowserError("base_url must be a string")
+        normalized_base_url = self.config.base_url.strip().rstrip("/")
+        if not normalized_base_url:
+            raise HyperbrowserError("base_url must not be empty")
+
+        parsed_base_url = urlparse(normalized_base_url)
         if (
             parsed_base_url.scheme not in {"https", "http"}
             or not parsed_base_url.netloc
@@ -104,15 +110,15 @@ def _build_url(self, path: str) -> str:
         if normalized_path_only == "/api" or normalized_path_only.startswith("/api/"):
             if base_has_api_suffix:
                 deduped_path = normalized_path_only[len("/api") :]
-                return f"{self.config.base_url}{deduped_path}{normalized_query_suffix}"
+                return f"{normalized_base_url}{deduped_path}{normalized_query_suffix}"
             return (
-                f"{self.config.base_url}{normalized_path_only}{normalized_query_suffix}"
+                f"{normalized_base_url}{normalized_path_only}{normalized_query_suffix}"
             )
 
         if base_has_api_suffix:
             return (
-                f"{self.config.base_url}{normalized_path_only}{normalized_query_suffix}"
+                f"{normalized_base_url}{normalized_path_only}{normalized_query_suffix}"
             )
         return (
-            f"{self.config.base_url}/api{normalized_path_only}{normalized_query_suffix}"
+            f"{normalized_base_url}/api{normalized_path_only}{normalized_query_suffix}"
         )

tests/test_url_building.py

@@ -97,6 +97,14 @@ def test_client_build_url_rejects_runtime_invalid_base_url_changes():
             HyperbrowserError, match="must not include query parameters"
         ):
             client._build_url("/session")
+
+        client.config.base_url = "   "
+        with pytest.raises(HyperbrowserError, match="base_url must not be empty"):
+            client._build_url("/session")
+
+        client.config.base_url = 123  # type: ignore[assignment]
+        with pytest.raises(HyperbrowserError, match="base_url must be a string"):
+            client._build_url("/session")
     finally:
         client.close()
 
@@ -143,3 +151,15 @@ def test_client_build_url_allows_query_values_containing_absolute_urls():
         )
     finally:
         client.close()
+
+
+def test_client_build_url_normalizes_runtime_trailing_slashes():
+    client = Hyperbrowser(config=ClientConfig(api_key="test-key"))
+    try:
+        client.config.base_url = "https://example.local/"
+        assert client._build_url("/session") == "https://example.local/api/session"
+
+        client.config.base_url = "https://example.local/api/"
+        assert client._build_url("/session") == "https://example.local/api/session"
+    finally:
+        client.close()