The DFAClassBuilder has several different ways of compiling a DFA to a Java class. The choice of which optimizations to apply is extremely important for performance, and can be easily modified by changes that don't break any functional tests.
We currently avoid regressions using the SnapshotTests, and the benchmarks. These are reasonably effective, but the benchmarks are too slow for the edit-compile-test cycle, and creating dozens of snapshot tests seems likely to become cumbersome (they produce binary files included in the repository, and the output when they fail is JVM bytecode diffs).
An alternate approach would be to allow tests to access the FindMethodSpec and CompilationPolicy from the DFAClassBuilder and make assertions about it.
The DFAClassBuilder has several different ways of compiling a DFA to a Java class. The choice of which optimizations to apply is extremely important for performance, and can be easily modified by changes that don't break any functional tests.
We currently avoid regressions using the SnapshotTests, and the benchmarks. These are reasonably effective, but the benchmarks are too slow for the edit-compile-test cycle, and creating dozens of snapshot tests seems likely to become cumbersome (they produce binary files included in the repository, and the output when they fail is JVM bytecode diffs).
An alternate approach would be to allow tests to access the
FindMethodSpecandCompilationPolicyfrom theDFAClassBuilderand make assertions about it.