diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index dca91276..bd876e2f 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -13,18 +13,6 @@ jobs: uses: actions/setup-java@v1 with: java-version: 20 - - name: Cache Maven packages - uses: actions/cache@v1 - with: - path: ~/.m2 - key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} - restore-keys: ${{ runner.os }}-m2 - - name: Cache SonarCloud packages - uses: actions/cache@v1 - with: - path: ~/.sonar/cache - key: ${{ runner.os }}-sonar - restore-keys: ${{ runner.os }}-sonar - name: Build and analyze run: mvn -B verify -DskipTests=true -Dgpg.skip -Dmaven.javadoc.skip=true org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Pcoverage env: diff --git a/src/main/java/com/ibanity/apis/client/products/ponto_connect/models/OnboardingDetails.java b/src/main/java/com/ibanity/apis/client/products/ponto_connect/models/OnboardingDetails.java index 66e83e3e..efe0c538 100644 --- a/src/main/java/com/ibanity/apis/client/products/ponto_connect/models/OnboardingDetails.java +++ b/src/main/java/com/ibanity/apis/client/products/ponto_connect/models/OnboardingDetails.java @@ -35,4 +35,5 @@ public class OnboardingDetails implements IbanityModel { private String preferredOtpMethod; private UUID requestedOrganisationId; private String organizationType; + private Boolean skipFinancialInstitutionSelection; } diff --git a/src/main/java/com/ibanity/apis/client/products/ponto_connect/models/create/OnboardingDetailsCreateQuery.java b/src/main/java/com/ibanity/apis/client/products/ponto_connect/models/create/OnboardingDetailsCreateQuery.java index 2d4e4178..04d69f90 100644 --- a/src/main/java/com/ibanity/apis/client/products/ponto_connect/models/create/OnboardingDetailsCreateQuery.java +++ b/src/main/java/com/ibanity/apis/client/products/ponto_connect/models/create/OnboardingDetailsCreateQuery.java @@ -38,4 +38,5 @@ public class OnboardingDetailsCreateQuery { private String preferredOtpMethod; private UUID requestedOrganisationId; private String organizationType; + private Boolean skipFinancialInstitutionSelection; } diff --git a/src/main/java/com/ibanity/apis/client/products/ponto_connect/services/impl/OnboardingDetailsServiceImpl.java b/src/main/java/com/ibanity/apis/client/products/ponto_connect/services/impl/OnboardingDetailsServiceImpl.java index a7c5588f..ffa6e275 100644 --- a/src/main/java/com/ibanity/apis/client/products/ponto_connect/services/impl/OnboardingDetailsServiceImpl.java +++ b/src/main/java/com/ibanity/apis/client/products/ponto_connect/services/impl/OnboardingDetailsServiceImpl.java @@ -52,6 +52,7 @@ private OnboardingDetails toRequest(OnboardingDetailsCreateQuery onboardingDetai .preferredOtpMethod(onboardingDetailsCreateQuery.getPreferredOtpMethod()) .requestedOrganisationId(onboardingDetailsCreateQuery.getRequestedOrganisationId()) .organizationType(onboardingDetailsCreateQuery.getOrganizationType()) + .skipFinancialInstitutionSelection(onboardingDetailsCreateQuery.getSkipFinancialInstitutionSelection()) .build(); } diff --git a/src/test/java/com/ibanity/apis/client/products/ponto_connect/services/impl/OnboardingDetailsServiceImplTest.java b/src/test/java/com/ibanity/apis/client/products/ponto_connect/services/impl/OnboardingDetailsServiceImplTest.java index 0e671eb2..c50ab980 100644 --- a/src/test/java/com/ibanity/apis/client/products/ponto_connect/services/impl/OnboardingDetailsServiceImplTest.java +++ b/src/test/java/com/ibanity/apis/client/products/ponto_connect/services/impl/OnboardingDetailsServiceImplTest.java @@ -66,6 +66,7 @@ void create() throws URISyntaxException, IOException { .preferredOtpMethod("sms") .requestedOrganisationId(UUID.fromString("9ca9b992-f415-40d3-9624-dc459619b675")) .organizationType("business") + .skipFinancialInstitutionSelection(false) .build(); when(ibanityHttpClient.post(eq(new URI(ONBOARDING_DETAILS_ENDPOINT)), any(),eq(emptyMap()), eq(ACCESS_TOKEN))) @@ -95,6 +96,7 @@ private OnboardingDetails createOnboardingDetails() { .preferredOtpMethod("sms") .requestedOrganisationId(UUID.fromString("9ca9b992-f415-40d3-9624-dc459619b675")) .organizationType("business") + .skipFinancialInstitutionSelection(false) .build(); } } diff --git a/src/test/resources/json/ponto-connect/create_onboarding_details.json b/src/test/resources/json/ponto-connect/create_onboarding_details.json index 6e05cc4a..cf8c74d3 100644 --- a/src/test/resources/json/ponto-connect/create_onboarding_details.json +++ b/src/test/resources/json/ponto-connect/create_onboarding_details.json @@ -19,7 +19,8 @@ "partnerReference": "partner-reference", "automaticSubmissionOnCompletedForms": true, "preferredOtpMethod": "sms", - "requestedOrganisationId": "9ca9b992-f415-40d3-9624-dc459619b675" + "requestedOrganisationId": "9ca9b992-f415-40d3-9624-dc459619b675", + "skipFinancialInstitutionSelection": false } } }