From 5b008f8e7fd2ec51ce6958734ff7ed479cf2960e Mon Sep 17 00:00:00 2001 From: Sztig Date: Mon, 26 Jan 2026 15:45:48 +0100 Subject: [PATCH 1/2] added isset check on simplexml_load_string --- .../Legacy/Content/FieldValue/Converter/SelectionConverter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php b/src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php index f2f14815f1..4d79383a7f 100644 --- a/src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php +++ b/src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php @@ -119,7 +119,7 @@ public function toFieldDefinition(StorageFieldDefinition $storageDef, FieldDefin } foreach ($storageDef->multilingualData as $languageCode => $mlData) { - $xml = simplexml_load_string($mlData->dataText); + $xml = isset($mlData->dataText) ? simplexml_load_string($mlData->dataText) : false; if ($xml !== false) { foreach ($xml->options->option as $option) { $multiLingualOptions[$languageCode][(int)$option['id']] = (string)$option['name']; From 6e1e5813610b68a3a3470e0f8327272704bd1c65 Mon Sep 17 00:00:00 2001 From: Sztig Date: Mon, 26 Jan 2026 16:14:42 +0100 Subject: [PATCH 2/2] phpstan fix --- .../Legacy/Content/FieldValue/Converter/SelectionConverter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php b/src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php index 4d79383a7f..2341bfda28 100644 --- a/src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php +++ b/src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php @@ -119,7 +119,7 @@ public function toFieldDefinition(StorageFieldDefinition $storageDef, FieldDefin } foreach ($storageDef->multilingualData as $languageCode => $mlData) { - $xml = isset($mlData->dataText) ? simplexml_load_string($mlData->dataText) : false; + $xml = $mlData->dataText ? simplexml_load_string($mlData->dataText) : false; if ($xml !== false) { foreach ($xml->options->option as $option) { $multiLingualOptions[$languageCode][(int)$option['id']] = (string)$option['name'];