From 6bb646c2cb1d2654c5aca7ecdd1e4667965442ee Mon Sep 17 00:00:00 2001 From: Jae Gyeoung Yeom <109026317+Unchain68@users.noreply.github.com> Date: Sun, 19 Feb 2023 20:59:57 +0900 Subject: [PATCH 1/2] Update bitify.circom --- circuits/bitify.circom | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/circuits/bitify.circom b/circuits/bitify.circom index bfdd4e82..5e49734f 100644 --- a/circuits/bitify.circom +++ b/circuits/bitify.circom @@ -84,23 +84,21 @@ template Bits2Num_strict() { template Num2BitsNeg(n) { signal input in; signal output out[n]; - var lc1=0; + var lc1 = 0; component isZero; isZero = IsZero(); - var neg = n == 0 ? 0 : 2**n - in; + var neg = in < 0 ? 2**n + in : in; - for (var i = 0; i> i) & 1; - out[i] * (out[i] -1 ) === 0; lc1 += out[i] * 2**i; } in ==> isZero.in; - - - lc1 + isZero.out * 2**n === 2**n - in; + lc1 + isZero.out * 2**n === (in < 0 ? 2**n + in : in); } + From 3c3cd872f5adf672a906c1a7916da9afd5eea801 Mon Sep 17 00:00:00 2001 From: Jae Gyeoung Yeom <109026317+Unchain68@users.noreply.github.com> Date: Sun, 19 Feb 2023 21:01:53 +0900 Subject: [PATCH 2/2] Update bitify.circom --- circuits/bitify.circom | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/circuits/bitify.circom b/circuits/bitify.circom index 5e49734f..c19f8324 100644 --- a/circuits/bitify.circom +++ b/circuits/bitify.circom @@ -84,7 +84,7 @@ template Bits2Num_strict() { template Num2BitsNeg(n) { signal input in; signal output out[n]; - var lc1 = 0; + var lc1=0; component isZero; @@ -92,7 +92,7 @@ template Num2BitsNeg(n) { var neg = in < 0 ? 2**n + in : in; - for (var i = 0; i < n; i++) { + for (var i = 0; i> i) & 1; lc1 += out[i] * 2**i; }