chore: apply fmt-maven-plugin

igorbernstein2 · igorbernstein2 · commit be630acd2070 · 2026-06-29T16:31:02.000Z
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/AuthorizedViewAsync.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/AuthorizedViewAsync.java
@@ -25,8 +25,8 @@
 import com.google.cloud.bigtable.data.v2.internal.channels.ChannelPool;
 import com.google.cloud.bigtable.data.v2.internal.csm.Metrics;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
-import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
 import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
+import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
 import com.google.cloud.bigtable.data.v2.internal.session.VRpcDescriptor;
 import com.google.cloud.bigtable.data.v2.internal.util.ClientConfigurationManager;
 import io.grpc.CallOptions;
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/Client.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/Client.java
@@ -33,9 +33,9 @@
 import com.google.cloud.bigtable.data.v2.internal.csm.MetricsImpl;
 import com.google.cloud.bigtable.data.v2.internal.csm.NoopMetrics;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
+import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.NettyWheelTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
-import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.util.ClientConfigurationManager;
 import io.grpc.CallOptions;
 import io.opencensus.stats.Stats;
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/MaterializedViewAsync.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/MaterializedViewAsync.java
@@ -22,8 +22,8 @@
 import com.google.cloud.bigtable.data.v2.internal.channels.ChannelPool;
 import com.google.cloud.bigtable.data.v2.internal.csm.Metrics;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
-import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
 import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
+import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
 import com.google.cloud.bigtable.data.v2.internal.session.VRpcDescriptor;
 import com.google.cloud.bigtable.data.v2.internal.util.ClientConfigurationManager;
 import io.grpc.CallOptions;
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/TableAsync.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/TableAsync.java
@@ -26,8 +26,8 @@
 import com.google.cloud.bigtable.data.v2.internal.channels.ChannelPool;
 import com.google.cloud.bigtable.data.v2.internal.csm.Metrics;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
-import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
 import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
+import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
 import com.google.cloud.bigtable.data.v2.internal.session.VRpcDescriptor;
 import com.google.cloud.bigtable.data.v2.internal.util.ClientConfigurationManager;
 import io.grpc.CallOptions;
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/TableBase.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/api/TableBase.java
@@ -25,12 +25,12 @@
 import com.google.cloud.bigtable.data.v2.internal.csm.Metrics;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
 import com.google.cloud.bigtable.data.v2.internal.csm.tracers.VRpcTracer;
-import com.google.cloud.bigtable.data.v2.internal.middleware.VOperationImpl;
 import com.google.cloud.bigtable.data.v2.internal.middleware.RetryingVRpc;
+import com.google.cloud.bigtable.data.v2.internal.middleware.VOperationImpl;
 import com.google.cloud.bigtable.data.v2.internal.middleware.VRpc.VRpcListener;
+import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionPoolImpl;
-import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.VRpcDescriptor;
 import com.google.cloud.bigtable.data.v2.internal.util.ClientConfigurationManager;
 import com.google.common.annotations.VisibleForTesting;
@@ -76,8 +76,7 @@ static <ReqT extends Message> TableBase createAndStart(
 
     sessionPool.start(openReq, new Metadata());
 
-    return new TableBase(
-        sessionPool, readRowDescriptor, mutateRowDescriptor, metrics, timer);
+    return new TableBase(sessionPool, readRowDescriptor, mutateRowDescriptor, metrics, timer);
   }
 
   @VisibleForTesting
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/middleware/OpExecutor.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/middleware/OpExecutor.java
@@ -24,8 +24,8 @@
  * SynchronizationContext#throwIfNotInThisSynchronizationContext}).
  *
  * <p>Backing executor evolves over the refactor — for now it is the per-call {@link
- * io.grpc.SynchronizationContext} that {@link VOperationImpl} constructs. Later commits swap it
- * for a {@code SerializingExecutor} over the user-callback pool, and eventually a tailored inline
+ * io.grpc.SynchronizationContext} that {@link VOperationImpl} constructs. Later commits swap it for
+ * a {@code SerializingExecutor} over the user-callback pool, and eventually a tailored inline
  * queue.
  */
 public final class OpExecutor implements Executor {
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/middleware/RetryingVRpc.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/middleware/RetryingVRpc.java
@@ -276,14 +276,15 @@ public void onStart() {
         future =
             timer.newTimeout(
                 () ->
-                    context.getExecutor().execute(
-                        () ->
-                            grpcContext.wrap(
-                                    () ->
-                                        otelContext
-                                            .wrap(() -> onStateChange(new Idle()))
-                                            .run())
-                                .run()),
+                    context
+                        .getExecutor()
+                        .execute(
+                            () ->
+                                grpcContext
+                                    .wrap(
+                                        () ->
+                                            otelContext.wrap(() -> onStateChange(new Idle())).run())
+                                    .run()),
                 Durations.toMillis(retryDelay),
                 TimeUnit.MILLISECONDS);
       } catch (RejectedExecutionException e) {
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/middleware/VRpc.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/middleware/VRpc.java
@@ -110,8 +110,7 @@ abstract class VRpcCallContext {
      */
     public static VRpcCallContext create(
         Deadline deadline, boolean isIdempotent, VRpcTracer tracer) {
-      return create(
-          deadline, isIdempotent, tracer, new OpExecutor(MoreExecutors.directExecutor()));
+      return create(deadline, isIdempotent, tracer, new OpExecutor(MoreExecutors.directExecutor()));
     }
 
     public static VRpcCallContext create(
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/NettyWheelTimer.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/NettyWheelTimer.java
@@ -49,8 +49,7 @@ public NettyWheelTimer(String name, Executor dispatcher) {
 
   @Override
   public Timeout newTimeout(Runnable task, long delay, TimeUnit unit) {
-    return new TimeoutHandle(
-        delegate.newTimeout(ignored -> dispatcher.execute(task), delay, unit));
+    return new TimeoutHandle(delegate.newTimeout(ignored -> dispatcher.execute(task), delay, unit));
   }
 
   @Override
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/SessionImpl.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/SessionImpl.java
@@ -411,9 +411,7 @@ public void cancelRpc(long rpcId, @Nullable String message, @Nullable Throwable
   private void scheduleHeartbeatCheck() {
     heartbeatTimeout =
         timer.newTimeout(
-            this::checkHeartbeat,
-            HEARTBEAT_CHECK_INTERVAL.toMillis(),
-            TimeUnit.MILLISECONDS);
+            this::checkHeartbeat, HEARTBEAT_CHECK_INTERVAL.toMillis(), TimeUnit.MILLISECONDS);
   }
 
   @GuardedBy("lock")
diff --git a/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/SessionPoolImpl.java b/java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/SessionPoolImpl.java
@@ -673,8 +673,7 @@ public void start(ReqT req, VRpcCallContext ctx, VRpcListener<RespT> listener) {
         if (SessionPoolImpl.this.poolState != PoolState.STARTED) {
           VRpcResult result =
               VRpcResult.createUncommitedError(
-                  Status.UNAVAILABLE.withCause(
-                      new IllegalStateException("SessionPool is closed")));
+                  Status.UNAVAILABLE.withCause(new IllegalStateException("SessionPool is closed")));
           ctx.getExecutor().execute(() -> listener.onClose(result));
           return;
         }
@@ -771,8 +770,7 @@ private BigtableTimer.Timeout monitorDeadline(Deadline deadline) {
       return timer.newTimeout(
           () ->
               cancel(
-                  Status.DEADLINE_EXCEEDED.withDescription(
-                      "Deadline exceeded waiting for session"),
+                  Status.DEADLINE_EXCEEDED.withDescription("Deadline exceeded waiting for session"),
                   true),
           deadline.timeRemaining(TimeUnit.NANOSECONDS),
           TimeUnit.NANOSECONDS);
diff --git a/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/api/TableBaseTest.java b/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/api/TableBaseTest.java
@@ -27,9 +27,9 @@
 import com.google.cloud.bigtable.data.v2.internal.csm.NoopMetrics;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
 import com.google.cloud.bigtable.data.v2.internal.middleware.VRpc;
+import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionPool;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionPoolInfo;
-import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.VRpcDescriptor;
 import com.google.protobuf.Message;
 import io.grpc.Deadline;
diff --git a/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/VRpcTracerTest.java b/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/VRpcTracerTest.java
@@ -44,11 +44,11 @@
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.MethodInfo;
 import com.google.cloud.bigtable.data.v2.internal.middleware.RetryingVRpc;
 import com.google.cloud.bigtable.data.v2.internal.middleware.VRpc;
+import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.FakeDescriptor;
 import com.google.cloud.bigtable.data.v2.internal.session.NettyWheelTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.Session;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionFactory;
-import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionImpl;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionPoolInfo;
 import com.google.cloud.bigtable.data.v2.internal.session.fake.FakeServiceBuilder;
@@ -118,7 +118,9 @@ public class VRpcTracerTest {
   @BeforeEach
   void setUp() throws IOException {
     executor = Executors.newScheduledThreadPool(4);
-    timer = new NettyWheelTimer("vrpc-tracer-test", com.google.common.util.concurrent.MoreExecutors.directExecutor());
+    timer =
+        new NettyWheelTimer(
+            "vrpc-tracer-test", com.google.common.util.concurrent.MoreExecutors.directExecutor());
     server =
         FakeServiceBuilder.create(new FakeSessionService(executor))
             .intercept(new PeerInfoInterceptor())
diff --git a/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/middleware/RetryingVRpcTest.java b/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/middleware/RetryingVRpcTest.java
@@ -37,12 +37,12 @@
 import com.google.cloud.bigtable.data.v2.internal.csm.NoopMetrics;
 import com.google.cloud.bigtable.data.v2.internal.csm.attributes.ClientInfo;
 import com.google.cloud.bigtable.data.v2.internal.csm.tracers.VRpcTracer;
+import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.FakeDescriptor;
 import com.google.cloud.bigtable.data.v2.internal.session.NettyWheelTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionFactory;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionImpl;
 import com.google.cloud.bigtable.data.v2.internal.session.SessionPoolInfo;
-import com.google.cloud.bigtable.data.v2.internal.session.BigtableTimer;
 import com.google.cloud.bigtable.data.v2.internal.session.fake.FakeServiceBuilder;
 import com.google.cloud.bigtable.data.v2.internal.session.fake.FakeSessionListener;
 import com.google.cloud.bigtable.data.v2.internal.session.fake.FakeSessionService;
@@ -91,7 +91,9 @@ public class RetryingVRpcTest {
   @BeforeEach
   void setUp() throws IOException {
     executor = Executors.newScheduledThreadPool(4);
-    timer = new NettyWheelTimer("retrying-vrpc-test", com.google.common.util.concurrent.MoreExecutors.directExecutor());
+    timer =
+        new NettyWheelTimer(
+            "retrying-vrpc-test", com.google.common.util.concurrent.MoreExecutors.directExecutor());
     server =
         FakeServiceBuilder.create(new FakeSessionService(executor))
             .intercept(new PeerInfoInterceptor())
diff --git a/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/session/SessionImplTest.java b/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/session/SessionImplTest.java
@@ -100,7 +100,9 @@ public class SessionImplTest {
   @BeforeEach
   void setUp() throws IOException {
     executor = Executors.newScheduledThreadPool(4);
-    timer = new NettyWheelTimer("session-impl-test", com.google.common.util.concurrent.MoreExecutors.directExecutor());
+    timer =
+        new NettyWheelTimer(
+            "session-impl-test", com.google.common.util.concurrent.MoreExecutors.directExecutor());
     server =
         FakeServiceBuilder.create(new FakeSessionService(executor))
             .intercept(new PeerInfoInterceptor())
diff --git a/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/session/SessionPoolImplTest.java b/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/internal/session/SessionPoolImplTest.java
@@ -19,10 +19,8 @@
 import static com.google.common.truth.Truth.assertThat;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyLong;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.ArgumentMatchers.longThat;
-import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.doNothing;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
@@ -55,7 +53,6 @@
 import com.google.cloud.bigtable.data.v2.internal.session.fake.PeerInfoInterceptor;
 import com.google.cloud.bigtable.data.v2.internal.util.ClientConfigurationManager;
 import com.google.common.base.Suppliers;
-import com.google.common.collect.Range;
 import com.google.common.truth.Correspondence;
 import com.google.protobuf.ByteString;
 import com.google.protobuf.util.Durations;
@@ -129,7 +126,9 @@ public class SessionPoolImplTest {
   @BeforeEach
   void setUp() throws IOException {
     executor = Executors.newScheduledThreadPool(4);
-    testTimer = new NettyWheelTimer("test-timer", com.google.common.util.concurrent.MoreExecutors.directExecutor());
+    testTimer =
+        new NettyWheelTimer(
+            "test-timer", com.google.common.util.concurrent.MoreExecutors.directExecutor());
     fakeService = new FakeSessionService(executor);
     headerInterceptor = new HeaderInterceptor();
     server =
@@ -163,7 +162,7 @@ void setUp() throws IOException {
             CallOptions.DEFAULT,
             FakeDescriptor.FAKE_SESSION,
             "fake-pool",
-              testTimer);
+            testTimer);
   }
 
   @AfterEach
@@ -400,9 +399,7 @@ public void test() throws Exception {
       int waitForReadyMs = 1000;
       verify(mockTimer, Mockito.timeout(waitForReadyMs))
           .newTimeout(
-              runnableCaptor.capture(),
-              longThat(isRetrySchedule::test),
-              eq(TimeUnit.MILLISECONDS));
+              runnableCaptor.capture(), longThat(isRetrySchedule::test), eq(TimeUnit.MILLISECONDS));
 
       // we should have received some open requests
       int requestsBefore = fakeService.getOpenRequestCount().get();
@@ -427,9 +424,7 @@ public void test() throws Exception {
       // The retry task will try to open new sessions. This will fail and schedule another retry.
       verify(mockTimer, Mockito.timeout(5000).times(2))
           .newTimeout(
-              any(Runnable.class),
-              longThat(isRetrySchedule::test),
-              eq(TimeUnit.MILLISECONDS));
+              any(Runnable.class), longThat(isRetrySchedule::test), eq(TimeUnit.MILLISECONDS));
 
       // the retry will exhaust the budget again. we should see double the request compared to
       // before

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,7 @@ abstract class VRpcCallContext {`
`110`	`110`	`*/`
`111`	`111`	`public static VRpcCallContext create(`
`112`	`112`	`Deadline deadline, boolean isIdempotent, VRpcTracer tracer) {`
`113`		`- return create(`
`114`		`- deadline, isIdempotent, tracer, new OpExecutor(MoreExecutors.directExecutor()));`
	`113`	`+ return create(deadline, isIdempotent, tracer, new OpExecutor(MoreExecutors.directExecutor()));`
`115`	`114`	`}`
`116`	`115`
`117`	`116`	`public static VRpcCallContext create(`
Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,7 @@ public NettyWheelTimer(String name, Executor dispatcher) {`
`49`	`49`
`50`	`50`	`@Override`
`51`	`51`	`public Timeout newTimeout(Runnable task, long delay, TimeUnit unit) {`
`52`		`- return new TimeoutHandle(`
`53`		`- delegate.newTimeout(ignored -> dispatcher.execute(task), delay, unit));`
	`52`	`+ return new TimeoutHandle(delegate.newTimeout(ignored -> dispatcher.execute(task), delay, unit));`
`54`	`53`	`}`
`55`	`54`
`56`	`55`	`@Override`