nosse.js#3
Conversation
|
@CosmicJesterX is attempting to deploy a commit to the Instatus Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow intended to run Node.js CI for this repository.
Changes:
- Introduces a new
Node.js CIworkflow triggered on pushes and PRs tomain - Runs a Node version matrix (18.x, 20.x, 22.x) with dependency caching
- Executes install/build/test commands in the CI job
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'npm' | ||
| - run: npm ci | ||
| - run: npm run build --if-present | ||
| - run: npm test |
There was a problem hiding this comment.
The workflow runs npm ci/npm run build/npm test from the repository root, but this repo doesn’t have a root-level package.json (the Node project lives under leaderboard-web-server/). As written, these steps will fail. Consider setting defaults.run.working-directory: leaderboard-web-server for the job, or adding working-directory: leaderboard-web-server to each run step (and ensure checkout still happens at repo root).
| cache: 'npm' | ||
| - run: npm ci | ||
| - run: npm run build --if-present | ||
| - run: npm test |
There was a problem hiding this comment.
npm ci requires a package-lock.json in the working directory, but the Node project currently has a yarn.lock (and no package-lock.json). This will cause CI to error. Either switch the workflow to Yarn (e.g., enable corepack and run yarn install --frozen-lockfile / yarn build), or commit a lockfile compatible with npm ci and keep dependency installs consistent.
| cache: 'npm' | |
| - run: npm ci | |
| - run: npm run build --if-present | |
| - run: npm test | |
| cache: 'yarn' | |
| - run: corepack enable | |
| - run: yarn install --frozen-lockfile | |
| - run: yarn run --if-present build | |
| - run: yarn test |
| cache: 'npm' | ||
| - run: npm ci | ||
| - run: npm run build --if-present | ||
| - run: npm test |
There was a problem hiding this comment.
The workflow runs npm test, but the Node project’s package.json does not define a test script, so this step will fail. Either add a test script (and corresponding tests) or replace this step with an existing check (e.g., npm run build or npm run lint if available).
| - run: npm test | |
| - run: npm test --if-present |
No description provided.