-
Notifications
You must be signed in to change notification settings - Fork 831
[SYCL] Enable libm for spirv64 in SYCL #22042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jinge90
wants to merge
56
commits into
intel:sycl
Choose a base branch
from
jinge90:enable_libc_spirv64
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
2d50750
remove dummy bin
jinge90 9c76946
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 fe628a9
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 7a7e62b
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 4de8fa5
merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 e52bb98
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 4b63322
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 544d912
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 2ad6143
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 cf391d9
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 e0f2a15
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 aa7a97c
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 9244680
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 b4b5793
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 50f8f75
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 ebc7166
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 159748c
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 17362e0
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 9e38387
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 dd1e30b
Merge remote-tracking branch 'origin/sycl' into sycl
jinge90 01fa557
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 78adbd8
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 c681812
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 0726c0d
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 f96405d
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 d1f74f4
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 eac7780
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 ff388a2
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 fc841dd
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 615606d
Merge remote-tracking branch 'upstream/sycl' into sycl
jinge90 508a311
[SYCL] Enable LLVM libc for SPIRV64 in SYCL
jinge90 fb7eec6
build spirv64 libc with sycl toolchain
jinge90 0145013
build all libm functions for spirv
jinge90 1084d29
build libc ok
jinge90 6885c28
Add libm.bc in old driver mode
jinge90 8c60243
remove log1p
jinge90 838c4ce
Merge remote-tracking branch 'upstream/sycl' into enable_libc_spirv64
jinge90 4904c74
disable fmodf in libm
jinge90 5935b32
make windows to build
jinge90 8052634
fix clang format
jinge90 67df1df
guard win specific code
jinge90 829bfbf
fix kernel compiler
jinge90 d078d4e
fix clang-format
jinge90 268a9a9
fix kernel compiler tests
jinge90 35ce1c1
fix clang driver lit
jinge90 e62e4db
fix sycl-jit
jinge90 0e36c4c
fix KernelCompiler failure
jinge90 88a030b
update license header #1
jinge90 ecffb94
disable generic impl using double for fp32
jinge90 209637d
update license header
jinge90 73b71cb
Merge remote-tracking branch 'upstream/sycl' into enable_libc_spirv64
jinge90 8da07b5
sync with latest code
jinge90 65641be
Fix windows driver lit tests
jinge90 53126ef
Bypass a known IGC issue
jinge90 b9c8802
remove typo
jinge90 80eb66d
remove typo for sycl-time-trace test
jinge90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |
| /// In this case, where no specific sycl targets are passed, the sycl | ||
| /// targets are spir64 and the host target (e.g. x86_64). We expect two | ||
| /// occurrences of the macro definition, one for host and one for device. | ||
| // RUN: %clang -fsycl --no-offload-new-driver -### %s 2>&1 \ | ||
| // RUN: %clang -fsycl --no-offload-new-driver --no-offloadlib -### %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=CHECK-ENABLED %s | ||
| // RUN: %clang -fsycl --offload-new-driver --sysroot=%S/Inputs/SYCL -### %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=CHECK-ENABLED %s | ||
|
|
@@ -18,7 +18,7 @@ | |
| /// In this case the sycl targets are spir64, spir64_gen and the host | ||
| /// target (e.g. x86_64). We expect three occurrences of the macro | ||
| /// definition, one for host and one for each of the two devices. | ||
| // RUN: %clang -fsycl --no-offload-new-driver -fsycl-targets=spir64,spir64_gen -### %s 2>&1 \ | ||
| // RUN: %clang -fsycl --no-offload-new-driver --no-offloadlib -fsycl-targets=spir64,spir64_gen -### %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=CHECK-SYCL-TARGETS %s | ||
| // RUN: %clang -fsycl --offload-new-driver --sysroot=%S/Inputs/SYCL -fsycl-targets=spir64,spir64_gen -### %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=CHECK-SYCL-TARGETS %s | ||
|
|
@@ -35,11 +35,11 @@ | |
|
|
||
| /// Check device traits macros are defined if sycl is enabled: | ||
| /// Verify that when compiling for multiple targets and maySupportOtherAspects | ||
| /// is false for all of the targets, the driver will never add the | ||
| /// is false for all of the targets, the driver --no-offloadlib will never add the | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please, remove similar instances from all comments. There are few other places with similar problem. It looks like a side-effect of find-and-replace for "driver" -> "driver --no-offload-lib". I would revert this change and use "--offload-new-driver" pattern for find-and-replace. |
||
| /// __SYCL_ANY_DEVICE_HAS_ANY_ASPECT__ macro to the compilation arguments. | ||
| /// NOTE: Both intel_gpu_pvc and amd_gpu_gfx906 have non-empty aspects lists and | ||
| /// set maySupportOtherAspects to false, hence why they are used for this test. | ||
| // RUN: %clangxx -fsycl --no-offload-new-driver -nogpulib -fsycl-targets=intel_gpu_pvc,amd_gpu_gfx906 \ | ||
| // RUN: %clangxx -fsycl --no-offload-new-driver --no-offloadlib -nogpulib -fsycl-targets=intel_gpu_pvc,amd_gpu_gfx906 \ | ||
| // RUN: -fsycl-libspirv-path=%S/Inputs/SYCL/libspirv.bc -### %s 2>&1 \ | ||
| // RUN: | FileCheck -check-prefix=CHECK-SYCL-TARGETS-NO-MAY-SUPPORT-OTHER-ASPECTS %s | ||
| // RUN: %clangxx -fsycl --offload-new-driver --sysroot=%S/Inputs/SYCL -nogpulib -fsycl-targets=intel_gpu_pvc,amd_gpu_gfx906 \ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
FileName.findis a bad idea because users might have "spirv64-unknown-unknown" string in a path to the source file. Please, use more reliable check - it must the name of the directory wherelibm.bcis located.