Skip to content

MACCOR: 'Cycle P' column is read instead of 'Cycle C' #2

@dharrop-ME

Description

@dharrop-ME

Explanation

When reading maccor data from a .xlsx file the Cycle from cycler column contains only zeros, which does not match the file.
I believe this is because the _get_column_renamings function in the Maccor(BaseReader) class is mapping the Cycle P column instead of Cycle C

The Cycle P column is in my data, however I'm not even sure what it represents. The Cycle C is the one that contains the cycle number in my data.

Steps to Reproduce

Data file which reproduces the problem

example.xlsx

Code example

from pathlib import Path
import polars as pl
import ionworksdata as iwd

test = iwd.read.time_series(Path('./example.xlsx'))

print( test.select(pl.col('Cycle from cycler')) )

Output

shape: (1, 1)
┌───────────────────┐
│ Cycle from cycler │
│ ---               │
│ i64               │
╞═══════════════════╡
│ 0                 │
└───────────────────┘

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions