Fix type mismatch warnings

[janstary]

The compiler reports a lot of type mismatches during the build.

[janstary]

const char *enc for the encoding name done in #68

[mcd500]

There are the messages on Linux at the moment.

$ make
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c hpt.c
hpt.c:47:5: warning: no previous prototype for ‘hpt’ [-Wmissing-prototypes]
 int hpt(char *h, struct sockaddr *sa, unsigned char *ttl)
     ^
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c host2ip.c
host2ip.c:47:16: warning: no previous prototype for ‘host2ip’ [-Wmissing-prototypes]
 struct in_addr host2ip(char *host)
                ^
host2ip.c: In function ‘host2ip’:
host2ip.c:56:42: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   else if ((in.s_addr = inet_addr(host)) != -1) {
                                          ^
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rd.c
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rtpdump.c
rtpdump.c: In function ‘open_network’:
rtpdump.c:168:11: warning: passing argument 1 of ‘usage’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     usage("");
           ^
rtpdump.c:120:13: note: expected ‘char *’ but argument is of type ‘const char *’
 static void usage(char *argv0)
             ^
rtpdump.c:171:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
   if (sin->sin_addr.s_addr == -1) {
                            ^
rtpdump.c:173:11: warning: passing argument 1 of ‘usage’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     usage("");
           ^
rtpdump.c:120:13: note: expected ‘char *’ but argument is of type ‘const char *’
 static void usage(char *argv0)
             ^
rtpdump.c: In function ‘parse_type’:
rtpdump.c:273:12: warning: return discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     return r->version == RTP_VERSION ? "RTP" : "VATD";
            ^
rtpdump.c:277:12: warning: return discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     return r->common.version == RTP_VERSION ? "RTCP" : "VATC";
            ^
rtpdump.c: In function ‘parse_data’:
rtpdump.c:343:20: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint32_t {aka unsigned int}’ [-Wformat=]
       fprintf(out, "csrc[%d]=0x%0lx ", i, r->csrc[i]);
                    ^
rtpdump.c: At top level:
rtpdump.c:393:6: warning: no previous prototype for ‘member_sdes’ [-Wmissing-prototypes]
 void member_sdes(FILE *out, member_t m, rtcp_sdes_type_t t, char *b, int len)
      ^
rtpdump.c: In function ‘member_sdes’:
rtpdump.c:399:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_END,    "end"}, 
                        ^
rtpdump.c:400:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_CNAME,  "CNAME"},
                        ^
rtpdump.c:401:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_NAME,   "NAME"},
                        ^
rtpdump.c:402:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_EMAIL,  "EMAIL"},
                        ^
rtpdump.c:403:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_PHONE,  "PHONE"},
                        ^
rtpdump.c:404:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_LOC,    "LOC"},
                        ^
rtpdump.c:405:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_TOOL,   "TOOL"},
                        ^
rtpdump.c:406:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_NOTE,   "NOTE"},
                        ^
rtpdump.c:407:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {RTCP_SDES_PRIV,   "PRIV"},
                        ^
rtpdump.c:408:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {11,               "SOURCE"},
                        ^
rtpdump.c: In function ‘rtp_read_sdes’:
rtpdump.c:450:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   return b + ((4 - ((int)b & 0x3)) & 0x3);
                     ^
rtpdump.c: At top level:
rtpdump.c:581:6: warning: no previous prototype for ‘packet_handler’ [-Wmissing-prototypes]
 void packet_handler(FILE *out, t_format format, int trunc,
      ^
rtpdump.c: In function ‘main’:
rtpdump.c:667:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"dump",    F_dump},
      ^
rtpdump.c:668:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"header",  F_header},
      ^
rtpdump.c:669:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"hex",     F_hex},
      ^
rtpdump.c:670:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"rtcp",    F_rtcp},
      ^
rtpdump.c:671:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"short",   F_short},
      ^
rtpdump.c:672:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"payload", F_payload},
      ^
rtpdump.c:673:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"ascii",   F_ascii},
      ^
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -o rtpdump hpt.o host2ip.o                     rd.o rtpdump.o -lnsl
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c notify.c
notify.c:71:6: warning: no previous prototype for ‘check_clr_fd’ [-Wmissing-prototypes]
 void check_clr_fd(void)
      ^
notify.c:141:13: warning: no previous prototype for ‘notify_set_itimer_func’ [-Wmissing-prototypes]
 Notify_func notify_set_itimer_func(
             ^
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c multimer.c
multimer.c:95:6: warning: no previous prototype for ‘timer_check’ [-Wmissing-prototypes]
 void timer_check(void)
      ^
multimer.c:119:17: warning: no previous prototype for ‘timer_set’ [-Wmissing-prototypes]
 struct timeval *timer_set(struct timeval *interval, 
                 ^
multimer.c:191:17: warning: no previous prototype for ‘timer_get’ [-Wmissing-prototypes]
 struct timeval *timer_get(struct timeval *timeout)
                 ^
multimer.c:231:5: warning: no previous prototype for ‘timer_pending’ [-Wmissing-prototypes]
 int timer_pending(void)
     ^
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rtpplay.c
rtpplay.c: In function ‘play_handler’:
rtpplay.c:162:12: warning: variable ‘m’ set but not used [-Wunused-but-set-variable]
   uint8_t  m   = 0;
            ^
rtpplay.c:161:12: warning: variable ‘seq’ set but not used [-Wunused-but-set-variable]
   uint16_t seq = 0;
            ^
rtpplay.c: In function ‘main’:
rtpplay.c:361:52: warning: pointer targets in passing argument 3 of ‘hpt’ differ in signedness [-Wpointer-sign]
     if (hpt(argv[optind], (struct sockaddr *)&sin, &ttl) < 0) {
                                                    ^
rtpplay.c:317:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’
   extern int hpt(char *h, struct sockaddr *sa, unsigned char *ttl);
              ^
rtpplay.c:365:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (sin.sin_addr.s_addr == -1) {
                             ^
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -o rtpplay hpt.o host2ip.o notify.o multimer.o rd.o rtpplay.o -lnsl
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rtpsend.c
rtpsend.c: In function ‘rtcp_sdes_item’:
rtpsend.c:243:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"end",   RTCP_SDES_END},
      ^
rtpsend.c:244:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"cname", RTCP_SDES_CNAME},
      ^
rtpsend.c:245:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"name",  RTCP_SDES_NAME},
      ^
rtpsend.c:246:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"email", RTCP_SDES_EMAIL},
      ^
rtpsend.c:247:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"phone", RTCP_SDES_PHONE},
      ^
rtpsend.c:248:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"loc",   RTCP_SDES_LOC},
      ^
rtpsend.c:249:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"tool",  RTCP_SDES_TOOL},
      ^
rtpsend.c:250:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"note",  RTCP_SDES_NOTE}, 
      ^
rtpsend.c:251:6: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     {"priv",  RTCP_SDES_PRIV}, 
      ^
rtpsend.c: At top level:
rtpsend.c:404:7: warning: no previous prototype for ‘usec2ntp’ [-Wmissing-prototypes]
 u_int usec2ntp(u_int usec)
       ^
rtpsend.c: In function ‘rtcp_packet’:
rtpsend.c:602:7: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     { "SDES",  rtcp_write_sdes },
       ^
rtpsend.c:603:7: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     { "RR",  rtcp_write_rr },
       ^
rtpsend.c:604:7: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     { "SR",  rtcp_write_sr },
       ^
rtpsend.c:605:7: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     { "BYE",  rtcp_write_bye },
       ^
rtpsend.c:606:7: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     { "APP",  rtcp_write_app },
       ^
rtpsend.c: In function ‘rtp’:
rtpsend.c:719:11: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
       int dummy;
           ^
rtpsend.c:661:7: warning: variable ‘pad’ set but not used [-Wunused-but-set-variable]
   int pad = 0;
       ^
rtpsend.c: In function ‘send_handler’:
rtpsend.c:805:3: warning: missing initializer for field ‘data’ of ‘struct <anonymous>’ [-Wmissing-field-initializers]
   } packet = { 0, -1, 0};
   ^
rtpsend.c:804:10: note: ‘data’ declared here
     char data[1500]; 
          ^
rtpsend.c: In function ‘main’:
rtpsend.c:921:52: warning: pointer targets in passing argument 3 of ‘hpt’ differ in signedness [-Wpointer-sign]
     if (hpt(argv[optind], (struct sockaddr *)&sin, &ttl) < 0) {
                                                    ^
rtpsend.c:880:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’
   extern int hpt(char *h, struct sockaddr *sa, unsigned char *ttl);
              ^
rtpsend.c:925:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (sin.sin_addr.s_addr == -1) {
                             ^
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -o rtpsend hpt.o host2ip.o notify.o multimer.o      rtpsend.o -lnsl
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -c rtptrans.c
rtptrans.c:94:5: warning: no previous prototype for ‘create_stream’ [-Wmissing-prototypes]
 int create_stream(int addr, int next)
     ^
rtptrans.c:150:5: warning: no previous prototype for ‘find_stream’ [-Wmissing-prototypes]
 int find_stream(int addr, int ts, int next, int m)
     ^
rtptrans.c: In function ‘socket_handler’:
rtptrans.c:225:11: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
           ;
           ^
rtptrans.c:316:49: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
           if ((sendmsg(side[i][2].sock, &msg,0))!= 
                                                 ^
rtptrans.c: At top level:
rtptrans.c:386:6: warning: no previous prototype for ‘usage’ [-Wmissing-prototypes]
 void usage(char *argv0)
      ^
rtptrans.c: In function ‘main’:
rtptrans.c:459:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (host[i].sin.sin_addr.s_addr == -1) {
                                     ^
cc -g -W -Wall -Wmissing-prototypes -Wstrict-prototypes -Wwrite-strings -Wno-unused-parameter -o rtptrans hpt.o host2ip.o notify.o multimer.o      rtptrans.o -lnsl

[mcd500]

Messages on Windows.

2>d:\documents\dev\rtptools\rtptools-dev\rtpplay.c(404): warning C4133: 'function' : incompatible types - from 'int *' to 'const char *'
4>d:\documents\dev\rtptools\rtptools-dev\rtptrans.c(292): warning C4133: 'function' : incompatible types - from 'sockaddr_in *' to 'const sockaddr *
1>d:\documents\dev\rtptools\rtptools-dev\rtpsend.c(957): warning C4133: 'function' : incompatible types - from 'int *' to 'const char *