diff --git a/src/app/components/elements/TeacherDashboard.tsx b/src/app/components/elements/TeacherDashboard.tsx index ae5e02f4d6..b9a9aec406 100644 --- a/src/app/components/elements/TeacherDashboard.tsx +++ b/src/app/components/elements/TeacherDashboard.tsx @@ -164,7 +164,7 @@ const BooksPanel = () => { )} - See all books + See all books ; }; diff --git a/src/app/components/elements/list-groups/AbstractListViewItem.tsx b/src/app/components/elements/list-groups/AbstractListViewItem.tsx index 0dd3716fd9..18eaf57980 100644 --- a/src/app/components/elements/list-groups/AbstractListViewItem.tsx +++ b/src/app/components/elements/list-groups/AbstractListViewItem.tsx @@ -217,7 +217,7 @@ export const AbstractListViewItem = ({title, icon, subject, subtitle, breadcrumb } {isGameboard && typedProps.board?.contents && } -
+
{url && !isDisabled ? (url.startsWith("http") diff --git a/src/app/components/pages/BooksOverview.tsx b/src/app/components/pages/BooksOverview.tsx index ee61508961..173ffbb7a9 100644 --- a/src/app/components/pages/BooksOverview.tsx +++ b/src/app/components/pages/BooksOverview.tsx @@ -8,18 +8,20 @@ import { BooksOverviewSidebar } from "../elements/sidebar/BooksOverviewSidebar"; import { PageContainer } from "../elements/layout/PageContainer"; export const BookCard = (book: BookInfo) => { - return -
- {book.title} -
-
-
{book.title}
-
- - {book.description} - -
- ; + return
+ +
+ {book.title} +
+
+
{book.title}
+
+ + {book.description} + +
+ +
; }; export const BooksOverview = () => { diff --git a/src/app/components/pages/SubjectLandingPage.tsx b/src/app/components/pages/SubjectLandingPage.tsx index 4f630d8d9b..79ec2acd3e 100644 --- a/src/app/components/pages/SubjectLandingPage.tsx +++ b/src/app/components/pages/SubjectLandingPage.tsx @@ -123,10 +123,14 @@ const FooterRow = ({context, books, news, events}: FooterRowProps) => {

Interactive online books ({books.length})

-
- {books.slice(0, 4).map((book, index) => )} - {books.length > 4 && } -
+ + + {books.slice(0, 4).map((book, index) => )} + + + {books.length > 4 && } + + : <>
@@ -150,7 +154,7 @@ const FooterRow = ({context, books, news, events}: FooterRowProps) => {
{relevantEvents.map((event, i) => - + {event && } )} diff --git a/src/scss/phy/books.scss b/src/scss/phy/books.scss index 6750399335..9c5e87a6bf 100644 --- a/src/scss/phy/books.scss +++ b/src/scss/phy/books.scss @@ -93,6 +93,18 @@ svg.book-page-icon { } } +.book-card { + padding: 0; + + // To allow for a visible focus outlines across all book-card contexts, book-containers within book-cards + // should have a small margin to prevent the box shadow from being cut off, and a width that accomodates this margin + .book-container { + padding: 0.25rem; + margin: 0.25rem; + max-width: calc(100% - 0.5rem); + } +} + .book-image-container { position: relative; width: max-content; diff --git a/src/test/pages/__image_snapshots__/sci/Subject landing pages should have no visual regressions #0.png b/src/test/pages/__image_snapshots__/sci/Subject landing pages should have no visual regressions #0.png index 4b4d699e8f..77db1588e8 100644 Binary files a/src/test/pages/__image_snapshots__/sci/Subject landing pages should have no visual regressions #0.png and b/src/test/pages/__image_snapshots__/sci/Subject landing pages should have no visual regressions #0.png differ