From 796ab14b7a2806a917616becfe82e31e2472bd91 Mon Sep 17 00:00:00 2001 From: issy Date: Fri, 3 Apr 2026 16:49:57 +0100 Subject: [PATCH 1/4] Rename --- .github/workflows/web_deployment.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/web_deployment.yml b/.github/workflows/web_deployment.yml index 248016f..9807adc 100644 --- a/.github/workflows/web_deployment.yml +++ b/.github/workflows/web_deployment.yml @@ -49,7 +49,7 @@ jobs: gitHubToken: ${{ secrets.GITHUB_TOKEN }} preview-deploy: - name: Deploy (Preview) + name: Preview runs-on: ubuntu-latest if: github.event_name == 'pull_request' && github.ref != 'refs/heads/main' permissions: @@ -80,7 +80,7 @@ jobs: - name: Build project run: pnpm build - - name: Deploy + - name: Deploy Preview uses: cloudflare/wrangler-action@v3 with: workingDirectory: web From d3705a0e65fee21e696fc3f12d35494f84c15c1c Mon Sep 17 00:00:00 2001 From: issy Date: Fri, 3 Apr 2026 16:50:18 +0100 Subject: [PATCH 2/4] Add text specifically for development preview --- web/src/views/device/DeviceConnectView.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/web/src/views/device/DeviceConnectView.tsx b/web/src/views/device/DeviceConnectView.tsx index 7d9a708..699ee6a 100644 --- a/web/src/views/device/DeviceConnectView.tsx +++ b/web/src/views/device/DeviceConnectView.tsx @@ -15,6 +15,7 @@ function DeviceConnectView() { ) : (
Disconnected + Testing!!!
)} From 2035bde62a654c0fc626c7bd8efc84700dd57083 Mon Sep 17 00:00:00 2001 From: issy Date: Fri, 3 Apr 2026 16:52:45 +0100 Subject: [PATCH 3/4] Split into separate workflow file --- .github/workflows/web_deployment.yml | 43 ------------------------ .github/workflows/web_preview.yml | 49 ++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+), 43 deletions(-) create mode 100644 .github/workflows/web_preview.yml diff --git a/.github/workflows/web_deployment.yml b/.github/workflows/web_deployment.yml index 9807adc..c0acb39 100644 --- a/.github/workflows/web_deployment.yml +++ b/.github/workflows/web_deployment.yml @@ -4,13 +4,11 @@ on: push: branches: - main - pull_request: jobs: production-deploy: name: Deploy runs-on: ubuntu-latest - if: github.event_name == 'push' && github.ref == 'refs/heads/main' permissions: contents: read deployments: write @@ -47,44 +45,3 @@ jobs: apiToken: ${{ secrets.CLOUDFLARE_PAGES_API_KEY }} command: pages deploy dist --project-name=midi-footcontroller gitHubToken: ${{ secrets.GITHUB_TOKEN }} - - preview-deploy: - name: Preview - runs-on: ubuntu-latest - if: github.event_name == 'pull_request' && github.ref != 'refs/heads/main' - permissions: - contents: read - deployments: write - defaults: - run: - working-directory: web - steps: - - name: Checkout repository - uses: actions/checkout@v6 - - - name: Setup Node - uses: actions/setup-node@v6 - with: - node-version: '24.x' - check-latest: true - cache-dependency-path: web/pnpm-lock.yaml - - - name: Install pnpm - uses: pnpm/action-setup@v4 - with: - package_json_file: 'web/package.json' - - - name: Install dependencies - run: pnpm install - - - name: Build project - run: pnpm build - - - name: Deploy Preview - uses: cloudflare/wrangler-action@v3 - with: - workingDirectory: web - accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} - apiToken: ${{ secrets.CLOUDFLARE_PAGES_API_KEY }} - command: pages deploy dist --project-name=midi-footcontroller --branch=${{ github.head_ref }} - gitHubToken: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/web_preview.yml b/.github/workflows/web_preview.yml new file mode 100644 index 0000000..161c88d --- /dev/null +++ b/.github/workflows/web_preview.yml @@ -0,0 +1,49 @@ +name: Web + +on: + pull_request: + types: + - opened + - reopened + - synchronize + +jobs: + preview-deploy: + name: Preview + runs-on: ubuntu-latest + permissions: + contents: read + deployments: write + defaults: + run: + working-directory: web + steps: + - name: Checkout repository + uses: actions/checkout@v6 + + - name: Setup Node + uses: actions/setup-node@v6 + with: + node-version: '24.x' + check-latest: true + cache-dependency-path: web/pnpm-lock.yaml + + - name: Install pnpm + uses: pnpm/action-setup@v4 + with: + package_json_file: 'web/package.json' + + - name: Install dependencies + run: pnpm install + + - name: Build project + run: pnpm build + + - name: Deploy Preview + uses: cloudflare/wrangler-action@v3 + with: + workingDirectory: web + accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} + apiToken: ${{ secrets.CLOUDFLARE_PAGES_API_KEY }} + command: pages deploy dist --project-name=midi-footcontroller --branch=${{ github.head_ref }} + gitHubToken: ${{ secrets.GITHUB_TOKEN }} From beb4e63fb16d1329f793a28e75117ceef01e218e Mon Sep 17 00:00:00 2001 From: issy Date: Fri, 3 Apr 2026 16:54:30 +0100 Subject: [PATCH 4/4] Remove text --- web/src/views/device/DeviceConnectView.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/web/src/views/device/DeviceConnectView.tsx b/web/src/views/device/DeviceConnectView.tsx index 699ee6a..7d9a708 100644 --- a/web/src/views/device/DeviceConnectView.tsx +++ b/web/src/views/device/DeviceConnectView.tsx @@ -15,7 +15,6 @@ function DeviceConnectView() { ) : (
Disconnected - Testing!!!
)}