Skip to content
This repository was archived by the owner on Apr 14, 2020. It is now read-only.

Commit 323abff

Browse files
author
Michael Dougall
committed
chore: adds eslint rules
1 parent 2e9aa4d commit 323abff

8 files changed

Lines changed: 206 additions & 9 deletions

File tree

.eslintrc

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,23 @@
11
{
22
"parser": "typescript-eslint-parser",
3-
"plugins": ["eslint-plugin-typescript"]
3+
"plugins": ["typescript"],
4+
"extends": ["airbnb", "prettier", "prettier/react"],
5+
"env": {
6+
"browser": true,
7+
"jest": true
8+
},
9+
"rules": {
10+
"typescript/class-name-casing": "error",
11+
"typescript/no-unused-vars": "error",
12+
"react/jsx-filename-extension": ["error", { "extensions": [".tsx"] }],
13+
"import/no-unresolved": "off",
14+
"no-undef": "off",
15+
"arrow-body-style": "off",
16+
"no-restricted-globals": "off",
17+
"no-multi-str": "off",
18+
"import/no-extraneous-dependencies": [
19+
"error",
20+
{ "devDependencies": ["**/*test.tsx", "**/*stories.tsx"] }
21+
]
22+
}
423
}

.vscode/settings.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@
55
"**/bower_components": true,
66
"**/docs/**": true
77
},
8-
"typescript.tsdk": "node_modules/typescript/lib"
8+
"typescript.tsdk": "node_modules/typescript/lib",
9+
"eslint.enable": true
910
}

package.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"scripts": {
88
"tdd": "jest --watch",
99
"build": "lerna run build",
10-
"lint": "eslint .",
10+
"lint": "eslint --ext .tsx .",
1111
"test": "jest",
1212
"pre-cut-version": "yarn test",
1313
"postinstall": "yarn build && lerna link",
@@ -35,10 +35,16 @@
3535
"@types/storybook__react": "^3.0.9",
3636
"babel-core": "^6.26.3",
3737
"css-loader": "^1.0.0",
38+
"enzyme": "^3.6.0",
3839
"enzyme-adapter-react-16": "^1.5.0",
3940
"enzyme-matchers": "^6.0.4",
4041
"enzyme-to-json": "^3.3.3",
4142
"eslint": "^5.6.0",
43+
"eslint-config-airbnb": "^17.1.0",
44+
"eslint-config-prettier": "^3.1.0",
45+
"eslint-plugin-import": "^2.14.0",
46+
"eslint-plugin-jsx-a11y": "^6.1.1",
47+
"eslint-plugin-react": "^7.11.1",
4248
"eslint-plugin-typescript": "^0.12.0",
4349
"jest": "^23.5.0",
4450
"jest-enzyme": "^6.0.4",

packages/yubaba/src/Baba/index.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
import * as React from 'react';
2-
import { unstable_renderSubtreeIntoContainer, unmountComponentAtNode } from 'react-dom';
2+
import {
3+
unstable_renderSubtreeIntoContainer as renderSubtreeIntoContainer,
4+
unmountComponentAtNode,
5+
} from 'react-dom';
36
import Collector, {
47
SupplyDataHandler,
58
SupplyRenderChildrenHandler,
@@ -12,7 +15,7 @@ import Collector, {
1215
TargetProps,
1316
} from '../Collector';
1417
import { getElementSizeLocation } from '../lib/dom';
15-
import { defer } from '../lib/defer';
18+
import defer from '../lib/defer';
1619
import * as childrenStore from '../lib/childrenStore';
1720
import { InjectedProps, withBabaManagerContext } from '../BabaManager';
1821

@@ -271,7 +274,7 @@ If it's an image, try and have the image loaded before mounting, or set a static
271274
// This ensures that if there was an update to the jsx that is animating,
272275
// it changes next frame. Resulting in the transition _actually_ happening.
273276
requestAnimationFrame(() =>
274-
unstable_renderSubtreeIntoContainer(
277+
renderSubtreeIntoContainer(
275278
this,
276279
jsx as React.ReactElement<{}>,
277280
elementToMountChildren

packages/yubaba/src/Baba/test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'jest-enzyme';
44
import { Baba } from '../Baba';
55
import Target from '../Target';
66
import { getElementSizeLocation } from '../lib/dom';
7-
import { defer } from '../lib/defer';
7+
import defer from '../lib/defer';
88
import * as utils from '../__tests__/utils';
99

1010
jest.mock('../lib/dom');

packages/yubaba/src/BabaManager/test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { mount } from 'enzyme';
33
import Baba from '../Baba';
44
import BabaManager from '../BabaManager';
55
import * as utils from '../__tests__/utils';
6-
import { defer } from '../lib/defer';
6+
import defer from '../lib/defer';
77

88
describe('<BabaManager />', () => {
99
it('should show manager content when waiting for animation', () => {

packages/yubaba/src/lib/defer.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export const defer = <TValue extends void>() => {
1+
const defer = <TValue extends void>() => {
22
let resolve: (value?: TValue | PromiseLike<TValue> | undefined) => void = () => {};
33
let reject: (value?: TValue | PromiseLike<TValue> | undefined) => void = () => {};
44

@@ -13,3 +13,5 @@ export const defer = <TValue extends void>() => {
1313
promise,
1414
};
1515
};
16+
17+
export default defer;

0 commit comments

Comments
 (0)