DeviceType Parameter can be too long

[TVLuke]

Hi

I just noticed that in the HueBridge the variable deviceType is set by calling

String deviceType = getClass().getName();

Ans this value is then send to the Hue however, the devicetype parameter is not allowed to be longer then 40 characters (http://developers.meethue.com/4_configurationapi.html), causing an error in the completeSync method if it is indeed longer.

I have changed it to

String deviceType = getClass().getName().substring(0, 35);

which I believe to be usable way to circumvent this restriction especially for Android developers who may not see the internal error messages of the sdk (At least I have spend some hours on this).

Just wanted to mention this (in case someone else may have that problem) and as a suggestion that may ease development.

[jaetzold]

Hi

you're right. Just using the classname without checking for maximum length is an error.
Is there a particular reason that you're limiting the deviceType to 35 characters instead of the allowed 40?

Apart from that it needs an additional check, that the String is indeed longer, because substring(int,int) will throw an IndexOutOfBoundsException if one of the indices does fall outside of the length of the String.

And i also would prefer to have the classname complete and truncate the package name if necessary. Ideally by stripping out complete package names in the middle.

Ciao,
Stephan.

[TVLuke]

Indeed it needs an additional check. The 35 is random, no reason at all.