Skip to content
This repository was archived by the owner on Apr 3, 2018. It is now read-only.

Escape late rather than during building of query_string#9

Open
phh wants to merge 1 commit into
jakemgold:masterfrom
phh:master
Open

Escape late rather than during building of query_string#9
phh wants to merge 1 commit into
jakemgold:masterfrom
phh:master

Conversation

@phh

@phh phh commented Mar 14, 2017

Copy link
Copy Markdown

To reproduce:

  • Go to pages
  • In the admin columns click an author (to show the authors posts)
  • Then click "Sort by order"
  • The filter is now broken as the url instead contains #038;
  • Replacing #038; with & fixes the filter

With this fix the filters just keep working.

@helen

helen commented Apr 2, 2018

Copy link
Copy Markdown

Hi @phh! Sorry we missed this - we had been working on migrating this plugin repo to the @10up organization account. Looks like an identical fix went in as 10up/simple-page-ordering#6 and was released to .org - I don't know if there's any way to get you GitHub contribution credit at this point without the unpleasantries of force-pushing but I'll look into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants