Added alternative example#20
Open
julkue wants to merge 1 commit intojbr:masterfrom
julkue:demo-alternative
Open
Added alternative example#20julkue wants to merge 1 commit intojbr:masterfrom julkue:demo-alternative
julkue wants to merge 1 commit intojbr:masterfrom
julkue:demo-alternative
Conversation
Author
|
Ping @jbr |
Owner
|
@julmot What improvement over the existing demo does the codepen demo offer? Could the existing demo be improved or replaced? |
Owner
|
I would happily accept changes to https://github.com/jbr/jQuery.highlightRegex/blob/master/index.html if there are features that would improve it |
Author
what's wrong now? |
Author
|
Owner
|
I realized there was no reason to have two similar examples. I'd like to replace index.html with something like yours, if you think those four improvements would help people get a sense of the plugin. |
Author
|
Well, I think both examples give a quick overview and beside of more options the CodePen demo offers a better UX. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here you go.
Closes #19