Skip to content

code cleanup #21

@mewalig

Description

@mewalig

I'd like to clean up this code base because

  1. I'd like to use it
  2. I'd like to modify it and
  3. it will be much easier to use and much easier to modify if we clean it up first

For example:

  • there are 16 unused variables. this creates unnecessary confusion, especially with the similar naming conventions
  • there are various redundant snippets of code that can be consolidated into reusable functions
  • there are a number of implied globals which will raise errors if we put the code through a strict parser

I'd like to fix all of these and submit them back into a pull request.

In addition, I'd like to convert this to typescript and gradually add in the various type checking and other benefits that Typescript offers.

All of the above will be a lot of changes but I'm sure will make this project a lot more valuable to others. Will you accept these changes if I put them all into a pull request? Alternatively, if you prefer, I can just fork this and make the changes there, and we can leave them as separate forked repos.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions