US1735231 - Added support for encoded tokens#80
Open
amoghng7 wants to merge 2 commits into
Open
Conversation
…order - TokenUtil.java: Fix @param mismatch (inputString -> str) that broke CI Javadoc - TokenUtil.java: Add MIT license header - TokenUtil.java: Remove unused isBase64Encoded() method and related constants - TokenUtil.java: Fix modifier order (private static final) - StandardFortifyApiToken.java: Reorder doCheckToken() to check blank before UUID - ApiClientWrapper.java: Add space after 'if' keyword - Add TokenUtilTest.java with unit tests for isUuid()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for encoded token and added a deprecation warning for decoded tokens
Testing done
Following tests were done:
Add a new Fortify Token
Insert a UUID token
A Warning "You are using a decoded token. Decoded tokens are deprecated and will not be supported in future releases!" must be displayed
Add a new Fortify Token
Insert any token
There must be no warning or error messages
Add a new Fortify Token
Keep the text box empty
There must be an error message "Token cannot be empty!"
Submitter checklist