Skip to content

fix: stop requeueing worked issues #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremymcs merged 1 commit into from
May 28, 2026
Merged

fix: stop requeueing worked issues #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions server/appRuntime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,8 +752,10 @@ function makePlanIssue(
repo: overrides.repo,
number: overrides.number,
author: overrides.author ?? "alice",
isWorked: overrides.isWorked ?? false,
workStatus: overrides.workStatus ?? "idle",
workPrUrl: overrides.workPrUrl ?? null,
externalWorkPrUrl: overrides.externalWorkPrUrl ?? null,
autoWorkEligible: overrides.autoWorkEligible ?? false,
evaluationStatus: overrides.evaluationStatus ?? null,
updatedAt: overrides.updatedAt ?? "2026-05-01T00:00:00.000Z",
Expand Down Expand Up @@ -877,6 +879,32 @@ test("planAutomaticIssueQueueActions queues work for approved+eligible issues wh
assert.deepEqual(plan.work, [{ repo: "acme/widgets", number: 1, id: "acme/widgets#1" }]);
});

test("planAutomaticIssueQueueActions does not requeue worked issues", () => {
const plan = planAutomaticIssueQueueActions({
repoSettings: [{ repo: "acme/widgets", issueAutoEvaluate: true, issueAutoWork: true }],
issues: [
makePlanIssue({
repo: "acme/widgets",
number: 1,
isWorked: true,
evaluationStatus: "approved",
autoWorkEligible: true,
}),
makePlanIssue({
repo: "acme/widgets",
number: 2,
isWorked: true,
}),
],
activeEvaluationTargets: new Set(),
activeWorkCount: 0,
maxConcurrentIssueEvaluations: 2,
maxConcurrentIssueWork: 1,
});

assert.deepEqual(plan, { evaluations: [], work: [] });
});

test("planAutomaticIssueQueueActions respects per-repo single-flight on work", () => {
// Goal: don't pile multiple work jobs onto one repo even if budget allows — the agent
// runs one at a time per repo, so queueing more just creates lag.
Expand Down
5 changes: 3 additions & 2 deletions server/appRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ export type PlanAutomaticIssueQueueInput = {
repoSettings: Pick<WatchedRepo, "repo" | "issueAutoEvaluate" | "issueAutoWork">[];
issues: Pick<
Issue,
"id" | "repo" | "number" | "author" | "workStatus" | "workPrUrl" | "externalWorkPrUrl" | "autoWorkEligible" | "evaluationStatus" | "updatedAt"
"id" | "repo" | "number" | "author" | "isWorked" | "workStatus" | "workPrUrl" | "externalWorkPrUrl" | "autoWorkEligible" | "evaluationStatus" | "updatedAt"
>[];
activeEvaluationTargets: Set<string>;
activeWorkCount: number;
Expand Down Expand Up @@ -357,7 +357,7 @@ export function planAutomaticIssueQueueActions(
continue;
}
const candidate = repoIssues
.filter((issue) => issue.workStatus === "idle" && !issue.workPrUrl && !issue.externalWorkPrUrl && issue.autoWorkEligible)
.filter((issue) => !issue.isWorked && issue.workStatus === "idle" && !issue.workPrUrl && !issue.externalWorkPrUrl && issue.autoWorkEligible)
.sort((a, b) => compareIssueQueuePriority(a, b, priorityIssueAuthors))[0];
if (!candidate) continue;
result.work.push({ repo: candidate.repo, number: candidate.number, id: candidate.id });
Expand All @@ -372,6 +372,7 @@ export function planAutomaticIssueQueueActions(
const pending = input.issues
.filter((issue) =>
issue.repo === repo
&& !issue.isWorked
&& issue.workStatus === "idle"
&& !issue.workPrUrl
&& !issue.externalWorkPrUrl
Expand Down
Loading