Better interface for leaving feedback against a commit.

[jesseduffield]

Is your feature request related to a problem? Please describe.

I'm using lazygit alongside a claude code session, and often claude will produce a bunch of code, then I'll read through it with lazygit and switch back and forth between lazygit and claude to enter feedback (sometimes copy-pasting snippets, or just describing the thing in general).

Sometimes, I'll instead have claude raise a PR and then I'll review the diff in github and leave comments on the PR directly, then get claude to fetch the comments from github to address them.

Github has a fairly good PR review UI where you can mark files as read (and they'll be marked as unread if changed in a subsequent commit) and it's got good lookup functionality but it's a bit annoying having to submit the review and then come back to claude to get it to

Describe the solution you'd like

I'm not sure what solution I actually want. Three things that come to mind:

1. Just use the github UI and improve the ergonomics of having claude interact with github
2. A purely local means of leaving feedback against lines in a commit, with the ability to copy the whole thing to clipboard once I'm done to paste into a claude session (or write to a file, or just get claude to directly look at whichever file holds the local state).
3. Extend the integration with github to allow leaving PR comments against commits

Thinking out loud:

• Would we want to allow leaving comments against just commits, or against the diff itself. And what is 'the diff'? Would we allow some way to view the full diff of a PR, or would we let the user select a range of commits to leave the comments on, with no requirement for there to actually be a PR on github?

Interested on your thoughts about this @stefanhaller

[stefanhaller]

Working with Claude

For working with Claude I don't understand why you want to take the indirection through Github. Pointing Claude at local code is so easy and seamless that I'm not sure what you are missing there. I use the Claude VS Code extension that makes it super convenient to select some code and refer to it in a prompt, e.g. like this:

When it comes to jumping from a lazygit diff to the corresponding place in the code in VS Code, I use delta's hyperlink feature, as described here. I find it indispensable and wouldn't want to work without it. It's unfortunate that it's only available via mouse clicking, not keyboard; this is discussed in #3986.

Reviewing PRs

For human PRs I agree: if a colleague asks for a PR review I often start reading the branch in lazygit because I find diffs more pleasant to read there than in Github. But when I come across something I want to comment on, I have to find the corresponding commit and diff hunk again in the browser, which is cumbersome.

It would be nice if there was a way to have lazygit jump into the browser in the same place, and it seems that a URI such as https://github.com/jesseduffield/lazygit/pull/5621/changes/f032ee8b0f36747b4edfeab178e82e2a4d32c643#diff-0776a04e9be3fc3fc0a681b9b122a1375858afc8de884062866b8a68fbf51692R1351 should make this possible, since lazygit knows the PR URI. But this has the same problems that are discussed in #3986:

• Commit diffs in lazygit don't have a selection, not even when you press 0 to focus the main view on the diff, so it's impossible to tell lazygit which line you are looking at
• When using a pager we don't know which line of the diff corresponds to which source line, unless we establish some protocol with the pager to tell us.

Both points can be addressed by going into the patch building panel, but that's also cumbersome (requires to press enter to see files, select the file you were just looking at, press enter again to enter staging, and then find the hunk again that you were just looking at). This is almost as cumbersome as finding the hunk in Github to begin with.

[stefanhaller]

@jesseduffield I made some progress on the "commit diffs in lazygit don't have a selection" problem. I changed the proof-of-concept draft in #3985 to have a selection on demand, and I find that this works quite well. Please see the PR description of that draft PR for more information. Very curious what you think about that direction; since I didn't get any feedback to my reply here so far, I can't tell if this addresses your needs.