INST-23232 - Document ServiceAccountNodeAudienceRestriction for GKE Workload Identity#81
Open
nagarajuv-jfrog wants to merge 1 commit into
Open
INST-23232 - Document ServiceAccountNodeAudienceRestriction for GKE Workload Identity#81nagarajuv-jfrog wants to merge 1 commit into
nagarajuv-jfrog wants to merge 1 commit into
Conversation
…orkload Identity Update GCP.md and example values to use <PROJECT_ID>.svc.id.goog as the jfrog_oidc_audience for Option B (Workload Identity / KEP-4412). Add Step 3B.5 documenting the ServiceAccountNodeAudienceRestriction feature gate (enabled by default in Kubernetes 1.33+) and the ClusterRole required to grant system:nodes permission to request projected tokens for this audience. Correct the RBAC comment in values.yaml which incorrectly stated RBAC was only needed for AWS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GCP.mdOption B (Workload Identity) to use<PROJECT_ID>.svc.id.googasjfrog_oidc_audienceinstead of the genericartifactorystring, aligning with the GKE Workload Identity pool identifierServiceAccountNodeAudienceRestrictionfeature gate (enabled by default in Kubernetes 1.33+), which restricts the Kubelet from requesting projected tokens for arbitrary audiences — and the ClusterRole required to authorize itjfrog_oidc_audience, not the hardcodedidentityconfig.googleapis.comexamples/gcp-projected-service-account-values.yamlaudience and adds a comment explaining whyrbac.create: trueis required for K8s 1.33+helm/values.yamlRBAC comment, which incorrectly stated RBAC was only needed for AWSFiles changed
GCP.mdexamples/gcp-projected-service-account-values.yamljfrog_oidc_audience: "<PROJECT_ID>.svc.id.goog", addedrbac.create: truecommenthelm/values.yamlTest plan
jfrog_oidc_audience: "<PROJECT_ID>.svc.id.goog"in the example values file renders correctly viahelm templateServiceAccountNodeAudienceRestrictionenabledCloses INST-23232