Skip to content

Server panics if JOURNEYS_GTFS_PATH is incorrect #45

Description

@jlundan
➜  journeys-bin-test cat start.sh 
#!/bin/bash

chmod +x ./journeys.api-linux-amd64
MEMCACHED_URL="localhost:11211" JOURNEYS_GTFS_PATH=.gtfs JOURNEYS_BASE_URL="https://data.itsfactory.fi/journeys/api/1" JOURNEYS_VA_BASE_URL="https://data.itsfactory.fi/journeys/api/1" ./journeys.api-linux-amd64 start

➜  journeys-bin-test ./journeys.api-linux-amd64 version
Version: v1.0.0-test-4

➜  journeys-bin-test ./start.sh
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x12 pc=0x56a70e]

goroutine 1 [running]:
encoding/csv.(*Reader).Read(0x46bafd?)
        /opt/hostedtoolcache/go/1.23.5/x64/src/encoding/csv/reader.go:198 +0xe
github.com/jlundan/journeys-api/pkg/ggtfs.getHeaderIndex(0xc0000383a0?, {0xc23f80, 0x8, 0xc000014360?})
        /home/runner/work/journeys-api/journeys-api/pkg/ggtfs/parsingutil.go:25 +0x32
github.com/jlundan/journeys-api/pkg/ggtfs.loadCsvEntities[...]({0xc23f80, 0xc0000fa2c8?, 0xc0000baf60?}, 0xc0000383a0?, 0x8dcc68)
        /home/runner/work/journeys-api/journeys-api/pkg/ggtfs/loading.go:52 +0x48
github.com/jlundan/journeys-api/pkg/ggtfs.LoadAgencies(...)
        /home/runner/work/journeys-api/journeys-api/pkg/ggtfs/loading.go:18
github.com/jlundan/journeys-api/internal/app/journeys/repository.newGTFSBundle({0xc00002c013, 0x5}, 0x0)
        /home/runner/work/journeys-api/journeys-api/internal/app/journeys/repository/gtfs.go:36 +0x549
github.com/jlundan/journeys-api/internal/app/journeys/repository.NewJourneysRepository({0xc00002c013?, 0xd?}, 0x0?)
        /home/runner/work/journeys-api/journeys-api/internal/app/journeys/repository/repository.go:8 +0x2a
main.init.func1(0xc0000da100?, {0xc4c400?, 0x4?, 0x896897?})
        /home/runner/work/journeys-api/journeys-api/cmd/journeys/journeys.go:54 +0x172
github.com/spf13/cobra.(*Command).execute(0xc25c20, {0xc4c400, 0x0, 0x0})
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:989 +0xa91
github.com/spf13/cobra.(*Command).ExecuteC(0xc25940)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1117 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
        /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1041
main.main()
        /home/runner/work/journeys-api/journeys-api/cmd/journeys/journeys.go:125 +0x165

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions