Suggestions & Issues

[Talbe1]

Hello, I have been using your Minecraft Mod Updater mod for some time and there are a few suggestions and things that have bothered me. I do want to point out that despite the issue(s) mentioned below, and that this is a very new mod, this is one of the best mod updating mods that I have seen so far (I have used Mod Manager, Fabrilous Updater, and Modget).
Note: I play on Minecraft 1.18.2.

Features that I think should be added:

• Quilt loader support (Quilt constantly crashes).
• Have a button directly next to the search bar in the Mod Menu window to open the mod listing screen much more easily (instead of having to browse for the mod each time and press the "Configure" button).
  The picture is an example of how I think it should be done (the button is a part of Mod Manager)
  

Things that bother me:

• Each time you browse a mod, and press on the plus (+) button to download it, the mod instantly takes you back from the browsing screen, to the mods listing screen. This gets very annoying, very quickly if I want to install multiple mods.

2022-09-18.17-34-46.mp4

• Additionally about the browsing of mods, I noticed that the same mod can appear multiple times in the list (look in the beginning of the video above, the Sodium mod appears twice), maybe add an option to open the CurseForge page OR the Modrinth page of the mod?
• I have the exact same mods in both the "mods" folder and "mods-local" folder, yet I can't see any of my mods in the list (see picture).
  

[RaggyTheFox]

Same issue here; mods are not showing up in the mod config screen even though they are both in mods and mods-local. Am using Fabric 1.19.1 and MultiMC.

[jonafanho]

Thank you for your suggestions! It's a good idea to show local mods in the list as well.

[jonafanho]

Hello again, here are a few updates:

• I haven't looked into Quilt support yet. Since my mod is based on Architectury (I plan to add Forge support in the future), I'm limited by what loaders Architectury supports. Maybe I can poke around when I have time.
• I also haven't looked into adding a shortcut button in Mod Menu.
• After browsing for mods and adding them, it doesn't jump back to the main configuration screen.
• When browsing for mods, there's no easy way to detect if a CurseForge mod and a Modrinth mod are the same. Right now, it detects if the title AND the description are equal and groups them that way. For example, for the Sodium mod, the CurseForge and Modrinth descriptions are slightly different so my code recognises it as two different mods.
• Mods in your mods-local folder should now show up in the "Local Mods" list.

As I haven't addressed everything you have raised, I will keep this GitHub issue open for now. Please try the new update (version 0.0.3) and let me know what you think.

[Talbe1]

Hello jonafanho,

I just tested version 0.0.3 of your mod, there are a few things to say/ask about:

• About Quilt support, it's up to you to make your mod support Quilt. In my opinion, despite that I requested support for Quilt, you should only look for supporting Quilt if there's further demand for it.

• About the fact that your mod is based on Architectury, is it embedded into Mod Updater? Because if not, I think the dependency on it should be mentioned in the Modrinth page of the mod.

• About browsing for mods and adding them, I confirmed that it now doesn't jump back to the main config screen.

• Is there supposed an "Update now?" button to look for updates for all the mods and update them? Because I couldn't find such button/option, nor Mod Updater updated one of my mods (which wasn't up to date, in my case Dashloader) automatically upon reopening the game.

  However, when I went ahead to install the latest version of the mod (Dashloader) through the browsing screen, Mod Updater
  automatically replaced the older version with the newer one. Now comes the question, is there supposed to be an indication in the config screen that some specific mods aren't up to date?

  Note: I need to further test the last issue in order to confirm it on a few more mods, since I tested the updating functionality on just a single one.

Also, unrelated to any of the issues above, I really do appreciate this mod and the work you're putting into it.
The mod works very well for how new it is (which I didn't really expect considering my experience with the other mod updater mods).

[jonafanho]

Hello Talbe1, thanks for your new feedback.

• Architectury is just a mapping tool or library to help me write the mod. It is not a dependency because I didn't use any Architectury-specific code.
• The mod won't check for updates in your local folder, because it won't have any idea where you downloaded the mods from. It doesn't search CurseForge and Modrinth by filename, since it's different from a CurseForge or Modrinth mod ID. Therefore, it is always recommended to add mods using "Browse Mods" rather than using the mods-local folder, unless it's not available on CurseForge or Modrinth, eg. Optifine.

Some updates for 0.0.4:

• Combined "Add Mod From URL" and "Add Modpack From URL" because the difference can be confusing
• If a mod is dynamically added and there is a duplicate or different version of the mod in mods-local, it will not be copied over (eg. if you use the "Browse for Mods" function to add Fabric API, but there's an outdated Fabric API in the mods-local folder)

Thank you for your kind words about the mod! I'm glad it works well for you.

[Talbe1]

Hello jonafanho,

Thanks for answering my questions.
I tested the new version (0.0.4) and it seems to work very well.

About the updating process, I did notice that Mod Updater updates my mods (which I added from the browsing screen) properly and automatically all by itself. I now understand why the shortcut button I mentioned in my first comment doesn't exist, because from what it seems, it might not need to.

I guess that one of the major goals of this mod is to make the updating process as seemless, smooth and automatic as possible. Despite this, I do think that the user should receive a notification (maybe a toast notification at the main menu of the game?)
letting him know that some mods were updated.

[jonafanho]

Hello Talbe1, glad the new version works well. The notification popup is a good idea. It can also probably be coded to show the download progress before the game itself actually launches so that the user isn't just sitting there wondering if the game will launch or not.