From 7472bb15636150a272d8f006726cc14382c66d28 Mon Sep 17 00:00:00 2001
From: Erwan MAS <erwan@mas.nom.fr>
Date: Sat, 4 Nov 2023 17:58:09 -0400
Subject: [PATCH 1/2] small changes to be able to run test on MacOs

set LC_ALL=C to avoid utf8 warning on macos
generate the tempdir differently so this working on Macos ( still working on linux )
keep the tempdir when we have a failure
add a regeression test for readlink
---
 tests/custom/03_stdlib/62_loadfile |  4 ++--
 tests/custom/03_stdlib/69_readlink | 25 +++++++++++++++++++++++++
 tests/custom/run_tests.sh          | 27 ++++++++++++++-------------
 3 files changed, 41 insertions(+), 15 deletions(-)
 create mode 100644 tests/custom/03_stdlib/69_readlink

diff --git a/tests/custom/03_stdlib/62_loadfile b/tests/custom/03_stdlib/62_loadfile
index 9aaa0cf6..26875293 100644
--- a/tests/custom/03_stdlib/62_loadfile
+++ b/tests/custom/03_stdlib/62_loadfile
@@ -152,9 +152,9 @@ Test loading precompiled bytecode
 
 -- Testcase --
 {%
-	import { readlink } from 'fs';
 
-	system(`${readlink('/proc/self/exe')} -T, -c -o ./files/test7.uc -e 'Hello world\n'`);
+	cur_exe=getenv('ucode_bin');
+	system(`${cur_exe} -T, -c -o ./files/test7.uc -e 'Hello world\n'`);
 
 	let fn = loadfile('./files/test7.uc');
 	fn();
diff --git a/tests/custom/03_stdlib/69_readlink b/tests/custom/03_stdlib/69_readlink
new file mode 100644
index 00000000..a9bef09d
--- /dev/null
+++ b/tests/custom/03_stdlib/69_readlink
@@ -0,0 +1,25 @@
+The `readlink()` function will follow symbolink link to find the real name of the file 
+input to compile from the specified file path instead.
+
+-- Testcase --
+{%
+	import { readlink } from 'fs';
+	system('touch ./files/test_69.txt');
+	system('ls -1 ./files/test_69.txt');
+	system('ln -s ./files/test_69.txt ./files/test_symlink.txt');
+	system('ls -1 ./files/test_symlink.txt');
+	
+	final_name=readlink('./files/test_symlink.txt');
+	print(final_name,"\n");
+%}
+-- End --
+
+-- File test_69.txt --
+test 69 in test_69.txt
+-- End --
+
+-- Expect stdout --
+./files/test_69.txt
+./files/test_symlink.txt
+./files/test_69.txt
+-- End --
diff --git a/tests/custom/run_tests.sh b/tests/custom/run_tests.sh
index 96ac783e..31b96d09 100755
--- a/tests/custom/run_tests.sh
+++ b/tests/custom/run_tests.sh
@@ -6,12 +6,14 @@ else
 	readlink=readlink
 fi
 
+export LC_ALL=C
+
 testdir=$(dirname "$0")
 topdir=$($readlink -f "$testdir/../..")
 
 line='........................................'
-ucode_bin=${UCODE_BIN:-"$topdir/ucode"}
-ucode_lib=${UCODE_LIB:-"$topdir"}
+export ucode_bin=${UCODE_BIN:-"$topdir/ucode"}
+export ucode_lib=${UCODE_LIB:-"$topdir"}
 
 extract_sections() {
 	local file=$1
@@ -142,14 +144,14 @@ run_test() {
 
 	printf "%s %s " "$name" "${line:${#name}}"
 
-	mkdir "/tmp/test.$$"
-
-	extract_sections "$file" "/tmp/test.$$"
+	dir_4_test=$($readlink -f $(mktemp  -d /tmp/rt.XXXX ))
+	
+	extract_sections "$file" "${dir_4_test}"
 	tests=$?
 
-	[ -f "/tmp/test.$$/001.in" ] && testcase_first=1
+	[ -f "${dir_4_test}/001.in" ] && testcase_first=1
 
-	for res in "/tmp/test.$$/"[0-9]*; do
+	for res in "${dir_4_test}/"[0-9]*; do
 		case "$res" in
 			*.in)
 				count=$((count + 1))
@@ -157,7 +159,7 @@ run_test() {
 				if [ $testcase_first = 1 ]; then
 					# Flush previous test
 					if [ -n "$ein" ]; then
-						run_testcase $count "/tmp/test.$$" "$ein" "$eout" "$eerr" "$ecode" "$eargs" "$evars" || failed=$((failed + 1))
+						run_testcase $count "${dir_4_test}" "$ein" "$eout" "$eerr" "$ecode" "$eargs" "$evars" || failed=$((failed + 1))
 						eout=""
 						eerr=""
 						ecode=""
@@ -167,7 +169,7 @@ run_test() {
 
 					ein=$res
 				else
-					run_testcase $count "/tmp/test.$$" "$res" "$eout" "$eerr" "$ecode" "$eargs" "$evars" || failed=$((failed + 1))
+					run_testcase $count "${dir_4_test}" "$res" "$eout" "$eerr" "$ecode" "$eargs" "$evars" || failed=$((failed + 1))
 
 					eout=""
 					eerr=""
@@ -187,15 +189,14 @@ run_test() {
 
 	# Flush last test
 	if [ $testcase_first = 1 ] && [ -n "$eout$eerr$ecode" ]; then
-		run_testcase $count "/tmp/test.$$" "$ein" "$eout" "$eerr" "$ecode" "$eargs" "$evars" || failed=$((failed + 1))
+		run_testcase $count "${dir_4_test}" "$ein" "$eout" "$eerr" "$ecode" "$eargs" "$evars" || failed=$((failed + 1))
 	fi
 
-	rm -r "/tmp/test.$$"
-
 	if [ $failed = 0 ]; then
 		printf "OK\n"
+		rm -r "${dir_4_test}"
 	else
-		printf "%s %s FAILED (%d/%d)\n" "$name" "${line:${#name}}" $failed $tests
+		printf "%s %s FAILED (%d/%d)\ntemp dir was %s\n" "$name" "${line:${#name}}" $failed $tests $dir_4_test
 	fi
 
 	return $failed

From 92129a9cd204cbdfdf0ca7b736565a547986aaa2 Mon Sep 17 00:00:00 2001
From: Erwan MAS <erwan@mas.nom.fr>
Date: Sat, 4 Nov 2023 18:14:12 -0400
Subject: [PATCH 2/2] remove unuseful code

---
 tests/custom/03_stdlib/69_readlink | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/custom/03_stdlib/69_readlink b/tests/custom/03_stdlib/69_readlink
index a9bef09d..d3cc368f 100644
--- a/tests/custom/03_stdlib/69_readlink
+++ b/tests/custom/03_stdlib/69_readlink
@@ -4,7 +4,6 @@ input to compile from the specified file path instead.
 -- Testcase --
 {%
 	import { readlink } from 'fs';
-	system('touch ./files/test_69.txt');
 	system('ls -1 ./files/test_69.txt');
 	system('ln -s ./files/test_69.txt ./files/test_symlink.txt');
 	system('ls -1 ./files/test_symlink.txt');