Fixes#53
Open
richardson-t wants to merge 23 commits into
Open
Conversation
…les + update documentation
Owner
|
In opt_sampling.ipynb, don't show the Koen & Kondlo mass function. I think that's not a sensible thing to do: Koen & Kondlo assumes measurement error, but optimal sampling assumes that the mass function is set by physics, not measurement error. Right? |
keflavich
reviewed
May 23, 2026
Comment on lines
+482
to
+489
| def _max_star_prime(m, M_res, massfunc): | ||
| """ | ||
| Returns the derivative of _max_star at mass m. Used for Newton's method in | ||
| the case of an infinite upper bound on the provided mass function. | ||
| """ | ||
| term1 = _prefactor(m, massfunc)**2 * massfunc(m) * massfunc.m_integrate(massfunc.mmin, m)[0] | ||
| term2 = m * massfunc(m) * _prefactor(m, massfunc) | ||
| return -term1 - term2 - 1 |
Owner
There was a problem hiding this comment.
M_res isn't used. I suspect it's needed as a dummy variable here because of the use in root_scalar below. If that's right, add a note that M_res is a dummy variable or change its name to _ and still add that note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spot fixes for data/process errors found during paper review.