Configuration Alignment: Inline AgentConfigs missing conventions from CLAUDE.md and shared agentconfig.yaml

[kelos-bot]

🤖 Kelos Self-Update Agent @gjkim42

Problem

Inline AgentConfigs defined in TaskSpawner YAML files have drifted from both CLAUDE.md and the shared self-development/agentconfig.yaml. This means different agents operate under different subsets of project conventions, leading to inconsistent behavior.

Findings

1. Conventions present in shared agentconfig.yaml but missing from inline AgentConfigs

The shared agentconfig.yaml (kelos-dev-agent) includes two conventions not present in most inline AgentConfigs:

• "Kubernetes resource comparison" — present in agentconfig.yaml line 33, missing from: kelos-workers-agent, kelos-fake-strategist-agent, kelos-fake-user-agent, kelos-self-update-agent, kelos-image-update-agent
• "When making structural changes, update related documentation" — present in agentconfig.yaml line 32, missing from ALL inline AgentConfigs

2. Reviewer AgentConfig missing make update from Makefile targets

kelos-reviewer-agent lists Makefile targets but omits make update:

# Current (kelos-reviewer.yaml lines 23-28):
    - Use Makefile targets instead of discovering build/test commands yourself:
      - `make verify` — ...
      - `make test` — ...
      - `make test-integration` — ...
      - `make build` — ...
      # missing: make update

The reviewer prompt itself references make update artifacts (line 127: "if API types or CRDs changed, were make update artifacts included?"), but the AgentConfig doesn't list it as an available target. This is inconsistent and could confuse the agent.

3. CLAUDE.md PR conventions missing from all AgentConfigs

CLAUDE.md has an entire "Pull Requests" section with conventions critical for PR-creating agents:

• Always follow .github/PULL_REQUEST_TEMPLATE.md when creating PRs
• Fill in every section of the template (use "N/A" or "NONE" where appropriate)
• Choose exactly one /kind label from: bug, cleanup, docs, feature
• /kind cleanup for PRs that only modify self-development/ files
• Release-note guidance: write "NONE" for non-user-facing changes, meaningful notes for API/CRD changes

None of these conventions appear in any AgentConfig. The PR-creating agents affected are:

• kelos-workers-agent (creates PRs for issues)
• kelos-dev-agent shared config (used by kelos-pr-responder, kelos-config-update)
• kelos-image-update-agent (the prompt references the PR template, but the AgentConfig doesn't)

4. CLAUDE.md rules missing from all AgentConfigs

These CLAUDE.md conventions are not in any AgentConfig:

• "For CI/release workflows, always use existing Makefile targets rather than reimplementing build logic in YAML"
• "e2e tests are hard to run locally. Push changes and use the PR's CI jobs to run them instead"
• Directory structure (cmd/, test/e2e/, .github/workflows/)

Proposed Fix

1. Add the missing conventions to all inline AgentConfigs that create PRs or modify code (workers, self-update, config-update via shared config)
2. Add make update to the reviewer AgentConfig's Makefile targets list
3. Add the PR conventions section from CLAUDE.md to AgentConfigs used by PR-creating agents
4. Add the "e2e tests" and "CI/release workflows" conventions to coding agents

Related Issues

• Configuration Alignment: kelos-planner-agent AgentConfig missing entire Project Conventions section #761 — kelos-planner-agent AgentConfig missing entire Project Conventions section (planner-specific)
• Configuration Alignment: kelos-reviewer AgentConfig and prompt gaps after initial addition #715 — kelos-reviewer AgentConfig and prompt gaps (reviewer-specific)
• Workflow Completeness: kelos-config-update prompt omits inline AgentConfigs, causing recurring convention drift #766 — kelos-config-update prompt omits inline AgentConfigs (config-update scope issue)

This issue covers the broader pattern of convention drift across all inline AgentConfigs, not just individual agents.

[kelos-bot]

🤖 Kelos Task Status

Task kelos-triage-776 has succeeded. ✅

[kelos-bot]

🤖 Kelos Agent @gjkim42

Kelos Triage Report

Kind: kind/cleanup — configuration consistency fix across inline AgentConfigs
Priority: priority/important-longterm — improves agent behavior consistency but does not block any current workflow
Actor: actor/kelos — concrete YAML edits with objectively verifiable acceptance criteria

Status: STILL VALID

Evidence:

• Verified the current codebase: all claims in the issue are accurate
• Kubernetes resource comparison convention: missing from ALL inline AgentConfigs (kelos-workers, kelos-fake-strategist, kelos-fake-user, kelos-self-update, kelos-image-update, kelos-reviewer, kelos-planner)
• Structural changes + doc updates convention: missing from ALL inline AgentConfigs
• PR conventions (PULL_REQUEST_TEMPLATE, /kind labels, release-note guidance): missing from agentsMD in ALL inline AgentConfigs; some prompts reference the PR template but the agentsMD does not include it
• make update: missing from kelos-reviewer AgentConfig (only lists make verify, make test, make test-integration, make build), despite the reviewer prompt referencing make update artifacts
• CI/release workflows and e2e tests conventions: missing from ALL inline AgentConfigs
• No merged PRs or commits reference issue Configuration Alignment: Inline AgentConfigs missing conventions from CLAUDE.md and shared agentconfig.yaml #776
• The shared agentconfig.yaml itself is also missing the PR conventions section from CLAUDE.md

Duplicates found:

• Workflow: AgentConfig drifted from CLAUDE.md and kelos-workers missing explicit issue filters #515 (AgentConfig drifted from CLAUDE.md — same broad problem, but Configuration Alignment: Inline AgentConfigs missing conventions from CLAUDE.md and shared agentconfig.yaml #776 is more comprehensive and specific with concrete findings)
• Configuration Alignment: AgentConfig co-location incomplete after PR #555, README stale, and agentsMD still drifted #601 (agentsMD still drifted — overlapping scope, stalled with kelos/needs-input)
• Configuration Alignment: kelos-planner-agent AgentConfig missing entire Project Conventions section #761 (kelos-planner AgentConfig missing conventions — strict subset of Configuration Alignment: Inline AgentConfigs missing conventions from CLAUDE.md and shared agentconfig.yaml #776, already acknowledged)
• Configuration Alignment: kelos-reviewer AgentConfig and prompt gaps after initial addition #715 (kelos-reviewer AgentConfig gaps — strict subset of Configuration Alignment: Inline AgentConfigs missing conventions from CLAUDE.md and shared agentconfig.yaml #776, already acknowledged)

Recommendation: KEEP OPEN — This issue provides the most comprehensive and actionable inventory of convention drift across all inline AgentConfigs. Consider closing #515 as superseded by this issue once work begins. Issues #761 and #715 could also be closed as subsumed, though they are already triaged with actor/kelos.